From patchwork Mon May 22 11:40:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 127158 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C610442B6F; Mon, 22 May 2023 13:40:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 865F742D3B; Mon, 22 May 2023 13:40:42 +0200 (CEST) Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2115.outbound.protection.outlook.com [40.107.102.115]) by mails.dpdk.org (Postfix) with ESMTP id 6965C42D3B for ; Mon, 22 May 2023 13:40:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jjRCmBfCVFUQbI0VV7y61fvGfx/b8zuQZR217HEDMBxnDOYvIy7namNhkW8uE6yjUZMHuJQrN5ruDzN5U/lBuVh1FnvQMufTVrKvv7S1cgznApjU4wgTR7q2Pc9KjAvVUqTMgaI73mF+cDeO74YAoAhFheqOe7PIAU7Fh2z3vTZR2kzmw/RJ+ntLUhmatpxgH01/cdRcJ8U5Is9PHJxZtpIYetx3yuzlra88w8MfnAQCKZM+RjaqQtSkcMA7tVedGg94Tcl9LB/kxm5+xpoAjlBYi19MlA5C43PGDpPktQhauP2W8UHy7BebjlQWVm/l+qwmzcGjdRaIndTrzVDB0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ttktKr0MJfw7bD/rPRIhzHlxMvCDycuF0Teu2YtNYbk=; b=mZHPMr6ndDfOr2uTqrdzp6+4N3VYBed+FCuT5q2rEsOaeOmobcOaMJtxHbgDtmfgNPLzjWLDgZlrD+I9WZLzOccuNbxwYYVjpXPZipTVtl+alxiIXElWxPJH1B7laU8zOOQhsO5r9OOX1FXo1QmumdbMpL86PlAYrtcF7cKAKVF4hvto9ypwMKl2Hjf9D7l6R4cDRXm2n1y6O2ChztZ+GjF0JjYYUucfWWTRGaJpeL49SaryoBLuQVo6RJuC29eGbu29CRSUf025Nag6BM7TNHLimQ+/ku2DmEJUw09T27PsGHoW3Xdh+VvRU0Zhup1ZuyvlJ8PVmZrE8d37h3xVHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ttktKr0MJfw7bD/rPRIhzHlxMvCDycuF0Teu2YtNYbk=; b=KDTpgPshhPclWblg4hRh30FgwZsdDWs6ofUjXhmtLKtNYsg0kfpBKp9pOEdCAnVVHHOzK0bYBzlv+OUZ3oVn0obr9hkRX05/p9fxB3CWZo4W4O0WOXGDn5M0nXib4LjenSxBOcDv8NyFhNP4EX3h6Mcac80pWdwf6txCXY0+QX0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SN4PR13MB5693.namprd13.prod.outlook.com (2603:10b6:806:1ec::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Mon, 22 May 2023 11:40:37 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ac2e:52b6:82ec:4994]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ac2e:52b6:82ec:4994%3]) with mapi id 15.20.6411.028; Mon, 22 May 2023 11:40:36 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He Subject: [PATCH 2/2] net/nfp: add support of showing firmware version Date: Mon, 22 May 2023 19:40:09 +0800 Message-Id: <20230522114009.2099371-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230522114009.2099371-1-chaoyong.he@corigine.com> References: <20230522114009.2099371-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SI2PR06CA0005.apcprd06.prod.outlook.com (2603:1096:4:186::12) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SN4PR13MB5693:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f78ba91-1e2e-4f0c-6202-08db5ab95c3a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JXAIQKPRKqbJvJBtXyhsqk/LUi4CIQQiHjPt/huKSWTIxoPgmEP4XDEHrivuhTJjPMZCbC5djdJLjVDHFtvOzBE7atXJIb7MMLmN/oyyuBGttJ3tfpy51e3z3OLsp1Wli9xC9RF6LgeeTszHY52zkk+ZwRf9zbOksSOyrQmNIjRCSkuY69DiRFCTrQXRePyI/Jv+M6PTmeu0yhiDAQTopii7ffLIsQXvTPCH35f7upz4fbfBhlgyds8SL+JcSUXjv2shzah2fx7U3y1Setx72rwz0Pjlnc/zEHfNwxQhQi8NGpegVG+AQAcikV/oGMboApak9DSM9lGKMdrULL523GOzTtuKQOL5sX8NWrGdCM+D+mgsj9hkct1+ZnbRV+lLJzw4cYPB181QOIExSPXXH83yeLkcuDSi5y7bC5BI2tbpp9tGrA7zfRchH5XyQYbQ+HFNCUrP41JkJY7C2oBglGxCJTfFerAOHNjR5K4YohdXBn+qiqua4UDlOpbtfB9RYKm/ZsCA/Kk0G83Jo9BnXhB4/dg0p0kcIaUJbOONNUNZytFMz9RPu0/jpq3m7m46QicPIuWdlo7zw4pCxVhzqQqu/7TcO6JL7YUdDNA1Ia/fHuejbwxh8Jdll/r/tVMFJERMHOFs/5Zb3cI+xEH7ZfYC0dN4V2vl/mEIrrq8go4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(346002)(396003)(39840400004)(136003)(451199021)(38100700002)(38350700002)(478600001)(4326008)(66946007)(66556008)(66476007)(6916009)(66574015)(83380400001)(2616005)(2906002)(6666004)(316002)(186003)(26005)(86362001)(6512007)(6506007)(1076003)(41300700001)(6486002)(5660300002)(44832011)(52116002)(107886003)(8676002)(8936002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ocvO2U47QMaY1RAR9ESMdJf8W1bx?= =?utf-8?q?6HlRizbM0lHp3N/rmgaeRHHhlaJEtIK6RYv1ICOAl99Pb4WElcJVrtnL3C9cMg69P?= =?utf-8?q?J4sOqwj3I80BcKWCah47Z6AY160MtGSA6d5HuD3ekS+WONf2dVbvk0szmEHH8hvir?= =?utf-8?q?MARFe2C12AWqaASGMU4tIhPtm8Qqn9kN17SRfAhTT+mADDhIMOdxy59WjNpHbRyhr?= =?utf-8?q?lGNU6zyKr626j7gAPuVuftxX/yxULLw8K7gabIGBwomGV65nvw1ZIlwW0lA/Qf6Hl?= =?utf-8?q?KU2BLnV0/Eoeu/JdKpTecgOcY7/H8Yvj6mAy6DG+yJJ2SNAF2/ReXl0z2btgPVozq?= =?utf-8?q?v7wQhHu70rmU2cMKBK1FepuYHhG4hXDmfuw7K1Ur68rMuKHLrwgzn2locjaILIO7f?= =?utf-8?q?FRDvP7bCcN1+Bc3FwjQ6bVsPPV6uJkNeeapeYy4nq2P3diuq7Ds2UYZsOBhwSWzG/?= =?utf-8?q?P5ujIgQ62MTpB8AFfaRBShzzBFkznAW5lg1kqeGAgn71jUqnHApcWmc6cwCeUaDEC?= =?utf-8?q?5yJHayTYDWdw4kkQE8fvIoJgZAGGaFkuOwG0jl1WeAWTDTy6iupVt5x3QXG/VT4qI?= =?utf-8?q?sli+2nNAig4PoCVmDQ3/P6SyZGJt8n9xzcUNMFJBAjSt/gx7ERtOLyRFsB3u5+wBD?= =?utf-8?q?7XLFTYLFS2p7EV4VyiaU3UUAplNOefDLoOOj5aeZ5iZO9VIQqTWO4NA56W5lZUp8s?= =?utf-8?q?SV8LjJlo+VnKHe2HQhDI3k5kWMswuAJgicVRu9WE4bsqAWVfzIy7fw1S12tTUa2+q?= =?utf-8?q?sW6ltJ62PVnku5g+oNDgQVhXsH9qw87eujYCpD1sz7aruw1M5Ngxu5oC98GLdnTHk?= =?utf-8?q?12xaHFLWKlFz/+hGxfZNGEEl2MfRsRfP09wX/xJRwfv48qujkk7GjIR2LwTTsNAO3?= =?utf-8?q?BnID83jrR8ghZmAxYQF9i1p5co0tf1frDB4CZmSuo3EyalS2DPq/L+HwS2Yd/mwmv?= =?utf-8?q?duRb3/slUrvBG23Ip336MP7KT/vEOTOzPnbbiNmiIvViRUXxQnRc7lhWrPmy+Nn/S?= =?utf-8?q?kwDXS7ZBow000maqIx+gsE7odfsSDxtj6WCtLLhSe191rxgbCRoYrSArUdlDPXxeh?= =?utf-8?q?aDnygzTqEnPCXg7/zFWAbFVNtHjghDD0XEU7LjurSsDorjVk9JR1uPgjTIW+I1p3b?= =?utf-8?q?LkP9UWSPzBuD1xki+ZLAoNVHW0jQn+Vyk5QhPBKj6ZJmbO5SRNTULD4nqNvvl5F9i?= =?utf-8?q?rFXF8SAZaJicT1BhCmFMo92oxq96fhRJMXxoNLuSNRZp1mE/V6CdQdx32XO5dpXVB?= =?utf-8?q?DCZyOgYsN3DKunVYVGvttP1vo73IidxUbpvDsxt1xymNTdGKmhP8DN+r9xRZowvVY?= =?utf-8?q?/LkOzLShjO3aKTBP9jyqHkR9RVEdnzjdd3qV0NYWaWwsmD84Op34u1n/CObJd50eE?= =?utf-8?q?TBHrMXtilWkZXkiURAtleTjOoJqwhL4B+UfjRytX210OVNXfGKhXo6L7tu8EYoQNo?= =?utf-8?q?T3Z0F+NKWS31iNaNuYbktDEjeqmNpG8OjCzRLOSzhoVUiVKJfvXotc0zfRdfsY+Dx?= =?utf-8?q?CYOd+UWHMIjP+Ul7j6TdXVwjlQsgZsacPA=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f78ba91-1e2e-4f0c-6202-08db5ab95c3a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 11:40:36.8142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ne2WX27QZ6HzUZ0EOLy/qk5h2v/h07F1uCIAIgobWbFNrQ3rp3D+RVz01qKcxYhFml3J+XEpBDBge+beuWDGGnu/eTPjQJ5Np8blq7ewIJM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5693 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add support of showing firmware version. When using the flower firmware, the firmware version output of common port is '0.0.5.5 0.31 AOTC-2.14.A.54 flo', while the firmware version output of representor port is '* 0.31 AOTC-2.14.A.54 flower'. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- .../net/nfp/flower/nfp_flower_representor.c | 2 + drivers/net/nfp/nfp_common.c | 106 ++++++++++++++++++ drivers/net/nfp/nfp_common.h | 2 + drivers/net/nfp/nfp_ethdev.c | 1 + drivers/net/nfp/nfp_ethdev_vf.c | 1 + 5 files changed, 112 insertions(+) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c index c3764b4de7..607625d204 100644 --- a/drivers/net/nfp/flower/nfp_flower_representor.c +++ b/drivers/net/nfp/flower/nfp_flower_representor.c @@ -525,6 +525,7 @@ static const struct eth_dev_ops nfp_flower_pf_repr_dev_ops = { .promiscuous_disable = nfp_net_promisc_enable, .mac_addr_set = nfp_flower_repr_mac_addr_set, + .fw_version_get = nfp_repr_firmware_version_get, }; static const struct eth_dev_ops nfp_flower_repr_dev_ops = { @@ -546,6 +547,7 @@ static const struct eth_dev_ops nfp_flower_repr_dev_ops = { .promiscuous_disable = nfp_net_promisc_enable, .mac_addr_set = nfp_flower_repr_mac_addr_set, + .fw_version_get = nfp_repr_firmware_version_get, .flow_ops_get = nfp_net_flow_ops_get, .mtr_ops_get = nfp_net_mtr_ops_get, diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c index a9af215626..88fc50c6d6 100644 --- a/drivers/net/nfp/nfp_common.c +++ b/drivers/net/nfp/nfp_common.c @@ -214,6 +214,9 @@ nfp_net_notify_port_speed(struct rte_eth_dev *dev) nfp_net_link_speed_rte2nfp(eth_table->ports[hw->idx].speed)); } +/* The length of firmware version string */ +#define FW_VER_LEN 32 + static int __nfp_net_reconfig(struct nfp_net_hw *hw, uint32_t update) { @@ -1954,3 +1957,106 @@ nfp_net_cfg_read_version(struct nfp_net_hw *hw) version.whole = nn_cfg_readl(hw, NFP_NET_CFG_VERSION); hw->ver = version.split; } + +static void +nfp_net_get_nsp_info(struct nfp_net_hw *hw, char *nsp_version) +{ + struct nfp_nsp *nsp; + + nsp = nfp_nsp_open(hw->cpp); + if (nsp == NULL) + return; + + snprintf(nsp_version, FW_VER_LEN, "%hu.%hu", + nfp_nsp_get_abi_ver_major(nsp), + nfp_nsp_get_abi_ver_minor(nsp)); + + nfp_nsp_close(nsp); +} + +static void +nfp_net_get_mip_name(struct nfp_net_hw *hw, char *mip_name) +{ + struct nfp_mip *mip; + + mip = nfp_mip_open(hw->cpp); + if (mip == NULL) + return; + + snprintf(mip_name, FW_VER_LEN, "%s", nfp_mip_name(mip)); + + nfp_mip_close(mip); +} + +static void +nfp_net_get_app_name(struct nfp_net_hw *hw, char *app_name) +{ + switch (hw->pf_dev->app_fw_id) { + case NFP_APP_FW_CORE_NIC: + snprintf(app_name, FW_VER_LEN, "%s", "nic"); + break; + case NFP_APP_FW_FLOWER_NIC: + snprintf(app_name, FW_VER_LEN, "%s", "flower"); + break; + default: + snprintf(app_name, FW_VER_LEN, "%s", "unknown"); + break; + } +} + +int +nfp_net_firmware_version_get(struct rte_eth_dev *dev, + char *fw_version, + size_t fw_size) +{ + struct nfp_net_hw *hw; + char mip_name[FW_VER_LEN]; + char app_name[FW_VER_LEN]; + char nsp_version[FW_VER_LEN]; + char vnic_version[FW_VER_LEN]; + + if (fw_size < FW_VER_LEN) + return FW_VER_LEN; + + hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private); + + snprintf(vnic_version, FW_VER_LEN, "%d.%d.%d.%d", + hw->ver.extend, hw->ver.class, + hw->ver.major, hw->ver.minor); + + nfp_net_get_nsp_info(hw, nsp_version); + nfp_net_get_mip_name(hw, mip_name); + nfp_net_get_app_name(hw, app_name); + + snprintf(fw_version, FW_VER_LEN, "%s %s %s %s", + vnic_version, nsp_version, mip_name, app_name); + + return 0; +} + +int +nfp_repr_firmware_version_get(struct rte_eth_dev *dev, + char *fw_version, + size_t fw_size) +{ + struct nfp_net_hw *hw; + char mip_name[FW_VER_LEN]; + char app_name[FW_VER_LEN]; + char nsp_version[FW_VER_LEN]; + struct nfp_flower_representor *repr; + + if (fw_size < FW_VER_LEN) + return FW_VER_LEN; + + repr = dev->data->dev_private; + hw = repr->app_fw_flower->pf_hw; + + nfp_net_get_nsp_info(hw, nsp_version); + nfp_net_get_mip_name(hw, mip_name); + nfp_net_get_app_name(hw, app_name); + + snprintf(fw_version, FW_VER_LEN, "* %s %s %s", + nsp_version, mip_name, app_name); + + return 0; +} diff --git a/drivers/net/nfp/nfp_common.h b/drivers/net/nfp/nfp_common.h index 424b18b0ad..4b588b2948 100644 --- a/drivers/net/nfp/nfp_common.h +++ b/drivers/net/nfp/nfp_common.h @@ -473,6 +473,8 @@ int nfp_net_tx_desc_limits(struct nfp_net_hw *hw, int nfp_net_check_dma_mask(struct nfp_net_hw *hw, char *name); void nfp_net_init_metadata_format(struct nfp_net_hw *hw); void nfp_net_cfg_read_version(struct nfp_net_hw *hw); +int nfp_net_firmware_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size); +int nfp_repr_firmware_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size); #define NFP_NET_DEV_PRIVATE_TO_HW(adapter)\ (&((struct nfp_net_adapter *)adapter)->hw) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 0b2dd7801b..10c66cd027 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -461,6 +461,7 @@ static const struct eth_dev_ops nfp_net_eth_dev_ops = { .rx_queue_intr_disable = nfp_rx_queue_intr_disable, .udp_tunnel_port_add = nfp_udp_tunnel_port_add, .udp_tunnel_port_del = nfp_udp_tunnel_port_del, + .fw_version_get = nfp_net_firmware_version_get, }; static inline int diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c index cf3548e63a..d4357ad115 100644 --- a/drivers/net/nfp/nfp_ethdev_vf.c +++ b/drivers/net/nfp/nfp_ethdev_vf.c @@ -241,6 +241,7 @@ static const struct eth_dev_ops nfp_netvf_eth_dev_ops = { .tx_queue_release = nfp_net_tx_queue_release, .rx_queue_intr_enable = nfp_rx_queue_intr_enable, .rx_queue_intr_disable = nfp_rx_queue_intr_disable, + .fw_version_get = nfp_net_firmware_version_get, }; static inline int