net/qede: fix RSS indirection table initialization

Message ID 20230525053001.283328-1-dsinghrawat@marvell.com (mailing list archive)
State Changes Requested, archived
Delegated to: Jerin Jacob
Headers
Series net/qede: fix RSS indirection table initialization |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed

Commit Message

Devendra Singh Rawat May 25, 2023, 5:30 a.m. UTC
  RSS indirection table was not updated for VF ports during RSS hash
update, this resulted in device start failure.
This fix updates RSS indirection table during RSS hash update.

Fixes: 7ab35bf6b97b (net/qede: fix RSS)
Cc: stable@dpdk.org

Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
Signed-off-by: Alok Prasad <palok@marvell.com>
---
 drivers/net/qede/qede_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Jerin Jacob May 25, 2023, 12:22 p.m. UTC | #1
On Thu, May 25, 2023 at 2:59 PM Devendra Singh Rawat
<dsinghrawat@marvell.com> wrote:
>
> RSS indirection table was not updated for VF ports during RSS hash
> update, this resulted in device start failure.
> This fix updates RSS indirection table during RSS hash update.
>
> Fixes: 7ab35bf6b97b (net/qede: fix RSS)

[for-next-net]dell[dpdk-next-net-mrvl] $ ./devtools/check-git-log.sh -n 1
Wrong tag:
        Fixes: 7ab35bf6b97b (net/qede: fix RSS)
Wrong 'Fixes' reference:
        Fixes: 7ab35bf6b97b (net/qede: fix RSS)

Invalid patch(es) found - checked 1 patch

> Cc: stable@dpdk.org
>
> Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
> Signed-off-by: Alok Prasad <palok@marvell.com>
> ---
>  drivers/net/qede/qede_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
> index a4923670d6..22cd470646 100644
> --- a/drivers/net/qede/qede_ethdev.c
> +++ b/drivers/net/qede/qede_ethdev.c
> @@ -2142,6 +2142,7 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
>                 rss_params.rss_enable = 1;
>         }
>
> +       rss_params.update_rss_ind_table = 1;
>         rss_params.update_rss_config = 1;
>         /* tbl_size has to be set with capabilities */
>         rss_params.rss_table_size_log = 7;
> --
> 2.18.2
>
  

Patch

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index a4923670d6..22cd470646 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -2142,6 +2142,7 @@  int qede_rss_hash_update(struct rte_eth_dev *eth_dev,
 		rss_params.rss_enable = 1;
 	}
 
+	rss_params.update_rss_ind_table = 1;
 	rss_params.update_rss_config = 1;
 	/* tbl_size has to be set with capabilities */
 	rss_params.rss_table_size_log = 7;