From patchwork Fri May 26 03:18:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suanming Mou X-Patchwork-Id: 127531 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 538E042BA3; Fri, 26 May 2023 05:18:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4678540A89; Fri, 26 May 2023 05:18:37 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2069.outbound.protection.outlook.com [40.107.223.69]) by mails.dpdk.org (Postfix) with ESMTP id D446540A87 for ; Fri, 26 May 2023 05:18:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jj8EP9MvJBUayDj4OWt8yhV5T35yaWQGMysmcB4fFKWC04saOpZ0ibEsQyC3lw9cCEaKPztYfoVHNR/0+oF20C0MhPZ/U1PBclp8uq8Z7CnoT4JBcGg5d68k0bgoq3XBEBnTn6y/6WgVyoZNoEggnI/1bZ5pTinBBr3HN4LxuQP1CBaa1JqBoIdCQ11zZxvrK1iVpuW6g2AySswkTAv6ZyaJU4XqBy+8lFZqaHniJxTTKVW9Xyw11+jcxxEzWQnPOf3gKOI6chR7XnuWmIWcoZZVlH8n4kESDaEnV12T9VTJXL5RZMJhyYME+zU1HuRjOtNEqxQ1tnGoSjeS+bM/eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/3Twr3MskhbE5+bZUz0TEwxNx7Uls7raRlLs27CxoRs=; b=d4Z9rh+NtpI6yU9YXFO0jgtjzj2ZmTGQNT6F+HRLProWizA8XTvX4rsUPHIbwO9173ScvusPzaRYMqpLmMfJgPNlGURutHDD2/w2f3FBRMQuZfkEjsZL3f2vaH4Hbv8oBWO3AHqHUnuRB3DMAqu96ni8detH//PLkORHdBgpgc57ZPQ1X/J4YQDwypRLy2zt2DVh8QnuoJMfgukRrv7989spgoULDlHMDI08KodV3+0iH7i7ajnI38emWqyVhXMA9ouDo2wxRaTuX9vsJC5AiCGxwqmW6ZDvsSGoP8n0j6FBBkxPBfTFVPi9jsp9dvWk9q1/8iDRIFY2HwtvyYPkVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/3Twr3MskhbE5+bZUz0TEwxNx7Uls7raRlLs27CxoRs=; b=XZbvjvJajRuJEyw8EL5AEySwbPGZR2xyPWRX9uVaF3otD4yRZ0qOqBVYdO2o2N4wQAkQN5ab9rpyQV3/2dlZt7R9vPwIZRKBi66dsVU3SYETznDvlW7q8gS6FqgUWpY4oAE/mm6nCMChJ4Tn2Svhj4mmUZlUcR7gON89dJNMtfuOtnSMZSJwJZ0mZxMOOWukeHDWP8ah5gV5p02HFq0jfpm/riFQu8Zf7Swl9lmo3m88+DMSMJ7fka0y9IzoUqpp8ZsLsWTDAZBMAxOKr8VX8sRk3F2WxD8M9czi4BkilvKx4LsY2+BPlv2Ifo4BB9QOlc03Ck+3TLRl5d9yvQZg6A== Received: from BN0PR03CA0031.namprd03.prod.outlook.com (2603:10b6:408:e7::6) by PH0PR12MB7789.namprd12.prod.outlook.com (2603:10b6:510:283::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.21; Fri, 26 May 2023 03:18:33 +0000 Received: from BN8NAM11FT062.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e7:cafe::48) by BN0PR03CA0031.outlook.office365.com (2603:10b6:408:e7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.17 via Frontend Transport; Fri, 26 May 2023 03:18:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT062.mail.protection.outlook.com (10.13.177.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.16 via Frontend Transport; Fri, 26 May 2023 03:18:33 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 25 May 2023 20:18:21 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 25 May 2023 20:18:18 -0700 From: Suanming Mou To: Ori Kam , Thomas Monjalon , "Ferruh Yigit" , Andrew Rybchenko CC: Subject: [PATCH] ethdev: fix indirect action convert Date: Fri, 26 May 2023 06:18:00 +0300 Message-ID: <20230526031800.913744-1-suanmingm@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT062:EE_|PH0PR12MB7789:EE_ X-MS-Office365-Filtering-Correlation-Id: a1464e32-5a6e-4df4-7eed-08db5d97e32f X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1XGzRE7qH6EsQJ7i8DA5108vfYgmPlrtbS2lOB16wDOMJ5deLKweHmWENsVYuDUPbS1OGPUKHgPbxQTp7u9OCUqMmG1ySwM/NMu93iNWeLafu24rEMxwPokkt7RKTT7RFXZkwc/yCUgz8lE9lG6Pl56regAQZ6VUxoWdR2e0OOA3hAyb1gIdMbTSiPjp7B6IY+X5Kqq0ON9CoFlx0R76Pmm0ny6QNqGTOF0LQpiNrBBqfJOydPmf9AwSElMHIINC9clFmPxJmkZh66remaqa0c6PRD8rRjvPt+RynMQj9/waMPIHIkJoqqtRSoSIl4ijM/56pTnIKVQIvV6eBImAhhlnqceMthNuStCBx271nTW3J81KXqKQf+WlquDysr9U61xD+nmwg7EvCa392qRSx20EfHzS1DxZnnAkWeYeDc5z8LqX9exaHNSnl3Ls3tHFa7ZV+JoNMfwUNCaaLev27BHF+Yj0tf8SOVzUfcs4FdyO0ezSHwibXJur+6br6wV3n/vJ1G3nVUKATqbBqhGWLiAyY0k3P/JNkwqqikwEzbTB+1oZk/4/t1qQesrFLRFu6tocbDaw4QhLtYdNt6BIbhvewVsxc0NygmmyrbXMLMlAWLdof9LVfvmdwDba1Fu3OQEMzDWzW7b9z5KESC6GVYubpy6DG+UuYJ9xqhP0rxkRWIZEJq8x37r/H3Hjije6Ln0/iiXwoTgedxIawzdcdYWbOXL+QCJOxM0nMobRgV+5SWW7ZWIrDtVtrH9mvkGV X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199021)(36840700001)(46966006)(40470700004)(110136005)(6666004)(55016003)(1076003)(26005)(70586007)(70206006)(4326008)(316002)(41300700001)(478600001)(7696005)(8676002)(5660300002)(40460700003)(8936002)(40480700001)(82740400003)(356005)(82310400005)(16526019)(83380400001)(86362001)(426003)(36756003)(336012)(2906002)(2616005)(7636003)(186003)(6286002)(47076005)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2023 03:18:33.4011 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a1464e32-5a6e-4df4-7eed-08db5d97e32f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT062.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7789 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org As indirect action conf fills the indirect action handler, while converting indirect action, the action conf(action handler) should be copied from original indirect action conf instead of duplicating the action handler memory. Fixes: 4b61b8774be9 ("ethdev: introduce indirect flow action") Signed-off-by: Suanming Mou Acked-by: Ori Kam --- lib/ethdev/rte_flow.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 69e6e749f7..ff740f19a4 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -889,7 +889,15 @@ rte_flow_conv_actions(struct rte_flow_action *dst, src -= num; dst -= num; do { - if (src->conf) { + if (src->type == RTE_FLOW_ACTION_TYPE_INDIRECT) { + /* + * Indirect action conf fills the indirect action + * handler. Copy the action handle directly instead + * of duplicating the pointer memory. + */ + if (size) + dst->conf = src->conf; + } else if (src->conf) { off = RTE_ALIGN_CEIL(off, sizeof(double)); ret = rte_flow_conv_action_conf ((void *)(data + off),