From patchwork Mon May 29 11:21:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fengnan Chang X-Patchwork-Id: 127665 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7477742BD2; Mon, 29 May 2023 13:22:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 660CB410DD; Mon, 29 May 2023 13:22:04 +0200 (CEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 2CFA0410D7 for ; Mon, 29 May 2023 13:22:03 +0200 (CEST) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1b02750ca0dso3317375ad.0 for ; Mon, 29 May 2023 04:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1685359322; x=1687951322; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ued/6yh2cSYVnX993KnhUP879mZREW917c10tOYjhk8=; b=E6ssFXdPVwsXSgJl2H6KTYLj6Zext+YF5fKOdAEh/CSmM7t0owMpb7OFKw/mb6BcOO /piDLVWRmDxAFmAdVExxKwvvX3R3UUx6dVlAPVDxhTDaZqdySK/i1k5XuwzXq1QWyJU/ aLP0FclUlHbhinsOIEhWwEl14nwShyOb4OA7oAjg50SxtUgXj0W/zP5PGTKB99g9Y9La CSbBZgATJgRF9HD051NZzL37hWegburalOqVM7ZU29+Mba4Hx7PsjVe1WUQWo2JCBHVr YkzQpwEpovxmzebnr2ZA88z2wxfD2JiXzz9ETtBGNrNVlcjwST/R7JA4JMk8+v6d4Nf9 2mJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685359322; x=1687951322; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ued/6yh2cSYVnX993KnhUP879mZREW917c10tOYjhk8=; b=BjT3H4ovy6/m5qMGT2HrdT827P0QPXgdSIVTjc4CkDV45tal8VNIIHhU3Z+/ORl8bi 1LbqdKK55WR4ESOWCNSV40S3LVkq+SV7RyoqiwdChI/gIAns/BEz4TmyW/rmKjoz8Lqz ux7MO/Ed3LDV7pfIPYs87JzH27yfbuz7kyQ0TzuGEqgJocnoof4JHSNHZkFZmBMLK7Fa wNRRrfwoWTEFxENllTAVWpmjfPsnZMD4M4XdaMNyPf1H+yaVE0JxLA4pWYGOEtmCjYRQ 2CjJrjRFcmGY7aGo0n3EnPe336I6YoOPuTBENoX86zC9VDnot6nV4WQYA3xvU+sV9ALS waQw== X-Gm-Message-State: AC+VfDxo7sIqcgDcuklyXtWKXOOfZ2Erx3o832LSUR2WluUJ4nPtOXE/ 0YYAEn3hjRjtHLuqC9xEzyuAQQ== X-Google-Smtp-Source: ACHHUZ6XEt7NMPmmVXs0ZWN1CBexV+YAxaWqH6tA9gCC89OLZmMDMD18Fr+ufpz9l7eiIGURmlw2pw== X-Received: by 2002:a17:902:e5c8:b0:1b0:34c6:3bf2 with SMTP id u8-20020a170902e5c800b001b034c63bf2mr5405278plf.5.1685359322378; Mon, 29 May 2023 04:22:02 -0700 (PDT) Received: from HTW5T2C6VL.bytedance.net ([240e:694:e21:b::2]) by smtp.gmail.com with ESMTPSA id ik7-20020a170902ab0700b001b04772d33esm1469324plb.165.2023.05.29.04.22.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 29 May 2023 04:22:02 -0700 (PDT) From: Fengnan Chang To: anatoly.burakov@intel.com, dev@dpdk.org Cc: Fengnan Chang Subject: [PATCH] eal: fix prompt info when remap_segment failed Date: Mon, 29 May 2023 19:21:55 +0800 Message-Id: <20230529112155.11247-1-changfengnan@bytedance.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org when there is enough space for memseg, we should pormpt which config to modify, not just print numbers. Signed-off-by: Fengnan Chang --- lib/eal/linux/eal_memory.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c index 0876974631..974db901b7 100644 --- a/lib/eal/linux/eal_memory.c +++ b/lib/eal/linux/eal_memory.c @@ -716,9 +716,8 @@ remap_segment(struct hugepage_file *hugepages, int seg_start, int seg_end) break; } if (msl_idx == RTE_MAX_MEMSEG_LISTS) { - RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase %s and/or %s in configuration.\n", - RTE_STR(RTE_MAX_MEMSEG_PER_TYPE), - RTE_STR(RTE_MAX_MEM_MB_PER_TYPE)); + RTE_LOG(ERR, EAL, "Could not find space for memseg. Please increase RTE_MAX_MEMSEG_PER_LIST " + "RTE_MAX_MEMSEG_PER_TYPE and/or RTE_MAX_MEM_MB_PER_TYPE in configuration.\n"); return -1; }