common/sfc_efx/base: update fields name for MARK and FLAG actions

Message ID 20230531070856.93296-1-artemii.morozov@arknetworks.am (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series common/sfc_efx/base: update fields name for MARK and FLAG actions |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS

Commit Message

Artemii Morozov May 31, 2023, 7:08 a.m. UTC
  The MCDI headers have newer, but ABI-compatible field names for
these actions.

Signed-off-by: Artemii Morozov <artemii.morozov@arknetworks.am>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
---
 drivers/common/sfc_efx/base/ef10_filter.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
  

Comments

Ferruh Yigit June 1, 2023, 3:43 p.m. UTC | #1
On 5/31/2023 8:08 AM, Artemii Morozov wrote:
> The MCDI headers have newer, but ABI-compatible field names for
> these actions.
> 
> Signed-off-by: Artemii Morozov <artemii.morozov@arknetworks.am>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
>

Applied to dpdk-next-net/main, thanks.
  

Patch

diff --git a/drivers/common/sfc_efx/base/ef10_filter.c b/drivers/common/sfc_efx/base/ef10_filter.c
index 6d19797d16..d6940011c0 100644
--- a/drivers/common/sfc_efx/base/ef10_filter.c
+++ b/drivers/common/sfc_efx/base/ef10_filter.c
@@ -329,13 +329,13 @@  efx_mcdi_filter_op_add(
 		goto fail3;
 	}
 	if (spec->efs_flags & EFX_FILTER_FLAG_ACTION_MARK) {
-		MCDI_IN_SET_DWORD(req, FILTER_OP_V3_IN_MATCH_ACTION,
-		    MC_CMD_FILTER_OP_V3_IN_MATCH_ACTION_MARK);
+		MCDI_IN_SET_DWORD_FIELD(req, FILTER_OP_V3_IN_MATCH_ACTION_FLAGS,
+		    FILTER_OP_V3_IN_MATCH_SET_MARK, 1);
 		MCDI_IN_SET_DWORD(req, FILTER_OP_V3_IN_MATCH_MARK_VALUE,
 		    spec->efs_mark);
 	} else if (spec->efs_flags & EFX_FILTER_FLAG_ACTION_FLAG) {
-		MCDI_IN_SET_DWORD(req, FILTER_OP_V3_IN_MATCH_ACTION,
-		    MC_CMD_FILTER_OP_V3_IN_MATCH_ACTION_FLAG);
+		MCDI_IN_SET_DWORD_FIELD(req, FILTER_OP_V3_IN_MATCH_ACTION_FLAGS,
+		    FILTER_OP_V3_IN_MATCH_SET_FLAG, 1);
 	}
 
 	efx_mcdi_execute(enp, &req);