diff mbox series

[24/25] net/qede: replace snprintf with strlcpy

Message ID	20230601150106.18375-25-stephen@networkplumber.org (mailing list archive)
State	Rejected, archived
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Devendra Singh Rawat <dsinghrawat@marvell.com>, Alok Prasad <palok@marvell.com> Subject: [PATCH 24/25] net/qede: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:01:05 -0700 Message-Id: <20230601150106.18375-25-stephen@networkplumber.org> In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace snprintf with strlcpy \| [00/25] replace snprintf with strlcpy [01/25] app: use strlcpy in tests [02/25] examples: use strlcpy instead of snprintf [03/25] lib: use strlcpy instead of snprintf [04/25] raw/ifpga: replace snprintf with strlcpy [05/25] common/cnxk: replace snprint with strlcpy [06/25] common/mlx5: replace snprintf with strlcpy [07/25] drivers/gpu: replace snprintf with strlcpy [08/25] crypto/ipsec_mb: remove unnecessary snprintf [09/25] crypto/dpaa_sec: replace snprintf with strlcpy [10/25] event/cnxk: replace snprintf with strlcpy [11/25] net/atlantic: replace snprintf with strlcpy [12/25] net/axgbe: replace snprintf with strlcpy [13/25] net/bnxt: replace snprintf with strlcpy [14/25] net/cpfl: replace snprintf with strlcpy [15/25] net/cxgbe: replace snprintf with strlcpy [16/25] net/dpaa*: replace snprintf with strlcpy [17/25] net/hinic: replace snptintf with strlcpy [18/25] net/hns3: replace snprint with strlcpy [19/25] net/intel: replace snprintf with strlcpy [20/25] net/ionic: replace snprintf with strlcpy [21/25] net/mlx5: replace snprintf with strlcpy [22/25] net/nfp: replace snprintf with strlcpy [23/25] net/ngbe: replace snprintf with strlcpy [24/25] net/qede: replace snprintf with strlcpy [25/25] net/txgbe: replace snprintf with strlcpy

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger June 1, 2023, 3:01 p.m. UTC

  Suggested by devtools/cocci/strlcpy-with-header.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/qede/qede_ethdev.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index a4923670d6ba..7429ec3e8773 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -238,8 +238,8 @@  qede_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size)
 	size_t size;
 
 	if (IS_PF(edev))
-		snprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, "%s",
-			 QEDE_PMD_FW_VERSION);
+		strlcpy(ver_str, QEDE_PMD_FW_VERSION,
+			QEDE_PMD_DRV_VER_STR_SIZE);
 	else
 		snprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, "%d.%d.%d.%d",
 			 info->fw_major, info->fw_minor,
@@ -374,11 +374,9 @@  static void qede_print_adapter_info(struct rte_eth_dev *dev)
 		  ECORE_IS_BB(edev) ? "BB" : "AH",
 		  'A' + edev->chip_rev,
 		  (int)edev->chip_metal);
-	snprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, "%s",
-		 QEDE_PMD_DRV_VERSION);
+	strlcpy(ver_str, QEDE_PMD_DRV_VERSION, QEDE_PMD_DRV_VER_STR_SIZE);
 	DP_INFO(edev, " %-20s: %s\n", "Driver version", ver_str);
-	snprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, "%s",
-		 QEDE_PMD_BASE_VERSION);
+	strlcpy(ver_str, QEDE_PMD_BASE_VERSION, QEDE_PMD_DRV_VER_STR_SIZE);
 	DP_INFO(edev, " %-20s: %s\n", "Base version", ver_str);
 	qede_fw_version_get(dev, ver_str, sizeof(ver_str));
 	DP_INFO(edev, " %-20s: %s\n", "Firmware version", ver_str);