diff mbox series

[v1,1/1] bbdev: extend range of allocation function

Message ID 20230602020423.426465-2-nicolas.chautru@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers
Series bbdev: extend range for alloc function |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/github-robot: build fail github build: failed
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Functional success Functional PASS
ci/intel-Testing success Testing PASS

Commit Message

Chautru, Nicolas June 2, 2023, 2:04 a.m. UTC 
  Realigning the argument to unsigned int to
align with number support by underlying
rte_mempool_get_bulk function.

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 lib/bbdev/rte_bbdev_op.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Hemant Agrawal June 2, 2023, 4:23 a.m. UTC | #1 
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Maxime Coquelin June 2, 2023, 7:56 a.m. UTC | #2 
On 6/2/23 04:04, Nicolas Chautru wrote:
> Realigning the argument to unsigned int to
> align with number support by underlying
> rte_mempool_get_bulk function.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>   lib/bbdev/rte_bbdev_op.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
> index 96a390cd9b..9353fd588b 100644
> --- a/lib/bbdev/rte_bbdev_op.h
> +++ b/lib/bbdev/rte_bbdev_op.h
> @@ -982,7 +982,7 @@ rte_bbdev_op_pool_create(const char *name, enum rte_bbdev_op_type type,
>    */
>   static inline int
>   rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_enc_op **ops, unsigned int num_ops)
>   {
>   	struct rte_bbdev_op_pool_private *priv;
>   
> @@ -1013,7 +1013,7 @@ rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
>    */
>   static inline int
>   rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_dec_op **ops, unsigned int num_ops)
>   {
>   	struct rte_bbdev_op_pool_private *priv;

Isn't it breaking the ABI?

> @@ -1045,7 +1045,7 @@ rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
>   __rte_experimental
>   static inline int
>   rte_bbdev_fft_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_fft_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_fft_op **ops, unsigned int num_ops)
>   {
>   	struct rte_bbdev_op_pool_private *priv;
>
Chautru, Nicolas June 2, 2023, 2:17 p.m. UTC | #3 
Hi Maxime, 
I don't think it does since no offset position change for the symbol. Also this only extends the type, so still fine if using uin16_t from application.
I did not receive an email from CICD related to ABI change when pushing this (unlike the other serie for the MLD/FFT changes pushed earlier this week).
Still let me know if you would like this added as well into deprecation notice, but it doesn't look required.
Thanks
Nic

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Friday, June 2, 2023 12:56 AM
> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org
> Cc: hemant.agrawal@nxp.com; Vargas, Hernan <hernan.vargas@intel.com>
> Subject: Re: [PATCH v1 1/1] bbdev: extend range of allocation function
> 
> 
> 
> On 6/2/23 04:04, Nicolas Chautru wrote:
> > Realigning the argument to unsigned int to align with number support
> > by underlying rte_mempool_get_bulk function.
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > ---
> >   lib/bbdev/rte_bbdev_op.h | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h index
> > 96a390cd9b..9353fd588b 100644
> > --- a/lib/bbdev/rte_bbdev_op.h
> > +++ b/lib/bbdev/rte_bbdev_op.h
> > @@ -982,7 +982,7 @@ rte_bbdev_op_pool_create(const char *name,
> enum rte_bbdev_op_type type,
> >    */
> >   static inline int
> >   rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> > -		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> > +		struct rte_bbdev_enc_op **ops, unsigned int num_ops)
> >   {
> >   	struct rte_bbdev_op_pool_private *priv;
> >
> > @@ -1013,7 +1013,7 @@ rte_bbdev_enc_op_alloc_bulk(struct
> rte_mempool *mempool,
> >    */
> >   static inline int
> >   rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> > -		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> > +		struct rte_bbdev_dec_op **ops, unsigned int num_ops)
> >   {
> >   	struct rte_bbdev_op_pool_private *priv;
> 
> Isn't it breaking the ABI?
> 
> > @@ -1045,7 +1045,7 @@ rte_bbdev_dec_op_alloc_bulk(struct
> rte_mempool *mempool,
> >   __rte_experimental
> >   static inline int
> >   rte_bbdev_fft_op_alloc_bulk(struct rte_mempool *mempool,
> > -		struct rte_bbdev_fft_op **ops, uint16_t num_ops)
> > +		struct rte_bbdev_fft_op **ops, unsigned int num_ops)
> >   {
> >   	struct rte_bbdev_op_pool_private *priv;
> >
Maxime Coquelin June 5, 2023, 7:08 p.m. UTC | #4 
On 6/2/23 16:17, Chautru, Nicolas wrote:
> Hi Maxime,
> I don't think it does since no offset position change for the symbol. Also this only extends the type, so still fine if using uin16_t from application.
> I did not receive an email from CICD related to ABI change when pushing this (unlike the other serie for the MLD/FFT changes pushed earlier this week).
> Still let me know if you would like this added as well into deprecation notice, but it doesn't look required.

If ABI checks are OK, then this is good to me.

Thanks,
Maxime

> Thanks
> Nic
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Friday, June 2, 2023 12:56 AM
>> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org
>> Cc: hemant.agrawal@nxp.com; Vargas, Hernan <hernan.vargas@intel.com>
>> Subject: Re: [PATCH v1 1/1] bbdev: extend range of allocation function
>>
>>
>>
>> On 6/2/23 04:04, Nicolas Chautru wrote:
>>> Realigning the argument to unsigned int to align with number support
>>> by underlying rte_mempool_get_bulk function.
>>>
>>> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
>>> ---
>>>    lib/bbdev/rte_bbdev_op.h | 6 +++---
>>>    1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h index
>>> 96a390cd9b..9353fd588b 100644
>>> --- a/lib/bbdev/rte_bbdev_op.h
>>> +++ b/lib/bbdev/rte_bbdev_op.h
>>> @@ -982,7 +982,7 @@ rte_bbdev_op_pool_create(const char *name,
>> enum rte_bbdev_op_type type,
>>>     */
>>>    static inline int
>>>    rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
>>> -		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
>>> +		struct rte_bbdev_enc_op **ops, unsigned int num_ops)
>>>    {
>>>    	struct rte_bbdev_op_pool_private *priv;
>>>
>>> @@ -1013,7 +1013,7 @@ rte_bbdev_enc_op_alloc_bulk(struct
>> rte_mempool *mempool,
>>>     */
>>>    static inline int
>>>    rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
>>> -		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
>>> +		struct rte_bbdev_dec_op **ops, unsigned int num_ops)
>>>    {
>>>    	struct rte_bbdev_op_pool_private *priv;
>>
>> Isn't it breaking the ABI?
>>
>>> @@ -1045,7 +1045,7 @@ rte_bbdev_dec_op_alloc_bulk(struct
>> rte_mempool *mempool,
>>>    __rte_experimental
>>>    static inline int
>>>    rte_bbdev_fft_op_alloc_bulk(struct rte_mempool *mempool,
>>> -		struct rte_bbdev_fft_op **ops, uint16_t num_ops)
>>> +		struct rte_bbdev_fft_op **ops, unsigned int num_ops)
>>>    {
>>>    	struct rte_bbdev_op_pool_private *priv;
>>>
>
Maxime Coquelin July 6, 2023, 9:12 a.m. UTC | #5 
On 6/2/23 04:04, Nicolas Chautru wrote:
> Realigning the argument to unsigned int to
> align with number support by underlying
> rte_mempool_get_bulk function.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>   lib/bbdev/rte_bbdev_op.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
> index 96a390cd9b..9353fd588b 100644
> --- a/lib/bbdev/rte_bbdev_op.h
> +++ b/lib/bbdev/rte_bbdev_op.h
> @@ -982,7 +982,7 @@ rte_bbdev_op_pool_create(const char *name, enum rte_bbdev_op_type type,
>    */
>   static inline int
>   rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_enc_op **ops, unsigned int num_ops)
>   {
>   	struct rte_bbdev_op_pool_private *priv;
>   
> @@ -1013,7 +1013,7 @@ rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
>    */
>   static inline int
>   rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_dec_op **ops, unsigned int num_ops)
>   {
>   	struct rte_bbdev_op_pool_private *priv;
>   
> @@ -1045,7 +1045,7 @@ rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
>   __rte_experimental
>   static inline int
>   rte_bbdev_fft_op_alloc_bulk(struct rte_mempool *mempool,
> -		struct rte_bbdev_fft_op **ops, uint16_t num_ops)
> +		struct rte_bbdev_fft_op **ops, unsigned int num_ops)
>   {
>   	struct rte_bbdev_op_pool_private *priv;
>   


Applied to dpdk-next-baseband/for-main.

Thanks,
Maxime
diff mbox series

Patch

diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h
index 96a390cd9b..9353fd588b 100644
--- a/lib/bbdev/rte_bbdev_op.h
+++ b/lib/bbdev/rte_bbdev_op.h
@@ -982,7 +982,7 @@  rte_bbdev_op_pool_create(const char *name, enum rte_bbdev_op_type type,
  */
 static inline int
 rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
-		struct rte_bbdev_enc_op **ops, uint16_t num_ops)
+		struct rte_bbdev_enc_op **ops, unsigned int num_ops)
 {
 	struct rte_bbdev_op_pool_private *priv;
 
@@ -1013,7 +1013,7 @@  rte_bbdev_enc_op_alloc_bulk(struct rte_mempool *mempool,
  */
 static inline int
 rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
-		struct rte_bbdev_dec_op **ops, uint16_t num_ops)
+		struct rte_bbdev_dec_op **ops, unsigned int num_ops)
 {
 	struct rte_bbdev_op_pool_private *priv;
 
@@ -1045,7 +1045,7 @@  rte_bbdev_dec_op_alloc_bulk(struct rte_mempool *mempool,
 __rte_experimental
 static inline int
 rte_bbdev_fft_op_alloc_bulk(struct rte_mempool *mempool,
-		struct rte_bbdev_fft_op **ops, uint16_t num_ops)
+		struct rte_bbdev_fft_op **ops, unsigned int num_ops)
 {
 	struct rte_bbdev_op_pool_private *priv;