diff mbox series

ci: fix build for Arm cross compilation in GHA

Message ID 20230606105247.2715447-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series ci: fix build for Arm cross compilation in GHA |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS

Commit Message

David Marchand June 6, 2023, 10:52 a.m. UTC 
  We are hitting a storage limit when linking binaries statically.
On the other hand, native builds are tested in other part of the CI and
the chance of breaking static linking only is relatively low, so let's
simply test linking against shared libraries.

Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .github/workflows/build.yml | 1 +
 1 file changed, 1 insertion(+)

Comments

Bruce Richardson June 6, 2023, 11 a.m. UTC | #1 
On Tue, Jun 06, 2023 at 12:52:47PM +0200, David Marchand wrote:
> We are hitting a storage limit when linking binaries statically.
> On the other hand, native builds are tested in other part of the CI and
> the chance of breaking static linking only is relatively low, so let's
> simply test linking against shared libraries.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  .github/workflows/build.yml | 1 +
>  1 file changed, 1 insertion(+)

Yep, with the number of "test" apps now in each build, our build
directories get rather massive!

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Ferruh Yigit June 6, 2023, 1:02 p.m. UTC | #2 
On 6/6/2023 12:00 PM, Bruce Richardson wrote:
> On Tue, Jun 06, 2023 at 12:52:47PM +0200, David Marchand wrote:
>> We are hitting a storage limit when linking binaries statically.
>> On the other hand, native builds are tested in other part of the CI and
>> the chance of breaking static linking only is relatively low, so let's
>> simply test linking against shared libraries.
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> ---
>>  .github/workflows/build.yml | 1 +
>>  1 file changed, 1 insertion(+)
> 
> Yep, with the number of "test" apps now in each build, our build
> directories get rather massive!
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>

Confirmed that this solves the "running out of disk space" issue seen on
'ubuntu-20.04-gcc-aarch64',

Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>
Thomas Monjalon June 6, 2023, 1:09 p.m. UTC | #3 
06/06/2023 15:02, Ferruh Yigit:
> On 6/6/2023 12:00 PM, Bruce Richardson wrote:
> > On Tue, Jun 06, 2023 at 12:52:47PM +0200, David Marchand wrote:
> >> We are hitting a storage limit when linking binaries statically.
> >> On the other hand, native builds are tested in other part of the CI and
> >> the chance of breaking static linking only is relatively low, so let's
> >> simply test linking against shared libraries.
> >>
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: David Marchand <david.marchand@redhat.com>
> >> ---
> >>  .github/workflows/build.yml | 1 +
> >>  1 file changed, 1 insertion(+)
> > 
> > Yep, with the number of "test" apps now in each build, our build
> > directories get rather massive!
> > 
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
> 
> Confirmed that this solves the "running out of disk space" issue seen on
> 'ubuntu-20.04-gcc-aarch64',
> 
> Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 7322eb59b7..3b629fcdbd 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -53,6 +53,7 @@  jobs:
             cross: mingw
           - os: ubuntu-20.04
             compiler: gcc
+            library: shared
             cross: aarch64
           - os: ubuntu-20.04
             compiler: gcc