doc: announce inclusive naming macro name changes

Message ID 20230607024423.336664-1-chaoyong.he@corigine.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series doc: announce inclusive naming macro name changes |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation warning apply patch failure
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

Chaoyong He June 7, 2023, 2:44 a.m. UTC
  From: Long Wu <long.wu@corigine.com>

In order to support inclusive naming, some of the macro in DPDK will
need to be renamed. Do this through deprecation process now for 23.07.

Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
---
Depends-on: patch-127084 ("doc: announce inclusive naming function name")
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)
  

Comments

Stephen Hemminger June 7, 2023, 3:01 p.m. UTC | #1
On Wed,  7 Jun 2023 10:44:23 +0800
Chaoyong He <chaoyong.he@corigine.com> wrote:

> From: Long Wu <long.wu@corigine.com>
> 
> In order to support inclusive naming, some of the macro in DPDK will
> need to be renamed. Do this through deprecation process now for 23.07.
> 
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> ---
> Depends-on: patch-127084 ("doc: announce inclusive naming function name")
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 267a49aa13..67353d4f2b 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -175,3 +175,8 @@ Deprecation Notices
>    ``rte_eth_bond_active_members_get``,
>    ``rte_eth_bond_member_add``, ``rte_eth_bond_member_remove``,
>    and ``rte_eth_bond_members_get``.
> +  References to slave will be removed and replace bonded to bonding in DPDK 23.11.
> +  The following macro will be deprecated in DPDK 23.07, and removed in DPDK 23.11.
> +  The old macro:
> +  ``RTE_ETH_DEV_BONDED_SLAVE`` will be replaced by:
> +  ``RTE_ETH_DEV_BONDING_MEMBER``.

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
  
Chenbo Xia June 8, 2023, 3:04 a.m. UTC | #2
> -----Original Message-----
> From: Chaoyong He <chaoyong.he@corigine.com>
> Sent: Wednesday, June 7, 2023 10:44 AM
> To: dev@dpdk.org
> Cc: oss-drivers@corigine.com; niklas.soderlund@corigine.com; Long Wu
> <long.wu@corigine.com>; Chaoyong He <chaoyong.he@corigine.com>
> Subject: [PATCH] doc: announce inclusive naming macro name changes
> 
> From: Long Wu <long.wu@corigine.com>
> 
> In order to support inclusive naming, some of the macro in DPDK will
> need to be renamed. Do this through deprecation process now for 23.07.
> 
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> ---
> Depends-on: patch-127084 ("doc: announce inclusive naming function name")
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 267a49aa13..67353d4f2b 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -175,3 +175,8 @@ Deprecation Notices
>    ``rte_eth_bond_active_members_get``,
>    ``rte_eth_bond_member_add``, ``rte_eth_bond_member_remove``,
>    and ``rte_eth_bond_members_get``.
> +  References to slave will be removed and replace bonded to bonding in
> DPDK 23.11.
> +  The following macro will be deprecated in DPDK 23.07, and removed in
> DPDK 23.11.
> +  The old macro:
> +  ``RTE_ETH_DEV_BONDED_SLAVE`` will be replaced by:
> +  ``RTE_ETH_DEV_BONDING_MEMBER``.
> --
> 2.27.0

Acked-by: Chenbo Xia <chenbo.xia@intel.com>
  
Chaoyong He July 13, 2023, 3:22 a.m. UTC | #3
> > -----Original Message-----
> > From: Chaoyong He <chaoyong.he@corigine.com>
> > Sent: Wednesday, June 7, 2023 10:44 AM
> > To: dev@dpdk.org
> > Cc: oss-drivers@corigine.com; niklas.soderlund@corigine.com; Long Wu
> > <long.wu@corigine.com>; Chaoyong He <chaoyong.he@corigine.com>
> > Subject: [PATCH] doc: announce inclusive naming macro name changes
> >
> > From: Long Wu <long.wu@corigine.com>
> >
> > In order to support inclusive naming, some of the macro in DPDK will
> > need to be renamed. Do this through deprecation process now for 23.07.
> >
> > Signed-off-by: Long Wu <long.wu@corigine.com>
> > Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> > ---
> > Depends-on: patch-127084 ("doc: announce inclusive naming function
> > name")
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 267a49aa13..67353d4f2b 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -175,3 +175,8 @@ Deprecation Notices
> >    ``rte_eth_bond_active_members_get``,
> >    ``rte_eth_bond_member_add``, ``rte_eth_bond_member_remove``,
> >    and ``rte_eth_bond_members_get``.
> > +  References to slave will be removed and replace bonded to bonding
> > + in
> > DPDK 23.11.
> > +  The following macro will be deprecated in DPDK 23.07, and removed
> > + in
> > DPDK 23.11.
> > +  The old macro:
> > +  ``RTE_ETH_DEV_BONDED_SLAVE`` will be replaced by:
> > +  ``RTE_ETH_DEV_BONDING_MEMBER``.
> > --
> > 2.27.0
> 
> Acked-by: Chenbo Xia <chenbo.xia@intel.com>

A gentle ping ~

Sorry for bother, we try to make a patch series about the bond PMD offload can coming with DPDK-23.11 ...
  
Ferruh Yigit July 13, 2023, 7:58 a.m. UTC | #4
On 6/7/2023 3:44 AM, Chaoyong He wrote:
> From: Long Wu <long.wu@corigine.com>
> 
> In order to support inclusive naming, some of the macro in DPDK will
> need to be renamed. Do this through deprecation process now for 23.07.
> 
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> ---
> Depends-on: patch-127084 ("doc: announce inclusive naming function name")
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 267a49aa13..67353d4f2b 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -175,3 +175,8 @@ Deprecation Notices
>    ``rte_eth_bond_active_members_get``,
>    ``rte_eth_bond_member_add``, ``rte_eth_bond_member_remove``,
>    and ``rte_eth_bond_members_get``.
> +  References to slave will be removed and replace bonded to bonding in DPDK 23.11.
> +  The following macro will be deprecated in DPDK 23.07, and removed in DPDK 23.11.
> +  The old macro:
> +  ``RTE_ETH_DEV_BONDED_SLAVE`` will be replaced by:
> +  ``RTE_ETH_DEV_BONDING_MEMBER``.
>

Hi Chaoyong,

OK to macro rename, but did deprecation in this release happened?
  

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 267a49aa13..67353d4f2b 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -175,3 +175,8 @@  Deprecation Notices
   ``rte_eth_bond_active_members_get``,
   ``rte_eth_bond_member_add``, ``rte_eth_bond_member_remove``,
   and ``rte_eth_bond_members_get``.
+  References to slave will be removed and replace bonded to bonding in DPDK 23.11.
+  The following macro will be deprecated in DPDK 23.07, and removed in DPDK 23.11.
+  The old macro:
+  ``RTE_ETH_DEV_BONDED_SLAVE`` will be replaced by:
+  ``RTE_ETH_DEV_BONDING_MEMBER``.