diff mbox series

net/nfp: fix callback function pointer of disabling promisc

Message ID 20230608030756.814540-1-chaoyong.he@corigine.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/nfp: fix callback function pointer of disabling promisc |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS

Commit Message

Chaoyong He June 8, 2023, 3:07 a.m. UTC 
  From: Qin Ke <qin.ke@corigine.com>

The callback function of promiscuous_disable in nfp_flower_pf_repr_dev_ops
and nfp_flower_repr_dev_ops should be nfp_net_promisc_disable, not
nfp_net_promisc_enable, fix it.

Fixes: 39d82d2 ("net/nfp: fix promiscuous mode for representor port")
Cc: Chaoyong He <chaoyong.he@corigine.com>
Cc: stable@dpdk.org

Signed-off-by: Qin Ke <qin.ke@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
 drivers/net/nfp/flower/nfp_flower_representor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ferruh Yigit June 8, 2023, 2:50 p.m. UTC | #1 
On 6/8/2023 4:07 AM, Chaoyong He wrote:
> From: Qin Ke <qin.ke@corigine.com>
> 
> The callback function of promiscuous_disable in nfp_flower_pf_repr_dev_ops
> and nfp_flower_repr_dev_ops should be nfp_net_promisc_disable, not
> nfp_net_promisc_enable, fix it.
> 
> Fixes: 39d82d2 ("net/nfp: fix promiscuous mode for representor port")
> Cc: Chaoyong He <chaoyong.he@corigine.com>
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qin Ke <qin.ke@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c
index 6b4ba5b9a2..3225a4b84a 100644
--- a/drivers/net/nfp/flower/nfp_flower_representor.c
+++ b/drivers/net/nfp/flower/nfp_flower_representor.c
@@ -518,7 +518,7 @@  static const struct eth_dev_ops nfp_flower_pf_repr_dev_ops = {
 	.stats_reset          = nfp_flower_repr_stats_reset,
 
 	.promiscuous_enable   = nfp_net_promisc_enable,
-	.promiscuous_disable  = nfp_net_promisc_enable,
+	.promiscuous_disable  = nfp_net_promisc_disable,
 
 	.mac_addr_set         = nfp_flower_repr_mac_addr_set,
 	.fw_version_get       = nfp_repr_firmware_version_get,
@@ -540,7 +540,7 @@  static const struct eth_dev_ops nfp_flower_repr_dev_ops = {
 	.stats_reset          = nfp_flower_repr_stats_reset,
 
 	.promiscuous_enable   = nfp_net_promisc_enable,
-	.promiscuous_disable  = nfp_net_promisc_enable,
+	.promiscuous_disable  = nfp_net_promisc_disable,
 
 	.mac_addr_set         = nfp_flower_repr_mac_addr_set,
 	.fw_version_get       = nfp_repr_firmware_version_get,