diff mbox series

[v2] config/arm: fix Neoverse N2 march flag

Message ID 20230608193456.11446-1-pbhagavatula@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] config/arm: fix Neoverse N2 march flag |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-abi-testing success Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Pavan Nikhilesh Bhagavatula June 8, 2023, 7:34 p.m. UTC 
  From: Pavan Nikhilesh <pbhagavatula@marvell.com>

The -march flag of Neoverse N2 should be removed with the introduction
of -mcpu='neoverse-n2' as they are incompatible.

Fixes: ea85ed1f6882 ("config/arm: increase nodes and cores for Neoverse N2")

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Tested-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
 v2 Changes:
 - Remove adding armv9-a to march as it is incompatible with older GCC.

 config/arm/meson.build | 1 -
 1 file changed, 1 deletion(-)

--
2.39.1

Comments

Ruifeng Wang June 9, 2023, 4:02 a.m. UTC | #1 
> -----Original Message-----
> From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> Sent: Friday, June 9, 2023 3:35 AM
> To: jerinj@marvell.com; Ruifeng Wang <Ruifeng.Wang@arm.com>; Bruce Richardson
> <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>; Srikanth Yalavarthi
> <syalavarthi@marvell.com>
> Subject: [PATCH v2] config/arm: fix Neoverse N2 march flag
> 
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> The -march flag of Neoverse N2 should be removed with the introduction of -mcpu='neoverse-
> n2' as they are incompatible.
> 
> Fixes: ea85ed1f6882 ("config/arm: increase nodes and cores for Neoverse N2")
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Tested-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---
>  v2 Changes:
>  - Remove adding armv9-a to march as it is incompatible with older GCC.
> 
>  config/arm/meson.build | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index 43f6a551a2..ae2226988e
> 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -89,7 +89,6 @@ part_number_config_arm = {
>          'march': 'armv8.4-a',
>      },
>      '0xd49': {
> -        'march': 'armv8.5-a',
>          'march_features': ['sve2'],
>          'compiler_options': ['-mcpu=neoverse-n2'],
>          'flags': [
> --
> 2.39.1

Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
Thomas Monjalon June 12, 2023, 5:06 p.m. UTC | #2 
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > 
> > The -march flag of Neoverse N2 should be removed with the introduction of -mcpu='neoverse-
> > n2' as they are incompatible.
> > 
> > Fixes: ea85ed1f6882 ("config/arm: increase nodes and cores for Neoverse N2")
> > 
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > Tested-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> 
> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 43f6a551a2..ae2226988e 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -89,7 +89,6 @@  part_number_config_arm = {
         'march': 'armv8.4-a',
     },
     '0xd49': {
-        'march': 'armv8.5-a',
         'march_features': ['sve2'],
         'compiler_options': ['-mcpu=neoverse-n2'],
         'flags': [