ixgbe: Allow setting IVAR register for X550EM_a
Checks
Commit Message
Fix interrupt mode initialization for X550EM_a revision
Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
1 file changed, 1 insertion(+)
Comments
Ruifeng, there seems to be a unit testing failure on ARM that is preventing the patch from being merged. Could you help on this?
https://patchwork.dpdk.org/project/dpdk/patch/20230614132626.2214-1-vratnikov@netgate.com/
> -----Original Message-----
> From: Vladimir Ratnikov <vratnikov@netgate.com>
> Sent: Wednesday, June 14, 2023 9:26 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Wu, Wenjun1
> <wenjun1.wu@intel.com>
> Cc: dev@dpdk.org; Vladimir Ratnikov <vratnikov@netgate.com>
> Subject: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a
>
> Fix interrupt mode initialization for X550EM_a revision
>
> Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 43aea2e16f..d44ef37a7a 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -5952,6 +5952,7 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t
> direction,
> } else if ((hw->mac.type == ixgbe_mac_82599EB) ||
> (hw->mac.type == ixgbe_mac_X540) ||
> (hw->mac.type == ixgbe_mac_X550) ||
> + (hw->mac.type == ixgbe_mac_X550EM_a) ||
> (hw->mac.type == ixgbe_mac_X550EM_x)) {
> if (direction == -1) {
> /* other causes */
> --
> 2.34.1
Hi All,
It seems a false positive. I have tested the patch with aarch32 link_bond_autotest on arm server, and the test cases all succeed.
Best Regards,
Joyce
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Monday, June 19, 2023 9:09 AM
> To: Vladimir Ratnikov <vratnikov@netgate.com>; Yang, Qiming
> <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>
> Cc: dev@dpdk.org; Ruifeng Wang <Ruifeng.Wang@arm.com>
> Subject: RE: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a
>
> Ruifeng, there seems to be a unit testing failure on ARM that is preventing the
> patch from being merged. Could you help on this?
> https://patchwork.dpdk.org/project/dpdk/patch/20230614132626.2214-1-
> vratnikov@netgate.com/
>
> > -----Original Message-----
> > From: Vladimir Ratnikov <vratnikov@netgate.com>
> > Sent: Wednesday, June 14, 2023 9:26 PM
> > To: Yang, Qiming <qiming.yang@intel.com>; Wu, Wenjun1
> > <wenjun1.wu@intel.com>
> > Cc: dev@dpdk.org; Vladimir Ratnikov <vratnikov@netgate.com>
> > Subject: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a
> >
> > Fix interrupt mode initialization for X550EM_a revision
> >
> > Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index 43aea2e16f..d44ef37a7a 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -5952,6 +5952,7 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t
> > direction,
> > } else if ((hw->mac.type == ixgbe_mac_82599EB) ||
> > (hw->mac.type == ixgbe_mac_X540) ||
> > (hw->mac.type == ixgbe_mac_X550) ||
> > + (hw->mac.type == ixgbe_mac_X550EM_a) ||
> > (hw->mac.type == ixgbe_mac_X550EM_x)) {
> > if (direction == -1) {
> > /* other causes */
> > --
> > 2.34.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
> -----Original Message-----
> From: Joyce Kong <Joyce.Kong@arm.com>
> Sent: Monday, June 19, 2023 5:45 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Vladimir Ratnikov
> <vratnikov@netgate.com>; Yang, Qiming <qiming.yang@intel.com>; Wu,
> Wenjun1 <wenjun1.wu@intel.com>
> Cc: dev@dpdk.org; Ruifeng Wang <Ruifeng.Wang@arm.com>
> Subject: RE: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a
>
> Hi All,
>
> It seems a false positive. I have tested the patch with aarch32
> link_bond_autotest on arm server, and the test cases all succeed.
>
> Best Regards,
> Joyce
Thanks for the confirm.
>
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Monday, June 19, 2023 9:09 AM
> > To: Vladimir Ratnikov <vratnikov@netgate.com>; Yang, Qiming
> > <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>
> > Cc: dev@dpdk.org; Ruifeng Wang <Ruifeng.Wang@arm.com>
> > Subject: RE: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a
> >
> > Ruifeng, there seems to be a unit testing failure on ARM that is
> > preventing the patch from being merged. Could you help on this?
> > https://patchwork.dpdk.org/project/dpdk/patch/20230614132626.2214-1-
> > vratnikov@netgate.com/
> >
> > > -----Original Message-----
> > > From: Vladimir Ratnikov <vratnikov@netgate.com>
> > > Sent: Wednesday, June 14, 2023 9:26 PM
> > > To: Yang, Qiming <qiming.yang@intel.com>; Wu, Wenjun1
> > > <wenjun1.wu@intel.com>
> > > Cc: dev@dpdk.org; Vladimir Ratnikov <vratnikov@netgate.com>
> > > Subject: [PATCH] ixgbe: Allow setting IVAR register for X550EM_a
> > >
> > > Fix interrupt mode initialization for X550EM_a revision
> > >
> > > Signed-off-by: Vladimir Ratnikov <vratnikov@netgate.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -5952,6 +5952,7 @@ ixgbe_set_ivar_map(struct ixgbe_hw *hw, int8_t direction,
} else if ((hw->mac.type == ixgbe_mac_82599EB) ||
(hw->mac.type == ixgbe_mac_X540) ||
(hw->mac.type == ixgbe_mac_X550) ||
+ (hw->mac.type == ixgbe_mac_X550EM_a) ||
(hw->mac.type == ixgbe_mac_X550EM_x)) {
if (direction == -1) {
/* other causes */