mbox

[v2,0/5] bbdev: API extension for 23.11

Message ID 20230615164901.40845-1-nicolas.chautru@intel.com (mailing list archive)
Headers

Message

Chautru, Nicolas June 15, 2023, 4:48 p.m. UTC 
  v2: moving the new mld functions at the end of struct rte_bbdev to avoid
ABI offset changes based on feedback with Maxime.
Adding a commit to waive the FFT ABI warning since that experimental function
could break ABI (let me know if preferred to be merged with the FFT
commit causing the FFT change). 


Including v1 for extending the bbdev api for 23.11.
The new MLD-TS is expected to be non ABI compatible, the other ones
should not break ABI. 
I will send a deprecation notice in parallel.

This introduces a new operation (on top of FEC and FFT) to support
equalization for MLD-TS. There also more modular API extension for
existing FFT and FEC operation. 

Thanks
Nic


Nicolas Chautru (5):
  bbdev: add operation type for MLDTS procession
  bbdev: add new capabilities for FFT processing
  bbdev: add new capability for FEC 5G UL processing
  bbdev: improving error handling for queue configuration
  devtools: ignore changes into bbdev experimental API

 devtools/libabigail.abignore    |   4 +-
 doc/guides/prog_guide/bbdev.rst |  83 ++++++++++++++++++
 lib/bbdev/rte_bbdev.c           |  26 +++---
 lib/bbdev/rte_bbdev.h           |  76 +++++++++++++++++
 lib/bbdev/rte_bbdev_op.h        | 143 +++++++++++++++++++++++++++++++-
 lib/bbdev/version.map           |   5 ++
 6 files changed, 323 insertions(+), 14 deletions(-)

Comments

Hernan Vargas Aug. 4, 2023, 4:14 p.m. UTC | #1 
Hi Maxime,

Kind reminder to get a review on this series:
https://patchwork.dpdk.org/project/dpdk/list/?series=28544

Thanks,
Hernan

> -----Original Message-----
> From: Chautru, Nicolas <nicolas.chautru@intel.com>
> Sent: Monday, July 17, 2023 5:29 PM
> To: dev@dpdk.org; maxime.coquelin@redhat.com
> Cc: Rix, Tom <trix@redhat.com>; hemant.agrawal@nxp.com;
> david.marchand@redhat.com; Vargas, Hernan <hernan.vargas@intel.com>
> Subject: RE: [PATCH v2 0/5] bbdev: API extension for 23.11
> 
> Hi Maxime, Hemant,
> Can I get some review/ack for this serie please.
> Thanks
> Nic
> 
> > -----Original Message-----
> > From: Chautru, Nicolas <nicolas.chautru@intel.com>
> > Sent: Thursday, June 15, 2023 9:49 AM
> > To: dev@dpdk.org; maxime.coquelin@redhat.com
> > Cc: Rix, Tom <trix@redhat.com>; hemant.agrawal@nxp.com;
> > david.marchand@redhat.com; Vargas, Hernan <hernan.vargas@intel.com>;
> > Chautru, Nicolas <nicolas.chautru@intel.com>
> > Subject: [PATCH v2 0/5] bbdev: API extension for 23.11
> >
> > v2: moving the new mld functions at the end of struct rte_bbdev to
> > avoid ABI offset changes based on feedback with Maxime.
> > Adding a commit to waive the FFT ABI warning since that experimental
> > function could break ABI (let me know if preferred to be merged with
> > the FFT commit causing the FFT change).
> >
> >
> > Including v1 for extending the bbdev api for 23.11.
> > The new MLD-TS is expected to be non ABI compatible, the other ones
> > should not break ABI.
> > I will send a deprecation notice in parallel.
> >
> > This introduces a new operation (on top of FEC and FFT) to support
> > equalization for MLD-TS. There also more modular API extension for
> > existing FFT and FEC operation.
> >
> > Thanks
> > Nic
> >
> >
> > Nicolas Chautru (5):
> >   bbdev: add operation type for MLDTS procession
> >   bbdev: add new capabilities for FFT processing
> >   bbdev: add new capability for FEC 5G UL processing
> >   bbdev: improving error handling for queue configuration
> >   devtools: ignore changes into bbdev experimental API
> >
> >  devtools/libabigail.abignore    |   4 +-
> >  doc/guides/prog_guide/bbdev.rst |  83 ++++++++++++++++++
> >  lib/bbdev/rte_bbdev.c           |  26 +++---
> >  lib/bbdev/rte_bbdev.h           |  76 +++++++++++++++++
> >  lib/bbdev/rte_bbdev_op.h        | 143
> > +++++++++++++++++++++++++++++++-
> >  lib/bbdev/version.map           |   5 ++
> >  6 files changed, 323 insertions(+), 14 deletions(-)
> >
> > --
> > 2.34.1
Chautru, Nicolas Sept. 5, 2023, 5:48 p.m. UTC | #2 
Hi Maxime, Hemant, 

Can we please get some extra review/ack for this bbdev serie. I would be good to apply on the baseband repo soon towards 23.11. 
Much appreciated!
Nic

> -----Original Message-----
> From: Vargas, Hernan <hernan.vargas@intel.com>
> Sent: Friday, August 4, 2023 9:14 AM
> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org;
> maxime.coquelin@redhat.com
> Cc: Rix, Tom <trix@redhat.com>; hemant.agrawal@nxp.com;
> david.marchand@redhat.com
> Subject: RE: [PATCH v2 0/5] bbdev: API extension for 23.11
> 
> Hi Maxime,
> 
> Kind reminder to get a review on this series:
> https://patchwork.dpdk.org/project/dpdk/list/?series=28544
> 
> Thanks,
> Hernan
> 
> > -----Original Message-----
> > From: Chautru, Nicolas <nicolas.chautru@intel.com>
> > Sent: Monday, July 17, 2023 5:29 PM
> > To: dev@dpdk.org; maxime.coquelin@redhat.com
> > Cc: Rix, Tom <trix@redhat.com>; hemant.agrawal@nxp.com;
> > david.marchand@redhat.com; Vargas, Hernan
> <hernan.vargas@intel.com>
> > Subject: RE: [PATCH v2 0/5] bbdev: API extension for 23.11
> >
> > Hi Maxime, Hemant,
> > Can I get some review/ack for this serie please.
> > Thanks
> > Nic
> >
> > > -----Original Message-----
> > > From: Chautru, Nicolas <nicolas.chautru@intel.com>
> > > Sent: Thursday, June 15, 2023 9:49 AM
> > > To: dev@dpdk.org; maxime.coquelin@redhat.com
> > > Cc: Rix, Tom <trix@redhat.com>; hemant.agrawal@nxp.com;
> > > david.marchand@redhat.com; Vargas, Hernan
> <hernan.vargas@intel.com>;
> > > Chautru, Nicolas <nicolas.chautru@intel.com>
> > > Subject: [PATCH v2 0/5] bbdev: API extension for 23.11
> > >
> > > v2: moving the new mld functions at the end of struct rte_bbdev to
> > > avoid ABI offset changes based on feedback with Maxime.
> > > Adding a commit to waive the FFT ABI warning since that experimental
> > > function could break ABI (let me know if preferred to be merged with
> > > the FFT commit causing the FFT change).
> > >
> > >
> > > Including v1 for extending the bbdev api for 23.11.
> > > The new MLD-TS is expected to be non ABI compatible, the other ones
> > > should not break ABI.
> > > I will send a deprecation notice in parallel.
> > >
> > > This introduces a new operation (on top of FEC and FFT) to support
> > > equalization for MLD-TS. There also more modular API extension for
> > > existing FFT and FEC operation.
> > >
> > > Thanks
> > > Nic
> > >
> > >
> > > Nicolas Chautru (5):
> > >   bbdev: add operation type for MLDTS procession
> > >   bbdev: add new capabilities for FFT processing
> > >   bbdev: add new capability for FEC 5G UL processing
> > >   bbdev: improving error handling for queue configuration
> > >   devtools: ignore changes into bbdev experimental API
> > >
> > >  devtools/libabigail.abignore    |   4 +-
> > >  doc/guides/prog_guide/bbdev.rst |  83 ++++++++++++++++++
> > >  lib/bbdev/rte_bbdev.c           |  26 +++---
> > >  lib/bbdev/rte_bbdev.h           |  76 +++++++++++++++++
> > >  lib/bbdev/rte_bbdev_op.h        | 143
> > > +++++++++++++++++++++++++++++++-
> > >  lib/bbdev/version.map           |   5 ++
> > >  6 files changed, 323 insertions(+), 14 deletions(-)
> > >
> > > --
> > > 2.34.1
Hemant Agrawal Sept. 6, 2023, 6:20 a.m. UTC | #3 
Hi Nic,

     One small comment in the commit message.

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Regards

Hemant

On 15-Jun-23 10:18 PM, Nicolas Chautru wrote:
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
>
>
> v2: moving the new mld functions at the end of struct rte_bbdev to avoid
> ABI offset changes based on feedback with Maxime.
> Adding a commit to waive the FFT ABI warning since that experimental function
> could break ABI (let me know if preferred to be merged with the FFT
> commit causing the FFT change).
>
>
> Including v1 for extending the bbdev api for 23.11.
> The new MLD-TS is expected to be non ABI compatible, the other ones
> should not break ABI.
> I will send a deprecation notice in parallel.
>
> This introduces a new operation (on top of FEC and FFT) to support
> equalization for MLD-TS. There also more modular API extension for
> existing FFT and FEC operation.
>
> Thanks
> Nic
>
>
> Nicolas Chautru (5):
>    bbdev: add operation type for MLDTS procession
>    bbdev: add new capabilities for FFT processing
>    bbdev: add new capability for FEC 5G UL processing
>    bbdev: improving error handling for queue configuration
>    devtools: ignore changes into bbdev experimental API
>
>   devtools/libabigail.abignore    |   4 +-
>   doc/guides/prog_guide/bbdev.rst |  83 ++++++++++++++++++
>   lib/bbdev/rte_bbdev.c           |  26 +++---
>   lib/bbdev/rte_bbdev.h           |  76 +++++++++++++++++
>   lib/bbdev/rte_bbdev_op.h        | 143 +++++++++++++++++++++++++++++++-
>   lib/bbdev/version.map           |   5 ++
>   6 files changed, 323 insertions(+), 14 deletions(-)
>
> --
> 2.34.1
>
Maxime Coquelin Sept. 21, 2023, 7:35 a.m. UTC | #4 
On 6/15/23 18:48, Nicolas Chautru wrote:
> v2: moving the new mld functions at the end of struct rte_bbdev to avoid
> ABI offset changes based on feedback with Maxime.
> Adding a commit to waive the FFT ABI warning since that experimental function
> could break ABI (let me know if preferred to be merged with the FFT
> commit causing the FFT change).
> 
> 
> Including v1 for extending the bbdev api for 23.11.
> The new MLD-TS is expected to be non ABI compatible, the other ones
> should not break ABI.
> I will send a deprecation notice in parallel.
> 
> This introduces a new operation (on top of FEC and FFT) to support
> equalization for MLD-TS. There also more modular API extension for
> existing FFT and FEC operation.
> 
> Thanks
> Nic
> 
> 
> Nicolas Chautru (5):
>    bbdev: add operation type for MLDTS procession
>    bbdev: add new capabilities for FFT processing
>    bbdev: add new capability for FEC 5G UL processing
>    bbdev: improving error handling for queue configuration
>    devtools: ignore changes into bbdev experimental API
> 
>   devtools/libabigail.abignore    |   4 +-
>   doc/guides/prog_guide/bbdev.rst |  83 ++++++++++++++++++
>   lib/bbdev/rte_bbdev.c           |  26 +++---
>   lib/bbdev/rte_bbdev.h           |  76 +++++++++++++++++
>   lib/bbdev/rte_bbdev_op.h        | 143 +++++++++++++++++++++++++++++++-
>   lib/bbdev/version.map           |   5 ++
>   6 files changed, 323 insertions(+), 14 deletions(-)
> 

Applied to next-baseband/for-main.

Thanks,
Maxime