From patchwork Tue Jun 20 05:27:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tejasree Kondoj X-Patchwork-Id: 128814 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88BD242D02; Tue, 20 Jun 2023 07:27:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82E4542BD9; Tue, 20 Jun 2023 07:27:44 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 489394113F for ; Tue, 20 Jun 2023 07:27:43 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35K4hFYU026986 for ; Mon, 19 Jun 2023 22:27:42 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=aG+WGALFaxK/aJlcpwpHhoRCGwk7lCUoKOHO+vUh2mc=; b=XQSjJUVGv2cn6qfzWLaBQudzwvjM3YnHUYU6wG4KusiygeNuvGRzwnimVownPcoDu45D 0aWjng2ZDnDQv3cYG4QfLaYVSIW6QzkN6FbENk9qbYtXgQh2tmpyRajk7BDhS97cA+LM 7vG0K8CmN5wc/Ogrl6tIYpYRAAayppHdk/xkP9f5GmHGB8FtcCcUvhcAbqRR5SfwJIz+ 4SLSXjkm7L4jd51/VSGs5zFXRiNXt+/BrIm53BdwyNYAGUE5QdenGXfL7TRG9P2SziRK /TzoBugLjLM6NbJJESP9p9bCbNofe4pFC7fwhZBNTQpEh66jAZAsSr+t3HslUZw3Tdxg zA== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3rb5b303fv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Mon, 19 Jun 2023 22:27:42 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Mon, 19 Jun 2023 22:27:40 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Mon, 19 Jun 2023 22:27:40 -0700 Received: from hyd1554.marvell.com (unknown [10.29.57.11]) by maili.marvell.com (Postfix) with ESMTP id AA7733F706F; Mon, 19 Jun 2023 22:27:38 -0700 (PDT) From: Tejasree Kondoj To: Akhil Goyal CC: Anoob Joseph , Aakash Sasidharan , Gowrishankar Muthukrishnan , Vidya Sagar Velumuri , Subject: [PATCH v2 1/8] crypto/cnxk: check for null pointer Date: Tue, 20 Jun 2023 10:57:28 +0530 Message-ID: <20230620052735.3969606-2-ktejasree@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230620052735.3969606-1-ktejasree@marvell.com> References: <20230620052735.3969606-1-ktejasree@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: u1R4FaH4pc59DNARZwDEi0bHbrmChvg5 X-Proofpoint-ORIG-GUID: u1R4FaH4pc59DNARZwDEi0bHbrmChvg5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-20_02,2023-06-16_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Checking for NULL pointer dereference. Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cnxk_se.h | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index c66ab80749..a85e4c5170 100644 --- a/drivers/crypto/cnxk/cnxk_se.h +++ b/drivers/crypto/cnxk/cnxk_se.h @@ -2185,12 +2185,14 @@ fill_sess_auth(struct rte_crypto_sym_xform *xform, struct cnxk_se_sess *sess) if (zsk_flag && sess->roc_se_ctx.auth_then_ciph) { struct rte_crypto_cipher_xform *c_form; - c_form = &xform->next->cipher; - if (c_form->op != RTE_CRYPTO_CIPHER_OP_ENCRYPT && - a_form->op != RTE_CRYPTO_AUTH_OP_GENERATE) { - plt_dp_err("Crypto: PDCP auth then cipher must use" - " options: encrypt and generate"); - return -EINVAL; + if (xform->next != NULL) { + c_form = &xform->next->cipher; + if ((c_form != NULL) && (c_form->op != RTE_CRYPTO_CIPHER_OP_ENCRYPT) && + a_form->op != RTE_CRYPTO_AUTH_OP_GENERATE) { + plt_dp_err("Crypto: PDCP auth then cipher must use" + " options: encrypt and generate"); + return -EINVAL; + } } }