diff mbox series

[v2] app/testpmd: add dump command help message

Message ID 20230628095429.21090-1-viacheslavo@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v2] app/testpmd: add dump command help message |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS

Commit Message

Slava Ovsiienko June 28, 2023, 9:54 a.m. UTC 
  There was missing "dump_xxxxx" commands help message.
Patch updates "help display" section of the help message.

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 app/test-pmd/cmdline.c | 68 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 68 insertions(+)

Comments

Ferruh Yigit June 28, 2023, 1:18 p.m. UTC | #1 
On 6/28/2023 10:54 AM, Viacheslav Ovsiienko wrote:
> There was missing "dump_xxxxx" commands help message.
> Patch updates "help display" section of the help message.
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
>

Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>

Applied to dpdk-next-net/main, thanks.

<...>

> @@ -982,6 +1012,44 @@ static void cmd_help_long_parsed(void *parsed_result,
>  		);
>  	}
>  
> +	if (show_all || !strcmp(res->section, "dump")) {
> +		cmdline_printf(
> +			cl,
> +			"\n"
> +			"Dump Commands:\n"
> +			"--------------\n"
> +			"dump_physmem\n"
> +			"    Dumps all physical memory segment layouts\n\n"
> +
> +			"dump_socket_mem\n"
> +			"    Dumps the memory usage of all sockets\n\n"
> +
> +			"dump_memzone\n"
> +			"    Dumps the layout of all memory zones\n\n"
> +
> +			"dump_struct_sizes\n"
> +			"    Dumps the size of all memory structures\n\n"
> +
> +			"dump_ring\n"
> +			"    Dumps the status of all or specific element in DPDK rings\n\n"
> +
> +			"dump_mempool\n"
> +			"    Dumps the statistics of all or specific memory pool\n\n"
> +
> +			"dump_devargs\n"
> +			"    Dumps the user device list\n\n"
> +
> +			"dump_lcores\n"
> +			"    Dumps the logical cores list\n\n"
> +
> +			"dump_trace\n"
> +			"    Dumps the tracing data to the folder according to the current EAL settings\n\n"
> +
> +			"dump_log_types\n"
> +			"    Dumps the log level for all the dpdk modules\n\n"
> +		);
> +	}
> +

Above part is duplicate, and removed while merging.
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 18e6e19497..9853fd3069 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -255,6 +255,36 @@  static void cmd_help_long_parsed(void *parsed_result,
 
 			"show port (port_id) flow_ctrl"
 			"	Show flow control info of a port.\n\n"
+
+			"dump_physmem\n"
+			"    Dumps all physical memory segment layouts\n\n"
+
+			"dump_socket_mem\n"
+			"    Dumps the memory usage of all sockets\n\n"
+
+			"dump_memzone\n"
+			"    Dumps the layout of all memory zones\n\n"
+
+			"dump_struct_sizes\n"
+			"    Dumps the size of all memory structures\n\n"
+
+			"dump_ring\n"
+			"    Dumps the status of all or specific element in DPDK rings\n\n"
+
+			"dump_mempool\n"
+			"    Dumps the statistics of all or specific memory pool\n\n"
+
+			"dump_devargs\n"
+			"    Dumps the user device list\n\n"
+
+			"dump_lcores\n"
+			"    Dumps the logical cores list\n\n"
+
+			"dump_trace\n"
+			"    Dumps the tracing data to the folder according to the current EAL settings\n\n"
+
+			"dump_log_types\n"
+			"    Dumps the log level for all the dpdk modules\n\n"
 		);
 	}
 
@@ -982,6 +1012,44 @@  static void cmd_help_long_parsed(void *parsed_result,
 		);
 	}
 
+	if (show_all || !strcmp(res->section, "dump")) {
+		cmdline_printf(
+			cl,
+			"\n"
+			"Dump Commands:\n"
+			"--------------\n"
+			"dump_physmem\n"
+			"    Dumps all physical memory segment layouts\n\n"
+
+			"dump_socket_mem\n"
+			"    Dumps the memory usage of all sockets\n\n"
+
+			"dump_memzone\n"
+			"    Dumps the layout of all memory zones\n\n"
+
+			"dump_struct_sizes\n"
+			"    Dumps the size of all memory structures\n\n"
+
+			"dump_ring\n"
+			"    Dumps the status of all or specific element in DPDK rings\n\n"
+
+			"dump_mempool\n"
+			"    Dumps the statistics of all or specific memory pool\n\n"
+
+			"dump_devargs\n"
+			"    Dumps the user device list\n\n"
+
+			"dump_lcores\n"
+			"    Dumps the logical cores list\n\n"
+
+			"dump_trace\n"
+			"    Dumps the tracing data to the folder according to the current EAL settings\n\n"
+
+			"dump_log_types\n"
+			"    Dumps the log level for all the dpdk modules\n\n"
+		);
+	}
+
 	if (show_all || !strcmp(res->section, "devices")) {
 		cmdline_printf(
 			cl,