From patchwork Thu Jun 29 13:58:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 129116 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0491942D8C; Thu, 29 Jun 2023 15:58:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D33F6410D0; Thu, 29 Jun 2023 15:58:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 69CC540EDB for ; Thu, 29 Jun 2023 15:58:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688047128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=USimWZK+lL84BYcyi7pQVdKPWWmU2dM9YMapeZm6xBw=; b=GBQpwngUxdpD5UfdfBlSPuJ8Ma19mPvS6/K1p4JCpfYV0PpCUPjO8WSEVYz3UV0ytwC4mn XGZSgGqSUxpcdiJThuW5ywlkmeV2HUmVkOt6uQP9+ncyarOhc0sOXfllhzocc3HUDJ5KJt zIy+SvBd8mPHRm1IqFDqetSNktYe6bI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-518-1PXLS8LvOzePhIiLrN-Dug-1; Thu, 29 Jun 2023 09:58:45 -0400 X-MC-Unique: 1PXLS8LvOzePhIiLrN-Dug-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4890B3814958; Thu, 29 Jun 2023 13:58:45 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id A5CE640C2063; Thu, 29 Jun 2023 13:58:43 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Ori Kam , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Kiran Kumar K Subject: [PATCH] ethdev: fix Tx queue mask endianness Date: Thu, 29 Jun 2023 15:58:39 +0200 Message-Id: <20230629135839.974700-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Even if harmless, this endianness tag is incorrect as the tx_queue field is declared as a host integer. Additionally, this breaks OVS compilation with sparse. Fixes: 41f6bdc7615a ("ethdev: add Tx queue flow matching item") Signed-off-by: David Marchand Acked-by: Ferruh Yigit --- lib/ethdev/rte_flow.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 3fe57140f9..86ed98c562 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -2307,7 +2307,7 @@ struct rte_flow_item_tx_queue { /** Default mask for RTE_FLOW_ITEM_TX_QUEUE. */ #ifndef __cplusplus static const struct rte_flow_item_tx_queue rte_flow_item_tx_queue_mask = { - .tx_queue = RTE_BE16(0xffff), + .tx_queue = 0xffff, }; #endif