diff mbox series

doc: deprecation notice to add callback data to rte_event_fp_ops

Message ID 20230712173050.599482-1-sivaprasad.tummala@amd.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series doc: deprecation notice to add callback data to rte_event_fp_ops |

Checks

Context Check Description
ci/loongarch-compilation warning apply patch failure
ci/checkpatch success coding style OK
ci/iol-testing warning apply patch failure
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

Sivaprasad Tummala July 12, 2023, 5:30 p.m. UTC 
  Deprecation notice to add "rte_eventdev_port_data" field to
``rte_event_fp_ops`` for callback support.

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jerin Jacob July 13, 2023, 8:51 a.m. UTC | #1 
On Wed, Jul 12, 2023 at 11:01 PM Sivaprasad Tummala
<sivaprasad.tummala@amd.com> wrote:
>
> Deprecation notice to add "rte_eventdev_port_data" field to

Could you share the rational for why rte_eventdev_port_data needs to be added?


> ``rte_event_fp_ops`` for callback support.
>
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 8e1cdd677a..2c69338818 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -133,6 +133,10 @@ Deprecation Notices
>    ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
>    ``rte_cryptodev_asym_get_xform_string`` respectively.
>
> +* eventdev: The struct rte_event_fp_ops will be updated with a new element
> +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11. This changes
> +  the size of rte_event_fp_ops and result in ABI change.
> +
>  * flow_classify: The flow_classify library and example have no maintainer.
>    The library is experimental and, as such, it could be removed from DPDK.
>    Its removal has been postponed to let potential users report interest
> --
> 2.34.1
>
Sivaprasad Tummala July 13, 2023, 10:38 a.m. UTC | #2 
[AMD Official Use Only - General]

Hi Jerin,

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Thursday, July 13, 2023 2:22 PM
> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <Ferruh.Yigit@amd.com>;
> bruce.richardson@intel.com; david.marchand@redhat.com; thomas@monjalon.net
> Subject: Re: [PATCH] doc: deprecation notice to add callback data to
> rte_event_fp_ops
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Wed, Jul 12, 2023 at 11:01 PM Sivaprasad Tummala
> <sivaprasad.tummala@amd.com> wrote:
> >
> > Deprecation notice to add "rte_eventdev_port_data" field to
>
> Could you share the rational for why rte_eventdev_port_data needs to be added?

"rte_eventdev_port_data" is used to hold callbacks registered optionally per event device port and associated callback data.
By adding "rte_eventdev_port_data" to "rte_event_fp_ops", allows to fetch this data for fastpath eventdev inline functions in advance.

>
>
> > ``rte_event_fp_ops`` for callback support.
> >
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 8e1cdd677a..2c69338818 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -133,6 +133,10 @@ Deprecation Notices
> >    ``rte_cryptodev_get_auth_algo_string``,
> ``rte_cryptodev_get_aead_algo_string`` and
> >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> >
> > +* eventdev: The struct rte_event_fp_ops will be updated with a new
> > +element
> > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > +This changes
> > +  the size of rte_event_fp_ops and result in ABI change.
> > +
> >  * flow_classify: The flow_classify library and example have no maintainer.
> >    The library is experimental and, as such, it could be removed from DPDK.
> >    Its removal has been postponed to let potential users report
> > interest
> > --
> > 2.34.1
> >
Jerin Jacob July 13, 2023, 10:40 a.m. UTC | #3 
On Thu, Jul 13, 2023 at 4:08 PM Tummala, Sivaprasad
<Sivaprasad.Tummala@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Hi Jerin,
>
> > -----Original Message-----
> > From: Jerin Jacob <jerinjacobk@gmail.com>
> > Sent: Thursday, July 13, 2023 2:22 PM
> > To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> > Cc: dev@dpdk.org; Yigit, Ferruh <Ferruh.Yigit@amd.com>;
> > bruce.richardson@intel.com; david.marchand@redhat.com; thomas@monjalon.net
> > Subject: Re: [PATCH] doc: deprecation notice to add callback data to
> > rte_event_fp_ops
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > On Wed, Jul 12, 2023 at 11:01 PM Sivaprasad Tummala
> > <sivaprasad.tummala@amd.com> wrote:
> > >
> > > Deprecation notice to add "rte_eventdev_port_data" field to
> >
> > Could you share the rational for why rte_eventdev_port_data needs to be added?
>
> "rte_eventdev_port_data" is used to hold callbacks registered optionally per event device port and associated callback data.
> By adding "rte_eventdev_port_data" to "rte_event_fp_ops", allows to fetch this data for fastpath eventdev inline functions in advance.

Please add above info in the release notes for next version.

>
> >
> >
> > > ``rte_event_fp_ops`` for callback support.
> > >
> > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > > ---
> > >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst
> > > b/doc/guides/rel_notes/deprecation.rst
> > > index 8e1cdd677a..2c69338818 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -133,6 +133,10 @@ Deprecation Notices
> > >    ``rte_cryptodev_get_auth_algo_string``,
> > ``rte_cryptodev_get_aead_algo_string`` and
> > >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> > >
> > > +* eventdev: The struct rte_event_fp_ops will be updated with a new
> > > +element
> > > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > > +This changes
> > > +  the size of rte_event_fp_ops and result in ABI change.
> > > +
> > >  * flow_classify: The flow_classify library and example have no maintainer.
> > >    The library is experimental and, as such, it could be removed from DPDK.
> > >    Its removal has been postponed to let potential users report
> > > interest
> > > --
> > > 2.34.1
> > >
Sivaprasad Tummala July 14, 2023, 11:32 a.m. UTC | #4 
[AMD Official Use Only - General]

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Thursday, July 13, 2023 4:11 PM
> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <Ferruh.Yigit@amd.com>;
> bruce.richardson@intel.com; david.marchand@redhat.com; thomas@monjalon.net
> Subject: Re: [PATCH] doc: deprecation notice to add callback data to
> rte_event_fp_ops
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Thu, Jul 13, 2023 at 4:08 PM Tummala, Sivaprasad
> <Sivaprasad.Tummala@amd.com> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Jerin,
> >
> > > -----Original Message-----
> > > From: Jerin Jacob <jerinjacobk@gmail.com>
> > > Sent: Thursday, July 13, 2023 2:22 PM
> > > To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> > > Cc: dev@dpdk.org; Yigit, Ferruh <Ferruh.Yigit@amd.com>;
> > > bruce.richardson@intel.com; david.marchand@redhat.com;
> > > thomas@monjalon.net
> > > Subject: Re: [PATCH] doc: deprecation notice to add callback data to
> > > rte_event_fp_ops
> > >
> > > Caution: This message originated from an External Source. Use proper
> > > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > On Wed, Jul 12, 2023 at 11:01 PM Sivaprasad Tummala
> > > <sivaprasad.tummala@amd.com> wrote:
> > > >
> > > > Deprecation notice to add "rte_eventdev_port_data" field to
> > >
> > > Could you share the rational for why rte_eventdev_port_data needs to be
> added?
> >
> > "rte_eventdev_port_data" is used to hold callbacks registered optionally per
> event device port and associated callback data.
> > By adding "rte_eventdev_port_data" to "rte_event_fp_ops", allows to fetch this
> data for fastpath eventdev inline functions in advance.
>
> Please add above info in the release notes for next version.
Sure, will do the same.
>
> >
> > >
> > >
> > > > ``rte_event_fp_ops`` for callback support.
> > > >
> > > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > > > ---
> > > >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/doc/guides/rel_notes/deprecation.rst
> > > > b/doc/guides/rel_notes/deprecation.rst
> > > > index 8e1cdd677a..2c69338818 100644
> > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > @@ -133,6 +133,10 @@ Deprecation Notices
> > > >    ``rte_cryptodev_get_auth_algo_string``,
> > > ``rte_cryptodev_get_aead_algo_string`` and
> > > >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> > > >
> > > > +* eventdev: The struct rte_event_fp_ops will be updated with a
> > > > +new element
> > > > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > > > +This changes
> > > > +  the size of rte_event_fp_ops and result in ABI change.
> > > > +
> > > >  * flow_classify: The flow_classify library and example have no maintainer.
> > > >    The library is experimental and, as such, it could be removed from DPDK.
> > > >    Its removal has been postponed to let potential users report
> > > > interest
> > > > --
> > > > 2.34.1
> > > >
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 8e1cdd677a..2c69338818 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -133,6 +133,10 @@  Deprecation Notices
   ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
   ``rte_cryptodev_asym_get_xform_string`` respectively.
 
+* eventdev: The struct rte_event_fp_ops will be updated with a new element
+  rte_eventdev_port_data to support optional callbacks in DPDK 23.11. This changes
+  the size of rte_event_fp_ops and result in ABI change.
+
 * flow_classify: The flow_classify library and example have no maintainer.
   The library is experimental and, as such, it could be removed from DPDK.
   Its removal has been postponed to let potential users report interest