[v2,2/3] net/mlx5: fix handle validation for meter mark

Message ID 20230718133214.3895192-2-akozyrev@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series [v2,1/3] net/mlx5: fix validation for conntrack indirect action |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Alexander Kozyrev July 18, 2023, 1:32 p.m. UTC
  Skip the METER_MARK validation for the indirect action update.
The old synchronous indirect action update was left out
during the METER_MARK implementation in favor of the async way.
Allow the sync method of doing this with relaxed validation.

Fixes: 48fbb0e93d06 ("net/mlx5: support flow meter mark indirect action with HWS")

Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow.c | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Ori Kam July 18, 2023, 2:31 p.m. UTC | #1
> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Tuesday, July 18, 2023 4:32 PM
> 
> Skip the METER_MARK validation for the indirect action update.
> The old synchronous indirect action update was left out
> during the METER_MARK implementation in favor of the async way.
> Allow the sync method of doing this with relaxed validation.
> 
> Fixes: 48fbb0e93d06 ("net/mlx5: support flow meter mark indirect action with
> HWS")
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> ---
>  drivers/net/mlx5/mlx5_flow.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 9bd92f28fd..e91eb636d0 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -10758,6 +10758,7 @@ mlx5_action_handle_update(struct rte_eth_dev
> *dev,
> 
>  	switch (type) {
>  	case MLX5_INDIRECT_ACTION_TYPE_CT:
> +	case MLX5_INDIRECT_ACTION_TYPE_METER_MARK:
>  		ret = 0;
>  		break;
>  	default:
> --
> 2.18.2

Acked-by: Ori Kam <orika@nvidia.com>
Best,
Ori
  

Patch

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 9bd92f28fd..e91eb636d0 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -10758,6 +10758,7 @@  mlx5_action_handle_update(struct rte_eth_dev *dev,
 
 	switch (type) {
 	case MLX5_INDIRECT_ACTION_TYPE_CT:
+	case MLX5_INDIRECT_ACTION_TYPE_METER_MARK:
 		ret = 0;
 		break;
 	default: