There is currently no way to know which libraries are optional.
Introduce a enable_libs option (close to what we have for drivers) so
that packagers or projects consuming DPDK can more easily select the
optional libraries that matter to them and disable other optional
libraries.
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
Changes since v5:
- added an entry in the release notes,
Changes since v4:
- moved always_enable earlier for readability,
Changes since v3:
- split non related cleanup changes,
- fixed false positive complaints about disabling mandatory libs by
building the list of always enabled libs, appending this list to
enable_list and checking the disable side,
- updated enable/disable_libs descriptions,
Changes since v2:
- moved the IOVA check for kni build in lib/kni/meson.build,
- reworked deprecated libraries handling by only considering them when
no enable_libs option is set. With this, no need for a default value
in meson_options.txt, yet configurations in the CI must be adjusted,
- moved mandatory libraries check after enable/disable_libs evaluation,
---
doc/guides/rel_notes/release_23_11.rst | 3 +++
lib/meson.build | 34 +++++++++++++++++---------
meson_options.txt | 4 ++-
3 files changed, 28 insertions(+), 13 deletions(-)
@@ -58,6 +58,9 @@ New Features
* build: Enabling deprecated libraries (``flow_classify``, ``kni``) is now done
using the new ``enable_deprecated_libraries`` build option.
+* build: Optional libraries can now be selected with the new ``enable_libs``
+ build option similarly to the existing ``enable_drivers`` build option.
+
Removed Items
-------------
@@ -88,6 +88,13 @@ optional_libs = [
'vhost',
]
+always_enable = []
+foreach l:libraries
+ if not optional_libs.contains(l)
+ always_enable += l
+ endif
+endforeach
+
dpdk_libs_deprecated += [
'flow_classify',
'kni',
@@ -102,17 +109,13 @@ foreach l:run_command(list_dir_globs, get_option('enable_deprecated_libs'),
enable_deprecated_libs += l
endforeach
-disabled_libs = []
-opt_disabled_libs = run_command(list_dir_globs, get_option('disable_libs'),
- check: true).stdout().split()
-foreach l:opt_disabled_libs
- if not optional_libs.contains(l)
- warning('Cannot disable mandatory library "@0@"'.format(l))
- continue
- endif
- disabled_libs += l
-endforeach
+disable_libs = run_command(list_dir_globs, get_option('disable_libs'), check: true).stdout().split()
+enable_libs = run_command(list_dir_globs, get_option('enable_libs'), check: true).stdout().split()
+if enable_libs.length() == 0
+ enable_libs += optional_libs
+endif
+enable_libs += always_enable
default_cflags = machine_args
default_cflags += ['-DALLOW_EXPERIMENTAL_API']
@@ -153,9 +156,16 @@ foreach l:libraries
else
warning('Enabling deprecated library, "@0@"'.format(l))
endif
- elif disabled_libs.contains(l)
+ elif not enable_libs.contains(l)
build = false
- reason = 'explicitly disabled via build config'
+ reason = 'not in enabled libraries build config'
+ elif disable_libs.contains(l)
+ if always_enable.contains(l)
+ warning('Cannot disable mandatory library "@0@"'.format(l))
+ else
+ build = false
+ reason = 'explicitly disabled via build config'
+ endif
endif
if build
@@ -11,7 +11,7 @@ option('disable_apps', type: 'string', value: '', description:
option('disable_drivers', type: 'string', value: '', description:
'Comma-separated list of drivers to explicitly disable.')
option('disable_libs', type: 'string', value: '', description:
- 'Comma-separated list of libraries to explicitly disable. [NOTE: not all libs can be disabled]')
+ 'Comma-separated list of optional libraries to explicitly disable. [NOTE: mandatory libs cannot be disabled]')
option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>', description:
'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')
option('enable_docs', type: 'boolean', value: false, description:
@@ -26,6 +26,8 @@ option('enable_driver_sdk', type: 'boolean', value: false, description:
'Install headers to build drivers.')
option('enable_kmods', type: 'boolean', value: false, description:
'build kernel modules')
+option('enable_libs', type: 'string', value: '', description:
+ 'Comma-separated list of optional libraries to explicitly enable. [NOTE: mandatory libs are always enabled]')
option('examples', type: 'string', value: '', description:
'Comma-separated list of examples to build by default')
option('ibverbs_link', type: 'combo', choices : ['static', 'shared', 'dlopen'], value: 'shared', description: