[1/1] node: remove MAX macro from all nodes

Message ID 20230801084916.1542854-1-rkudurumalla@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [1/1] node: remove MAX macro from all nodes |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Rakesh Kudurumalla Aug. 1, 2023, 8:49 a.m. UTC
  Removed MAX macro from all graph nodes to extend
edges to nodes at ease

Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
---

v2: Update changes to TOT and resolve 
    dependecy related issues

 lib/node/ip4_lookup.c       | 2 +-
 lib/node/ip6_lookup.c       | 2 +-
 lib/node/rte_node_ip4_api.h | 2 --
 lib/node/rte_node_ip6_api.h | 2 --
 4 files changed, 2 insertions(+), 6 deletions(-)
  

Comments

Nithin Dabilpuram Sept. 27, 2023, 5:22 a.m. UTC | #1
Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>

On Tue, Aug 1, 2023 at 2:19 PM Rakesh Kudurumalla
<rkudurumalla@marvell.com> wrote:
>
> Removed MAX macro from all graph nodes to extend
> edges to nodes at ease
>
> Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> ---
>
> v2: Update changes to TOT and resolve
>     dependecy related issues
>
>  lib/node/ip4_lookup.c       | 2 +-
>  lib/node/ip6_lookup.c       | 2 +-
>  lib/node/rte_node_ip4_api.h | 2 --
>  lib/node/rte_node_ip6_api.h | 2 --
>  4 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c
> index 8bce03d7db..72fd760512 100644
> --- a/lib/node/ip4_lookup.c
> +++ b/lib/node/ip4_lookup.c
> @@ -225,7 +225,7 @@ static struct rte_node_register ip4_lookup_node = {
>
>         .init = ip4_lookup_node_init,
>
> -       .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_MAX,
> +       .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP + 1,
>         .next_nodes = {
>                 [RTE_NODE_IP4_LOOKUP_NEXT_REWRITE] = "ip4_rewrite",
>                 [RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
> diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c
> index 646e466551..6f56eb5ec5 100644
> --- a/lib/node/ip6_lookup.c
> +++ b/lib/node/ip6_lookup.c
> @@ -362,7 +362,7 @@ static struct rte_node_register ip6_lookup_node = {
>
>         .init = ip6_lookup_node_init,
>
> -       .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_MAX,
> +       .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP + 1,
>         .next_nodes = {
>                 [RTE_NODE_IP6_LOOKUP_NEXT_REWRITE] = "ip6_rewrite",
>                 [RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
> diff --git a/lib/node/rte_node_ip4_api.h b/lib/node/rte_node_ip4_api.h
> index 3397da0ae8..0f997761b6 100644
> --- a/lib/node/rte_node_ip4_api.h
> +++ b/lib/node/rte_node_ip4_api.h
> @@ -29,8 +29,6 @@ enum rte_node_ip4_lookup_next {
>         RTE_NODE_IP4_LOOKUP_NEXT_REWRITE,
>         /**< Rewrite node. */
>         RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP,
> -       /**< Packet drop node. */
> -       RTE_NODE_IP4_LOOKUP_NEXT_MAX,
>         /**< Number of next nodes of lookup node. */
>  };
>
> diff --git a/lib/node/rte_node_ip6_api.h b/lib/node/rte_node_ip6_api.h
> index f3b5a1002a..a538dc2ea7 100644
> --- a/lib/node/rte_node_ip6_api.h
> +++ b/lib/node/rte_node_ip6_api.h
> @@ -30,8 +30,6 @@ enum rte_node_ip6_lookup_next {
>         /**< Rewrite node. */
>         RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP,
>         /**< Packet drop node. */
> -       RTE_NODE_IP6_LOOKUP_NEXT_MAX,
> -       /**< Number of next nodes of lookup node. */
>  };
>
>  /**
> --
> 2.25.1
>
  

Patch

diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c
index 8bce03d7db..72fd760512 100644
--- a/lib/node/ip4_lookup.c
+++ b/lib/node/ip4_lookup.c
@@ -225,7 +225,7 @@  static struct rte_node_register ip4_lookup_node = {
 
 	.init = ip4_lookup_node_init,
 
-	.nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_MAX,
+	.nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP + 1,
 	.next_nodes = {
 		[RTE_NODE_IP4_LOOKUP_NEXT_REWRITE] = "ip4_rewrite",
 		[RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c
index 646e466551..6f56eb5ec5 100644
--- a/lib/node/ip6_lookup.c
+++ b/lib/node/ip6_lookup.c
@@ -362,7 +362,7 @@  static struct rte_node_register ip6_lookup_node = {
 
 	.init = ip6_lookup_node_init,
 
-	.nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_MAX,
+	.nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP + 1,
 	.next_nodes = {
 		[RTE_NODE_IP6_LOOKUP_NEXT_REWRITE] = "ip6_rewrite",
 		[RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
diff --git a/lib/node/rte_node_ip4_api.h b/lib/node/rte_node_ip4_api.h
index 3397da0ae8..0f997761b6 100644
--- a/lib/node/rte_node_ip4_api.h
+++ b/lib/node/rte_node_ip4_api.h
@@ -29,8 +29,6 @@  enum rte_node_ip4_lookup_next {
 	RTE_NODE_IP4_LOOKUP_NEXT_REWRITE,
 	/**< Rewrite node. */
 	RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP,
-	/**< Packet drop node. */
-	RTE_NODE_IP4_LOOKUP_NEXT_MAX,
 	/**< Number of next nodes of lookup node. */
 };
 
diff --git a/lib/node/rte_node_ip6_api.h b/lib/node/rte_node_ip6_api.h
index f3b5a1002a..a538dc2ea7 100644
--- a/lib/node/rte_node_ip6_api.h
+++ b/lib/node/rte_node_ip6_api.h
@@ -30,8 +30,6 @@  enum rte_node_ip6_lookup_next {
 	/**< Rewrite node. */
 	RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP,
 	/**< Packet drop node. */
-	RTE_NODE_IP6_LOOKUP_NEXT_MAX,
-	/**< Number of next nodes of lookup node. */
 };
 
 /**