diff mbox series

build: move enabled applications list declaration

Message ID 20230811132805.2434448-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series build: move enabled applications list declaration |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-compile-amd64-testing success Testing PASS

Commit Message

David Marchand Aug. 11, 2023, 1:28 p.m. UTC 
  No functional impact foreseen. Simply move this variable and rename it
for consistency with other similar variables.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/meson.build | 4 +---
 meson.build     | 3 ++-
 2 files changed, 3 insertions(+), 4 deletions(-)

Comments

Bruce Richardson Aug. 11, 2023, 1:40 p.m. UTC | #1 
On Fri, Aug 11, 2023 at 03:28:05PM +0200, David Marchand wrote:
> No functional impact foreseen. Simply move this variable and rename it
> for consistency with other similar variables.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Tyler Retzlaff Aug. 11, 2023, 3:59 p.m. UTC | #2 
On Fri, Aug 11, 2023 at 03:28:05PM +0200, David Marchand wrote:
> No functional impact foreseen. Simply move this variable and rename it
> for consistency with other similar variables.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
David Marchand Aug. 25, 2023, 8:39 a.m. UTC | #3 
On Fri, Aug 11, 2023 at 3:28 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> No functional impact foreseen. Simply move this variable and rename it
> for consistency with other similar variables.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by Tyler Retzlaff <roretzla@linux.microsoft.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/app/meson.build b/app/meson.build
index 4fc1a83eba..0c2e7e4c00 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -38,8 +38,6 @@  if get_option('default_library') == 'static' and not is_windows
     default_ldflags += ['-Wl,--export-dynamic']
 endif
 
-enabled_apps = [] # used to print summary at the end
-
 foreach app:apps
     name = app
     build = true
@@ -90,7 +88,7 @@  foreach app:apps
         continue
     endif
 
-    enabled_apps += app
+    dpdk_apps_enabled += app
     link_libs = []
     if get_option('default_library') == 'static'
         link_libs = dpdk_static_libraries + dpdk_drivers
diff --git a/meson.build b/meson.build
index 70b54f0c98..2e6e546d20 100644
--- a/meson.build
+++ b/meson.build
@@ -44,6 +44,7 @@  dpdk_drivers = []
 dpdk_extra_ldflags = []
 dpdk_libs_deprecated = []
 dpdk_apps_disabled = []
+dpdk_apps_enabled = []
 dpdk_libs_disabled = []
 dpdk_libs_enabled = []
 dpdk_drvs_disabled = []
@@ -123,7 +124,7 @@  endif
 output_message = '\n=================\nApplications Enabled\n=================\n'
 output_message += '\napps:\n\t'
 output_count = 0
-foreach app:enabled_apps
+foreach app:dpdk_apps_enabled
     output_message += app + ', '
     output_count += 1
     if output_count == 8