[v1] config/arm: correct cpu arch for cross build

  The cn10k cross build file sets cpu to 'armv8.6-a' while
N2 is armv8.5-a arch.
The cpu field in the cross file doesn't take effect as
config/arm/meson.build controls machine_args for march.
Then correct the value in arm cross files to 'auto'.

Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 config/arm/arm32_armv8_linux_gcc          | 2 +-
 config/arm/arm64_armada_linux_gcc         | 2 +-
 config/arm/arm64_armv8_linux_clang_ubuntu | 2 +-
 config/arm/arm64_armv8_linux_gcc          | 2 +-
 config/arm/arm64_bluefield_linux_gcc      | 2 +-
 config/arm/arm64_centriq2400_linux_gcc    | 2 +-
 config/arm/arm64_cn10k_linux_gcc          | 2 +-
 config/arm/arm64_cn9k_linux_gcc           | 2 +-
 config/arm/arm64_dpaa_linux_gcc           | 2 +-
 config/arm/arm64_emag_linux_gcc           | 2 +-
 config/arm/arm64_ft2000plus_linux_gcc     | 2 +-
 config/arm/arm64_graviton2_linux_gcc      | 2 +-
 config/arm/arm64_graviton3_linux_gcc      | 2 +-
 config/arm/arm64_kunpeng920_linux_gcc     | 2 +-
 config/arm/arm64_kunpeng930_linux_gcc     | 2 +-
 config/arm/arm64_n1sdp_linux_gcc          | 2 +-
 config/arm/arm64_n2_linux_gcc             | 2 +-
 config/arm/arm64_stingray_linux_gcc       | 2 +-
 config/arm/arm64_thunderx2_linux_gcc      | 2 +-
 config/arm/arm64_thunderxt83_linux_gcc    | 2 +-
 config/arm/arm64_thunderxt88_linux_gcc    | 2 +-
 config/arm/arm64_tys2500_linux_gcc        | 2 +-
 22 files changed, 22 insertions(+), 22 deletions(-)
  

22/08/2023 09:47, Joyce Kong:
> The cn10k cross build file sets cpu to 'armv8.6-a' while
> N2 is armv8.5-a arch.
> The cpu field in the cross file doesn't take effect as
> config/arm/meson.build controls machine_args for march.
> Then correct the value in arm cross files to 'auto'.

I don't get it.
Why setting a value if it has no impact?
Looks like something is overcomplicated.
  

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, October 18, 2023 3:42 AM
> To: Joyce Kong <Joyce.Kong@arm.com>
> Cc: Ruifeng Wang <Ruifeng.Wang@arm.com>; Bruce Richardson
> <bruce.richardson@intel.com>; dev@dpdk.org; nd <nd@arm.com>
> Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
> 
> 22/08/2023 09:47, Joyce Kong:
> > The cn10k cross build file sets cpu to 'armv8.6-a' while
> > N2 is armv8.5-a arch.
> > The cpu field in the cross file doesn't take effect as
> > config/arm/meson.build controls machine_args for march.
> > Then correct the value in arm cross files to 'auto'.
> 
> I don't get it.
> Why setting a value if it has no impact?
> Looks like something is overcomplicated.
> 
We still have to declare them here because meson would check the 'cpu' line in the config file, otherwise it would report missing {'cpu'}.
  

18/10/2023 07:40, Joyce Kong:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > 22/08/2023 09:47, Joyce Kong:
> > > The cn10k cross build file sets cpu to 'armv8.6-a' while
> > > N2 is armv8.5-a arch.
> > > The cpu field in the cross file doesn't take effect as
> > > config/arm/meson.build controls machine_args for march.
> > > Then correct the value in arm cross files to 'auto'.
> > 
> > I don't get it.
> > Why setting a value if it has no impact?
> > Looks like something is overcomplicated.
> > 
> We still have to declare them here because meson would check the 'cpu' line in the config file, otherwise it would report missing {'cpu'}.

OK

Then why not all cross files are set to auto?
  

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, November 6, 2023 10:10 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Joyce Kong
> <Joyce.Kong@arm.com>
> Cc: dev@dpdk.org; Bruce Richardson <bruce.richardson@intel.com>;
> dev@dpdk.org; nd <nd@arm.com>; Paul Szczepanek
> <Paul.Szczepanek@arm.com>
> Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
> 
> 18/10/2023 07:40, Joyce Kong:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > 22/08/2023 09:47, Joyce Kong:
> > > > The cn10k cross build file sets cpu to 'armv8.6-a' while
> > > > N2 is armv8.5-a arch.
> > > > The cpu field in the cross file doesn't take effect as
> > > > config/arm/meson.build controls machine_args for march.
> > > > Then correct the value in arm cross files to 'auto'.
> > >
> > > I don't get it.
> > > Why setting a value if it has no impact?
> > > Looks like something is overcomplicated.
> > >
> > We still have to declare them here because meson would check the 'cpu'
> line in the config file, otherwise it would report missing {'cpu'}.
> 
> OK
> 
> Then why not all cross files are set to auto?
> 
Actually, I set all the Arm cross files to auto in this patch. Maybe I have to figure it out in the commit line?
  

06/11/2023 15:31, Joyce Kong:
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Monday, November 6, 2023 10:10 PM
> > To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Joyce Kong
> > <Joyce.Kong@arm.com>
> > Cc: dev@dpdk.org; Bruce Richardson <bruce.richardson@intel.com>;
> > dev@dpdk.org; nd <nd@arm.com>; Paul Szczepanek
> > <Paul.Szczepanek@arm.com>
> > Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
> > 
> > 18/10/2023 07:40, Joyce Kong:
> > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 22/08/2023 09:47, Joyce Kong:
> > > > > The cn10k cross build file sets cpu to 'armv8.6-a' while
> > > > > N2 is armv8.5-a arch.
> > > > > The cpu field in the cross file doesn't take effect as
> > > > > config/arm/meson.build controls machine_args for march.
> > > > > Then correct the value in arm cross files to 'auto'.
> > > >
> > > > I don't get it.
> > > > Why setting a value if it has no impact?
> > > > Looks like something is overcomplicated.
> > > >
> > > We still have to declare them here because meson would check the 'cpu'
> > line in the config file, otherwise it would report missing {'cpu'}.
> > 
> > OK
> > 
> > Then why not all cross files are set to auto?
> > 
> Actually, I set all the Arm cross files to auto in this patch. Maybe I have to figure it out in the commit line?

What about these ones?

git grep 'cpu = ' config/arm | grep -v auto

config/arm/arm64_altra_linux_gcc:cpu = 'armv8.2-a'
config/arm/arm64_ampereone_linux_gcc:cpu = 'armv8.6-a'
config/arm/arm64_bluefield3_linux_gcc:cpu = 'armv8.4-a'
config/arm/arm64_cdx_linux_gcc:cpu = 'armv8-a'
config/arm/arm64_hip10_linux_gcc:cpu = 'armv8-a'
  

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, November 6, 2023 11:38 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Cc: dev@dpdk.org; Bruce Richardson <bruce.richardson@intel.com>; nd
> <nd@arm.com>; Paul Szczepanek <Paul.Szczepanek@arm.com>; Joyce Kong
> <Joyce.Kong@arm.com>
> Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
> 
> 06/11/2023 15:31, Joyce Kong:
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Monday, November 6, 2023 10:10 PM
> > > To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Joyce Kong
> > > <Joyce.Kong@arm.com>
> > > Cc: dev@dpdk.org; Bruce Richardson <bruce.richardson@intel.com>;
> > > dev@dpdk.org; nd <nd@arm.com>; Paul Szczepanek
> > > <Paul.Szczepanek@arm.com>
> > > Subject: Re: [PATCH v1] config/arm: correct cpu arch for cross build
> > >
> > > 18/10/2023 07:40, Joyce Kong:
> > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > 22/08/2023 09:47, Joyce Kong:
> > > > > > The cn10k cross build file sets cpu to 'armv8.6-a' while
> > > > > > N2 is armv8.5-a arch.
> > > > > > The cpu field in the cross file doesn't take effect as
> > > > > > config/arm/meson.build controls machine_args for march.
> > > > > > Then correct the value in arm cross files to 'auto'.
> > > > >
> > > > > I don't get it.
> > > > > Why setting a value if it has no impact?
> > > > > Looks like something is overcomplicated.
> > > > >
> > > > We still have to declare them here because meson would check the 'cpu'
> > > line in the config file, otherwise it would report missing {'cpu'}.
> > >
> > > OK
> > >
> > > Then why not all cross files are set to auto?
> > >
> > Actually, I set all the Arm cross files to auto in this patch. Maybe I have to
> figure it out in the commit line?
> 
> What about these ones?
> 
> git grep 'cpu = ' config/arm | grep -v auto
> 
> config/arm/arm64_altra_linux_gcc:cpu = 'armv8.2-a'
> config/arm/arm64_ampereone_linux_gcc:cpu = 'armv8.6-a'
> config/arm/arm64_bluefield3_linux_gcc:cpu = 'armv8.4-a'
> config/arm/arm64_cdx_linux_gcc:cpu = 'armv8-a'
> config/arm/arm64_hip10_linux_gcc:cpu = 'armv8-a'
> 
> 
Really sorry for missing them as I didn't update the version, I shall correct them in next patch.