From patchwork Fri Aug 25 10:18:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 130765 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F3EA430FF; Fri, 25 Aug 2023 12:18:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E383343036; Fri, 25 Aug 2023 12:18:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A50F140695 for ; Fri, 25 Aug 2023 12:18:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692958716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OYOTSBzXtJJPn5Fczwg28zDsEjoUMyJmrx3SQFf/K1M=; b=iO9BpMunzJJHeTz45L8VdCqZT5lkxUF/EYfpz8WRoY8BQZibWGqppQvgOu553EZXEKURe9 fIwZfrD+VAGRVZwWpwz51cZFPhiWeRnEIu/bWw9eKUPj/qKkKvqxoBf1o+wz9KdK1aBNhD +GGOzKSS/G99attHzQrguAp+5gUaYbQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-588-my6VXR-1NmK19gzXYe9NQg-1; Fri, 25 Aug 2023 06:18:33 -0400 X-MC-Unique: my6VXR-1NmK19gzXYe9NQg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AD304857A84; Fri, 25 Aug 2023 10:18:32 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.225.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED25F2166B26; Fri, 25 Aug 2023 10:18:31 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: roretzla@linux.microsoft.com, Thomas Monjalon Subject: [PATCH 2/2] devtools: forbid use of builtin helpers for bit count Date: Fri, 25 Aug 2023 12:18:11 +0200 Message-ID: <20230825101812.2396339-2-david.marchand@redhat.com> In-Reply-To: <20230825101812.2396339-1-david.marchand@redhat.com> References: <20230825101812.2396339-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Now that DPDK provides some bit count operations, flag it to avoid reintroducing __builtin_*. Signed-off-by: David Marchand Acked-by: Tyler Retzlaff --- devtools/checkpatches.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 43f5e36a18..55fabc5458 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -127,6 +127,14 @@ check_forbidden_additions() { # -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ "$1" || res=1 + # forbid use of non abstracted bit count operations + awk -v FOLDERS="lib drivers app examples" \ + -v EXPRESSIONS='\\<__builtin_(clz|clzll|ctz|ctzll|popcount|popcountll)\\>' \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Using __builtin helpers for bit count operations' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + # forbid use of experimental build flag except in examples awk -v FOLDERS='lib drivers app' \ -v EXPRESSIONS='-DALLOW_EXPERIMENTAL_API allow_experimental_apis' \