diff mbox series

build: add pdcp to optional libs

Message ID 20230825141854.172954-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series build: add pdcp to optional libs |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation warning apply issues

Commit Message

Bruce Richardson Aug. 25, 2023, 2:18 p.m. UTC 
  The pdcp library is disabled when its dependent library "reorder" is not
being built.

../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"

As such, it is not a mandatory library, and can be marked as safe to
disable.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/meson.build | 1 +
 1 file changed, 1 insertion(+)

Comments

Tyler Retzlaff Aug. 25, 2023, 4:05 p.m. UTC | #1 
On Fri, Aug 25, 2023 at 03:18:54PM +0100, Bruce Richardson wrote:
> The pdcp library is disabled when its dependent library "reorder" is not
> being built.
> 
> ../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
> Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"
> 
> As such, it is not a mandatory library, and can be marked as safe to
> disable.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
David Marchand Aug. 28, 2023, 9:31 a.m. UTC | #2 
On Fri, Aug 25, 2023 at 4:19 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The pdcp library is disabled when its dependent library "reorder" is not
> being built.
>
> ../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
> Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"
>
> As such, it is not a mandatory library, and can be marked as safe to
> disable.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: David Marchand <david.marchand@redhat.com>
David Marchand Aug. 29, 2023, 8:03 a.m. UTC | #3 
On Fri, Aug 25, 2023 at 4:19 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The pdcp library is disabled when its dependent library "reorder" is not
> being built.
>
> ../lib/meson.build:179: WARNING: Cannot disable mandatory library "pdcp"
> Message: Disabling pdcp [lib/pdcp]: missing internal dependency "reorder"
>
> As such, it is not a mandatory library, and can be marked as safe to
> disable.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/lib/meson.build b/lib/meson.build
index 53155be8e9..c1602e818a 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -96,6 +96,7 @@  optional_libs = [
         'mldev',
         'node',
         'pcapng',
+        'pdcp',
         'pdump',
         'pipeline',
         'port',