app/bbdev: fix link with NXP LA12XX

Message ID 20230913135843.601790-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Maxime Coquelin
Headers
Series app/bbdev: fix link with NXP LA12XX |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

David Marchand Sept. 13, 2023, 1:58 p.m. UTC
  The LA12XX driver was not linked to the dpdk-test-bbdev tool because of
what looks like a rebase issue.

Fixes: 2b504721bfda ("app/bbdev: enable la12xx")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 app/test-bbdev/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Chautru, Nicolas Sept. 13, 2023, 4:37 p.m. UTC | #1
Acked-by: Nicolas Chautru <nicolas.chautru@intel.com>

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, September 13, 2023 6:59 AM
> To: dev@dpdk.org
> Cc: maxime.coquelin@redhat.com; stable@dpdk.org; Chautru, Nicolas
> <nicolas.chautru@intel.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Akhil Goyal <gakhil@marvell.com>
> Subject: [PATCH] app/bbdev: fix link with NXP LA12XX
> 
> The LA12XX driver was not linked to the dpdk-test-bbdev tool because of what
> looks like a rebase issue.
> 
> Fixes: 2b504721bfda ("app/bbdev: enable la12xx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  app/test-bbdev/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build index
> cd6a5089d5..926e0a5271 100644
> --- a/app/test-bbdev/meson.build
> +++ b/app/test-bbdev/meson.build
> @@ -23,6 +23,6 @@ endif
>  if dpdk_conf.has('RTE_BASEBAND_ACC')
>      deps += ['baseband_acc']
>  endif
> -if dpdk_conf.has('RTE_LIBRTE_PMD_BBDEV_LA12XX')
> +if dpdk_conf.has('RTE_BASEBAND_LA12XX')
>      deps += ['baseband_la12xx']
>  endif
> --
> 2.41.0
  
Hemant Agrawal Sept. 15, 2023, 5:38 a.m. UTC | #2
Thanks
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, September 13, 2023 7:29 PM
> To: dev@dpdk.org
> Cc: maxime.coquelin@redhat.com; stable@dpdk.org; Nicolas Chautru
> <nicolas.chautru@intel.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Akhil Goyal <gakhil@marvell.com>
> Subject: [PATCH] app/bbdev: fix link with NXP LA12XX
> Importance: High
> 
> The LA12XX driver was not linked to the dpdk-test-bbdev tool because of
> what looks like a rebase issue.
> 
> Fixes: 2b504721bfda ("app/bbdev: enable la12xx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  app/test-bbdev/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build
> index cd6a5089d5..926e0a5271 100644
> --- a/app/test-bbdev/meson.build
> +++ b/app/test-bbdev/meson.build
> @@ -23,6 +23,6 @@ endif
>  if dpdk_conf.has('RTE_BASEBAND_ACC')
>      deps += ['baseband_acc']
>  endif
> -if dpdk_conf.has('RTE_LIBRTE_PMD_BBDEV_LA12XX')
> +if dpdk_conf.has('RTE_BASEBAND_LA12XX')
>      deps += ['baseband_la12xx']
>  endif
> --
> 2.41.0
  
Maxime Coquelin Sept. 28, 2023, 7:32 a.m. UTC | #3
On 9/13/23 15:58, David Marchand wrote:
> The LA12XX driver was not linked to the dpdk-test-bbdev tool because of
> what looks like a rebase issue.
> 
> Fixes: 2b504721bfda ("app/bbdev: enable la12xx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   app/test-bbdev/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build
> index cd6a5089d5..926e0a5271 100644
> --- a/app/test-bbdev/meson.build
> +++ b/app/test-bbdev/meson.build
> @@ -23,6 +23,6 @@ endif
>   if dpdk_conf.has('RTE_BASEBAND_ACC')
>       deps += ['baseband_acc']
>   endif
> -if dpdk_conf.has('RTE_LIBRTE_PMD_BBDEV_LA12XX')
> +if dpdk_conf.has('RTE_BASEBAND_LA12XX')
>       deps += ['baseband_la12xx']
>   endif

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
  
Maxime Coquelin Oct. 12, 2023, 1:53 p.m. UTC | #4
On 9/13/23 15:58, David Marchand wrote:
> The LA12XX driver was not linked to the dpdk-test-bbdev tool because of
> what looks like a rebase issue.
> 
> Fixes: 2b504721bfda ("app/bbdev: enable la12xx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   app/test-bbdev/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build
> index cd6a5089d5..926e0a5271 100644
> --- a/app/test-bbdev/meson.build
> +++ b/app/test-bbdev/meson.build
> @@ -23,6 +23,6 @@ endif
>   if dpdk_conf.has('RTE_BASEBAND_ACC')
>       deps += ['baseband_acc']
>   endif
> -if dpdk_conf.has('RTE_LIBRTE_PMD_BBDEV_LA12XX')
> +if dpdk_conf.has('RTE_BASEBAND_LA12XX')
>       deps += ['baseband_la12xx']
>   endif

Applied to next-baseband/for-main.

Thanks,
Maxime
  

Patch

diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build
index cd6a5089d5..926e0a5271 100644
--- a/app/test-bbdev/meson.build
+++ b/app/test-bbdev/meson.build
@@ -23,6 +23,6 @@  endif
 if dpdk_conf.has('RTE_BASEBAND_ACC')
     deps += ['baseband_acc']
 endif
-if dpdk_conf.has('RTE_LIBRTE_PMD_BBDEV_LA12XX')
+if dpdk_conf.has('RTE_BASEBAND_LA12XX')
     deps += ['baseband_la12xx']
 endif