From patchwork Thu Sep 28 02:33:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rongwei Liu X-Patchwork-Id: 132069 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9ED2C42658; Thu, 28 Sep 2023 04:34:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CC00402EB; Thu, 28 Sep 2023 04:34:14 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2052.outbound.protection.outlook.com [40.107.243.52]) by mails.dpdk.org (Postfix) with ESMTP id A0415402D6 for ; Thu, 28 Sep 2023 04:34:10 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AGY724E8jm2/jP3QDJhjIw5opkKmlK+qoIOD+6XRa0+aQA3BpvjE6ZyvI/SxsFN3bOCEvCEaIaThC+FdidzZmSv44Dygx5SnhD5MmreTTcy0/Gi3B3m5sIpqUw6m+du6Y0/zkWgeThyl6LO5ARpHh3qbS8fwz85r584j2T3yDwllj1xlUVWbU/b5xpx5wstmwFBlnP6aLkBIHktF72ylIizp0ZiVTQB5YD7IcyiHgBzD2zarhDX73+/kAYYF1gXr3mdqx3V3x9CTFfvJGZYC0KwxZk/08lBEpmrqa6Qk4LGaQl8vblS/qUTCbKuxA9HltBtyFtxkfrEm5HWTPsSnUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rBygQ+huXweDwI1Bh/57TSBj8VxipEaMqQKYf6+61co=; b=Vnyj8EG1/3vAO8SWxB6v+rxxP+kSJxMwdHHHU9p0tXWt1OoAwLAWq1GKKIKaCsoarnvhPsdYx/iiKAH183v3yl0NJVGk07+KfI+C9rK1Tm/MnTc6YDHKQhTxG6NU8I1Y8ZV6eSwlNsjmzVGa3Xp097p3zI6+SORjpW4hwJ6R1za7lXw6B3WGqG3vNuL2YoVBMh0vGsvrHt+lgF2Z/dveIfWguyHBQbRZGBaVBV0mKMbJC31VjNB/vKQsrssakwnzkr/rvpJmEleDxxZzqvLGE5SMUIG/H1B9GXjnoEqHPzY0FPppScuVWfaIYw3JRLo28o1ibC8IXPaIPA48ECHYeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rBygQ+huXweDwI1Bh/57TSBj8VxipEaMqQKYf6+61co=; b=AHsz8kcDBpSpq9vE3BgkHACXbiTXkmuIrkJkaqpCxk+0JLoNEnUX/oPyLTNpGorXyMoVw6Lb7WmOI+q0vj089OoI6tmtN2mP3Sq/4WKNXiSDVZJP5HWs2BPXU6Oui8WVMX4vWWvz3w8ph80+Ek5uwTpu5rtGqlkEzQN3xHTQ8sN2ddm52rt9dwjufG9tB7tQBA5YYsHb+eJnMHcX7gbIUAaf83ApdmM7wAQ+fkR7heKO92k0CmkE2J4hxG7sSVBBVcsI01UExYokGVLPJsOwvQByO9eO+7cuP2zn6S6GmbRm/Mcrfbda081fdd9ceSFwRi4+gLNq2YadTyS8kIJYNA== Received: from DM6PR05CA0049.namprd05.prod.outlook.com (2603:10b6:5:335::18) by PH8PR12MB7278.namprd12.prod.outlook.com (2603:10b6:510:222::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Thu, 28 Sep 2023 02:34:08 +0000 Received: from CY4PEPF0000EDD6.namprd03.prod.outlook.com (2603:10b6:5:335:cafe::1c) by DM6PR05CA0049.outlook.office365.com (2603:10b6:5:335::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22 via Frontend Transport; Thu, 28 Sep 2023 02:34:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EDD6.mail.protection.outlook.com (10.167.241.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.19 via Frontend Transport; Thu, 28 Sep 2023 02:34:08 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 27 Sep 2023 19:34:01 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 27 Sep 2023 19:33:58 -0700 From: Rongwei Liu To: , , , , , CC: Subject: [PATCH v1 2/5] net/mlx5/hws: fix potential wrong rte_errno value Date: Thu, 28 Sep 2023 05:33:37 +0300 Message-ID: <20230928023341.1239731-3-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230928023341.1239731-1-rongweil@nvidia.com> References: <20230928023341.1239731-1-rongweil@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail202.nvidia.com (10.129.68.7) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD6:EE_|PH8PR12MB7278:EE_ X-MS-Office365-Filtering-Correlation-Id: f7391ed1-8097-4c9e-c6dd-08dbbfcb6457 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xEdlNeBOv8/kb9OMHT+TdXzOUjsu+/v9HI3vgJ8JJnd7GGSgTRwLoas8dRM13HGMWp+oa6Hy9E5so/Ow6eUF9+Aqlw/t7ytWC7xcRn32StAFb47Wa7nLOkw9eO5lwvCPAlGkWthsUdIdH4Wh5movjNKwaWg1LwATztxuSOTxCZeJmXttj+3X+BD9jCIxlVCeWfAcl/IhkTVYsnumwZebP5P6ohP3n0TlPLmu7WqpNDgOXWucIH5rypVA0XlRARBK/k+TMPjUp5e9sf8GVLJyxXHJVgN2oYM745NOmrogrxBz7r+a0gMgsLU0CBHBdAFVNSdGTYV679m0BJqsv8xsJwy+2S0TEcHknjehrx6qt/szdqUl5TxibHXolLvjFiKcmK/vdb24cL7CLABMaMLlpzp9p4fqwEbINvwGmEhRHBbdIoyROVhVSI9NHNaQt7eFBcLh0qTUQdivuVTjOazL6w8SnQ4i7WjUinCmENRY/6y3ei3nMMuyYhd59Dtnd/LLCw+2Lfqs3lsgvl6vJEYD+hfyK6BgRPgkjUnbygzodQUH/uviTpH56aMlWkaqtuZ3ExksygSyZA4NUryjwtq9+huaA0maI3IhclvEcJRwjV+wtCX24v7fABguIh43W9SAVTLWFhBTCgK1V1atA0Laqb9EpiCUjvjXERs5HJRCXG8jFIlj0lopJ5VvaEZCcq378+GGO0XlbFvm5e/6IQymaYyuvRJZ2GCowhxfUa0jF9jOVBeiHLIizfD8j1Q8hL3G X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(376002)(39860400002)(136003)(346002)(230922051799003)(82310400011)(1800799009)(64100799003)(451199024)(186009)(40470700004)(46966006)(36840700001)(426003)(16526019)(2616005)(6286002)(336012)(107886003)(26005)(1076003)(7696005)(7636003)(86362001)(36756003)(47076005)(36860700001)(55016003)(40480700001)(40460700003)(83380400001)(356005)(82740400003)(41300700001)(110136005)(8936002)(4326008)(8676002)(70586007)(70206006)(5660300002)(4744005)(2906002)(316002)(478600001)(6666004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 02:34:08.4703 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7391ed1-8097-4c9e-c6dd-08dbbfcb6457 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD6.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7278 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org A valid rte_errno is desired when DR layer api returns error and it can't over-write the value set by under-layer. Fixes: 0a2657c4ff4d ("net/mlx5/hws: support insert header action") Cc: hamdani@nvidia.com Signed-off-by: Rongwei Liu --- drivers/net/mlx5/hws/mlx5dr_action.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c index 769bb97e18..4e04d77852 100644 --- a/drivers/net/mlx5/hws/mlx5dr_action.c +++ b/drivers/net/mlx5/hws/mlx5dr_action.c @@ -2291,6 +2291,7 @@ mlx5dr_action_create_insert_header(struct mlx5dr_context *ctx, if (!num_of_hdrs) { DR_LOG(ERR, "Reformat num_of_hdrs cannot be zero"); + rte_errno = EINVAL; return NULL; } @@ -2338,7 +2339,6 @@ mlx5dr_action_create_insert_header(struct mlx5dr_context *ctx, reformat_hdrs, log_bulk_size); if (ret) { DR_LOG(ERR, "Failed to create HWS reformat action"); - rte_errno = EINVAL; goto free_reformat_hdrs; }