app/test: drop dependency on crypto scheduler driver
Checks
Commit Message
The cryptodev autotests make use of the crypto scheduler driver when it
is available, but build fine without. We can therefore remove the hard
dependency on that driver when building the crypto test files.
Fixes: 50823f30f0c8 ("test: build using per-file dependencies")
Reported-by: Akhil Goyal <gakhil@marvell.com>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
app/test/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> The cryptodev autotests make use of the crypto scheduler driver when it
> is available, but build fine without. We can therefore remove the hard
> dependency on that driver when building the crypto test files.
>
> Fixes: 50823f30f0c8 ("test: build using per-file dependencies")
>
> Reported-by: Akhil Goyal <gakhil@marvell.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Akhil Goyal <gakhil@marvell.com>
On Thu, Sep 28, 2023 at 11:37 AM Akhil Goyal <gakhil@marvell.com> wrote:
>
> > The cryptodev autotests make use of the crypto scheduler driver when it
> > is available, but build fine without. We can therefore remove the hard
> > dependency on that driver when building the crypto test files.
loongarch CI does not seem to agree, can you have a look?
> >
> > Fixes: 50823f30f0c8 ("test: build using per-file dependencies")
> >
> > Reported-by: Akhil Goyal <gakhil@marvell.com>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
On Thu, Sep 28, 2023 at 11:45:37AM +0200, David Marchand wrote:
> On Thu, Sep 28, 2023 at 11:37 AM Akhil Goyal <gakhil@marvell.com> wrote:
> >
> > > The cryptodev autotests make use of the crypto scheduler driver when it
> > > is available, but build fine without. We can therefore remove the hard
> > > dependency on that driver when building the crypto test files.
>
> loongarch CI does not seem to agree, can you have a look?
>
Yes, although I find the error reported a little strange as it should not
be including the header if the component is not available.
However, first I'm looking into some other issues I caught post-post
of the patch. The dependency tracking is also not correct after this
change, so I need to do a little more digging to fix this. I probably need
a precursor patch to fix the dependency assignment for the binary, as
having optional dependencies means we can no longer use the dependency list
for determining what objects we need to link against (and what header paths
to search). Instead for the unit tests, we should just link against
everything we have built.
Please ignore this patch for now. V2 set coming soon...
/Bruce
@@ -11,7 +11,7 @@ packet_burst_generator_deps = ['net']
sample_packet_forward_deps = ['net_ring', 'ethdev', 'bus_vdev']
virtual_pmd_deps = ['ethdev', 'net', 'bus_pci']
# test_cryptodev has material that other crypto tests need
-test_cryptodev_deps = ['bus_vdev', 'net', 'cryptodev', 'crypto_scheduler', 'security']
+test_cryptodev_deps = ['bus_vdev', 'net', 'cryptodev', 'security']
source_file_deps = {
# The C files providing functionality to other test cases