[RFC,2/6] cryptodev: fix RSA xform for ASN.1 syntax

Message ID 20230928095300.1353-3-gmuthukrishn@marvell.com (mailing list archive)
State Deferred
Delegated to: akhil goyal
Series vhost: add asymmetric crypto support |


Context Check Description
ci/checkpatch success coding style OK

Commit Message

Gowrishankar Muthukrishnan Sept. 28, 2023, 9:52 a.m. UTC
  As per ASN.1 syntax (RFC 3447 Appendix A.1.2), RSA private key
would need specification of quintuple along with private exponent.
It is up to the implementation to internally handle, but not at
RTE itself to make them exclusive each other. Removing union
on them allows asymmetric implementation in VirtIO to benefit from
the xform as per ASN.1 syntax.

Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
 lib/cryptodev/rte_crypto_asym.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
index f0996816b9..afc5bdc874 100644
--- a/lib/cryptodev/rte_crypto_asym.h
+++ b/lib/cryptodev/rte_crypto_asym.h
@@ -310,7 +310,7 @@  struct rte_crypto_rsa_xform {
 	enum rte_crypto_rsa_priv_key_type key_type;
-	union {
+	struct {
 		rte_crypto_uint d;
 		/**< the RSA private exponent */
 		struct rte_crypto_rsa_priv_key_qt qt;