From patchwork Wed Oct 18 09:11:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 132886 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C178A43198; Wed, 18 Oct 2023 11:11:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52986402DC; Wed, 18 Oct 2023 11:11:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8B7EA4027C for ; Wed, 18 Oct 2023 11:11:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697620287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8pK5sTFxOsJtVR6D5KJs4ZDanKpDBaAW2GqEqm/1yUw=; b=eYcPTQceFqhQNyxSkQhmf6C2wAu/uhxeK+wTLxwQdQcDebxC57/U5gXSPSmnknEipBs1op t+qad2uM/JrFHyI5N+G+JVerpILLNKmsJEBakf/9VHspNYZf0QUN3S4GtUzhP8qfwUPIxi 8+okiKJHJ7GMrix9XXgSk43nZOX7s8M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-589-OClrq_icNDWKoGUmKK_YZQ-1; Wed, 18 Oct 2023 05:11:26 -0400 X-MC-Unique: OClrq_icNDWKoGUmKK_YZQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C5EB9889058; Wed, 18 Oct 2023 09:11:25 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.225.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C2C4492BEE; Wed, 18 Oct 2023 09:11:24 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, techboard@dpdk.org, Joyce Kong , Tyler Retzlaff Subject: [PATCH] bitops: mark new symbols as stable Date: Wed, 18 Oct 2023 11:11:22 +0200 Message-ID: <20231018091123.1594324-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Calling an experimental symbol from an inline helper triggers a warning when such code is not compiled with experimental API. This can be seen when rte_bitops.h gets (indirectly) included in OVS builds. On the other hand, rte_clz32, rte_clz64, rte_ctz32, rte_ctz64, rte_popcount32, rte_popcount64 are inline helpers for abstracting common bit counting functions. This part of the API is unlikely to change. Mark those symbols as stable. Fixes: 18898c4d06f9 ("eal: use abstracted bit count functions") Signed-off-by: David Marchand Reviewed-by: Joyce Kong Acked-by: Kevin Traynor --- Copying Techboard for info, as this goes against the usual policy of marking new API as experimental. --- lib/eal/include/rte_bitops.h | 48 ------------------------------------ 1 file changed, 48 deletions(-) diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h index 6b8ae8d3ac..174d25216d 100644 --- a/lib/eal/include/rte_bitops.h +++ b/lib/eal/include/rte_bitops.h @@ -280,9 +280,6 @@ rte_bit_relaxed_test_and_clear64(unsigned int nr, volatile uint64_t *addr) #ifdef RTE_TOOLCHAIN_MSVC /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Get the count of leading 0-bits in v. * * @param v @@ -290,7 +287,6 @@ rte_bit_relaxed_test_and_clear64(unsigned int nr, volatile uint64_t *addr) * @return * The count of leading zero bits. */ -__rte_experimental static inline unsigned int rte_clz32(uint32_t v) { @@ -302,9 +298,6 @@ rte_clz32(uint32_t v) } /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Get the count of leading 0-bits in v. * * @param v @@ -312,7 +305,6 @@ rte_clz32(uint32_t v) * @return * The count of leading zero bits. */ -__rte_experimental static inline unsigned int rte_clz64(uint64_t v) { @@ -324,9 +316,6 @@ rte_clz64(uint64_t v) } /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Get the count of trailing 0-bits in v. * * @param v @@ -334,7 +323,6 @@ rte_clz64(uint64_t v) * @return * The count of trailing zero bits. */ -__rte_experimental static inline unsigned int rte_ctz32(uint32_t v) { @@ -346,9 +334,6 @@ rte_ctz32(uint32_t v) } /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Get the count of trailing 0-bits in v. * * @param v @@ -356,7 +341,6 @@ rte_ctz32(uint32_t v) * @return * The count of trailing zero bits. */ -__rte_experimental static inline unsigned int rte_ctz64(uint64_t v) { @@ -368,9 +352,6 @@ rte_ctz64(uint64_t v) } /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Get the count of 1-bits in v. * * @param v @@ -378,7 +359,6 @@ rte_ctz64(uint64_t v) * @return * The count of 1-bits. */ -__rte_experimental static inline unsigned int rte_popcount32(uint32_t v) { @@ -386,9 +366,6 @@ rte_popcount32(uint32_t v) } /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Get the count of 1-bits in v. * * @param v @@ -396,7 +373,6 @@ rte_popcount32(uint32_t v) * @return * The count of 1-bits. */ -__rte_experimental static inline unsigned int rte_popcount64(uint64_t v) { @@ -406,9 +382,6 @@ rte_popcount64(uint64_t v) #else /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Get the count of leading 0-bits in v. * * @param v @@ -416,7 +389,6 @@ rte_popcount64(uint64_t v) * @return * The count of leading zero bits. */ -__rte_experimental static inline unsigned int rte_clz32(uint32_t v) { @@ -424,9 +396,6 @@ rte_clz32(uint32_t v) } /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Get the count of leading 0-bits in v. * * @param v @@ -434,7 +403,6 @@ rte_clz32(uint32_t v) * @return * The count of leading zero bits. */ -__rte_experimental static inline unsigned int rte_clz64(uint64_t v) { @@ -442,9 +410,6 @@ rte_clz64(uint64_t v) } /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Get the count of trailing 0-bits in v. * * @param v @@ -452,7 +417,6 @@ rte_clz64(uint64_t v) * @return * The count of trailing zero bits. */ -__rte_experimental static inline unsigned int rte_ctz32(uint32_t v) { @@ -460,9 +424,6 @@ rte_ctz32(uint32_t v) } /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Get the count of trailing 0-bits in v. * * @param v @@ -470,7 +431,6 @@ rte_ctz32(uint32_t v) * @return * The count of trailing zero bits. */ -__rte_experimental static inline unsigned int rte_ctz64(uint64_t v) { @@ -478,9 +438,6 @@ rte_ctz64(uint64_t v) } /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Get the count of 1-bits in v. * * @param v @@ -488,7 +445,6 @@ rte_ctz64(uint64_t v) * @return * The count of 1-bits. */ -__rte_experimental static inline unsigned int rte_popcount32(uint32_t v) { @@ -496,9 +452,6 @@ rte_popcount32(uint32_t v) } /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Get the count of 1-bits in v. * * @param v @@ -506,7 +459,6 @@ rte_popcount32(uint32_t v) * @return * The count of 1-bits. */ -__rte_experimental static inline unsigned int rte_popcount64(uint64_t v) {