ml/cnxk: don't export internal headers

Message ID 20231018091544.1701372-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series ml/cnxk: don't export internal headers |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS

Commit Message

David Marchand Oct. 18, 2023, 9:15 a.m. UTC
  driver_sdk_headers is used to expose headers that may be used by
external drivers.
Don't export ml/cnxk internal headers.

Fixes: fe83ffd9ec2e ("ml/cnxk: add skeleton")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/ml/cnxk/meson.build | 7 -------
 1 file changed, 7 deletions(-)
  

Comments

Srikanth Yalavarthi Oct. 18, 2023, 9:33 a.m. UTC | #1
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: 18 October 2023 14:46
> To: dev@dpdk.org
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; thomas@monjalon.net;
> Srikanth Yalavarthi <syalavarthi@marvell.com>; Prince Takkar
> <ptakkar@marvell.com>
> Subject: [EXT] [PATCH] ml/cnxk: don't export internal headers
> 
> External Email
> 
> ----------------------------------------------------------------------
> driver_sdk_headers is used to expose headers that may be used by external
> drivers.
> Don't export ml/cnxk internal headers.
> 
> Fixes: fe83ffd9ec2e ("ml/cnxk: add skeleton")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
  
Jerin Jacob Oct. 18, 2023, 2:21 p.m. UTC | #2
On Wed, Oct 18, 2023 at 3:03 PM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: 18 October 2023 14:46
> > To: dev@dpdk.org
> > Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; thomas@monjalon.net;
> > Srikanth Yalavarthi <syalavarthi@marvell.com>; Prince Takkar
> > <ptakkar@marvell.com>
> > Subject: [EXT] [PATCH] ml/cnxk: don't export internal headers
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > driver_sdk_headers is used to expose headers that may be used by external
> > drivers.
> > Don't export ml/cnxk internal headers.
> >
> > Fixes: fe83ffd9ec2e ("ml/cnxk: add skeleton")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Srikanth Yalavarthi <syalavarthi@marvell.com>

Applied to dpdk-next-net-mrvl/for-next-net. Thanks
  

Patch

diff --git a/drivers/ml/cnxk/meson.build b/drivers/ml/cnxk/meson.build
index 94fa4283b1..5bf17d8ae3 100644
--- a/drivers/ml/cnxk/meson.build
+++ b/drivers/ml/cnxk/meson.build
@@ -7,13 +7,6 @@  if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
     subdir_done()
 endif
 
-driver_sdk_headers = files(
-        'cn10k_ml_dev.h',
-        'cn10k_ml_ops.h',
-        'cn10k_ml_model.h',
-        'cn10k_ml_ocm.h',
-)
-
 sources = files(
         'cn10k_ml_dev.c',
         'cn10k_ml_ops.c',