From patchwork Mon Oct 23 10:23:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Sosnowski X-Patchwork-Id: 133173 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C91F431E1; Mon, 23 Oct 2023 12:24:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A059E40275; Mon, 23 Oct 2023 12:24:23 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2047.outbound.protection.outlook.com [40.107.92.47]) by mails.dpdk.org (Postfix) with ESMTP id 012F140270; Mon, 23 Oct 2023 12:24:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qc8XMXm2MHpN3DSdNe6HsBbsEDA2QgoIvEsQ/Qw+wX/DTxPnesmHX6I7mdApPb25I+d1Rg+xO0I7zfzK8skJlJmvptHnKp3Wy4aSrs1KAi3SkT6OdUO1cas2LQI46CWwj+jXe0BN2jS+Pk65U7+rJjqCm6AohkbSRo1oHycM6nN/XBCuCdhHemEe6GNo3aESmHSBXdfmywUsHmC9GRT58E0CXm54ed5NlKaowEB17ob6wIDGIXdGWWCVpRKrQ7dVXAU8goCzDaCtvn0oAYgd2XpWnwfhDSEqGtphIAqxMgDL3sFBUWmsRAVVhvYa2mIMCF11YNVBSj1CKsou76/zzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YnYPXrau91g9wRlpLcm5JN4xcgENtBjNfyovsJAz/0M=; b=GmtOjtgDHSm2QJnulcZ1aeAH0U2aiyQKBFackdJrc7BBlFK1uJ1F3JN2byDCc03Z3Xh6R2QqwYM12NrqzfrWlwZuv6iEePhOnIeDvgkMCw/tD1vEFW3lHHFozQFPK2VZgz6U+QYV5m5yzG5XE9RBoZqU78D22VyJNi/zBjYCmwv510bRHbJ4ntO70uXmv0EXfgMqKcFdA1kOoQeix84+7CTk5bDtaeaCiAEQeaD/QAuZWklgnesqDJZEnV81wsJ5wIb+hMqLe5rgvuu1Ml/lZW7+hSfkEL/ryvZVMqZdgankbaiel9lhE8eQSCdSNXt27rgrA212Tgdqf8YqtL3cpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YnYPXrau91g9wRlpLcm5JN4xcgENtBjNfyovsJAz/0M=; b=Td1/D0vEi5Dm1l7t46826dqfH/wV0k+i5JIeZjvR70+dXkQSwyV4JqlROEFwVUm1O7LBtWm2WL6eMq5yiZflQbrdJvTyLEeB1s72g4CPs5zLF10y8lRggYi6+Nze3CZK2x4nqfEuoq0cIAD97QlB70kYiMv3e1ZNOLmy1l4ca60DbYz/z3E5bHjdfQP563fOHYBZ7DuAG0EGr29wFk74k415tSLD3PprCBLc/buyvqAI9dXT4Y0miZroqISN8w0VGzEuY7h3/ZqIIXM/TwfzR3c4GmTV9Jk0WXz0vrPzh6+S/ARJqI/o1OdBLyoj5ItFNjvnoZLB6Yd2bQARC8wMQw== Received: from DS7PR07CA0018.namprd07.prod.outlook.com (2603:10b6:5:3af::27) by SN7PR12MB6768.namprd12.prod.outlook.com (2603:10b6:806:268::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Mon, 23 Oct 2023 10:24:19 +0000 Received: from DS3PEPF000099D9.namprd04.prod.outlook.com (2603:10b6:5:3af:cafe::f1) by DS7PR07CA0018.outlook.office365.com (2603:10b6:5:3af::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Mon, 23 Oct 2023 10:24:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS3PEPF000099D9.mail.protection.outlook.com (10.167.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Mon, 23 Oct 2023 10:24:19 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 23 Oct 2023 03:24:11 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 23 Oct 2023 03:24:09 -0700 From: Dariusz Sosnowski To: Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou CC: , Subject: [PATCH] net/mlx5: fix missing thread safety flag for flow API Date: Mon, 23 Oct 2023 13:23:02 +0300 Message-ID: <20231023102303.1443105-1-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099D9:EE_|SN7PR12MB6768:EE_ X-MS-Office365-Filtering-Correlation-Id: 9bbb5e8e-df8e-44a9-4c4d-08dbd3b23793 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +mtgn6flnuWPTagL9U2vu/gIX+ZLNu3WCQ1tEX14X8oGBtoMyr0RSDCrz7U3YXmrDWIQN1lTQwunoKJoEa/A214LvTu7C5hIdKUbKwMpdc/RjwKojSd/Gm3n9FZWgTzgjFV1dPwTRbfxNwFAwpaCUoNgHrQwTQG8ZDzKjzAivnE87uPQ1Pokr14h6HPaI8SBQkdID4AjTv/gU/GHBwATnq0YN47OV8YQM4tOJXUsVUo1PT1vBIlL72liBdkmLh6+fa58L/mq/70xAxCDTovk2yL+ZOQZbAVpTJqbQcp9DKrM/F9Dfg7sbxe2RIb0TNlJLJyOCaJyKuV7EAihWxLOHm2SUppn3YYT+7bFjBqVn6MutJUp08Bq18/HPGuowsGn2s8o5TtZ+fsXyQ9XSHdSUqrJh3pPsHZGaUw7ioUQmzM7M7akVYE0TlVONbqpNdJ9My4UWj2SseIH/rP6WJUVMSPGS6XJKwYM5V/EV7i9tADBSg8Dvnlu56b/2+EaY4J/M8hGCBp4cXe2wjrVwEz7V5dS4p/tDqM29RL9bcHTK4O5lc/AHLq2yS/5YdrLF/TavWHTvLWk1tjoDWOzw3mqopCkiy+5QqHRSmgLgA56AQcQcy2JYkROEV1g1meQ3jBuUz+Fbh7IcA6DSztXNY+mRbsZFfAcxsFKD/N+eL6CzLqEJTCTqB/NPm2c1VTh7CxHkneDrtBQQ2/amQya4tBgmGlhFgUWDJLeEyaZ3h2OUwFcLvlnaM2OpX3/BfqMKwpN X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(376002)(39860400002)(136003)(346002)(230922051799003)(82310400011)(186009)(1800799009)(64100799003)(451199024)(36840700001)(46966006)(40470700004)(40480700001)(36756003)(40460700003)(55016003)(26005)(316002)(70586007)(450100002)(110136005)(7696005)(86362001)(6636002)(7636003)(356005)(478600001)(36860700001)(83380400001)(426003)(70206006)(336012)(2616005)(8936002)(6666004)(1076003)(6286002)(16526019)(54906003)(4326008)(2906002)(41300700001)(8676002)(47076005)(82740400003)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 10:24:19.1690 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9bbb5e8e-df8e-44a9-4c4d-08dbd3b23793 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099D9.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6768 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When mlx5 port was configured with HW Steering flow engine (devarg dv_flow_en set to 2), PMD did not set RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE in device flags. This caused certain flow API calls, such as rte_flow_query(), to obtain a port-wide lock, which is not needed. This patch adds missing code for setting this flag. Fixes: d84c3cf7662c ("net/mlx5: introduce hardware steering enable routine") Cc: suanmingm@nvidia.com Cc: stable@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Suanming Mou --- drivers/net/mlx5/linux/mlx5_os.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index d5ef695e6d..1caece5405 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -1643,6 +1643,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev, "matching is disabled", eth_dev->data->port_id); } + eth_dev->data->dev_flags |= RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE; return eth_dev; #else DRV_LOG(ERR, "DV support is missing for HWS.");