diff mbox series

bus/ifpga: fix driver header dependency

Message ID 20231023144617.1033100-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series bus/ifpga: fix driver header dependency |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

David Marchand Oct. 23, 2023, 2:46 p.m. UTC 
  The driver header bus_ifpga_driver.h was not self sufficient.
Fix this by including dev_driver.h.

Fixes: 925c074e377b ("bus/ifpga: make driver-only headers private")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/bus/ifpga/bus_ifpga_driver.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Bruce Richardson Oct. 23, 2023, 3:05 p.m. UTC | #1 
On Mon, Oct 23, 2023 at 04:46:17PM +0200, David Marchand wrote:
> The driver header bus_ifpga_driver.h was not self sufficient.
> Fix this by including dev_driver.h.
> 
> Fixes: 925c074e377b ("bus/ifpga: make driver-only headers private")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Xu, Rosen Oct. 24, 2023, 12:23 a.m. UTC | #2 
Hi,

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, October 23, 2023 10:46 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Xu, Rosen <rosen.xu@intel.com>
> Subject: [PATCH] bus/ifpga: fix driver header dependency
> 
> The driver header bus_ifpga_driver.h was not self sufficient.
> Fix this by including dev_driver.h.
> 
> Fixes: 925c074e377b ("bus/ifpga: make driver-only headers private")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/bus/ifpga/bus_ifpga_driver.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/ifpga/bus_ifpga_driver.h
> b/drivers/bus/ifpga/bus_ifpga_driver.h
> index 7b75c2ddbc..5bbe36d6e0 100644
> --- a/drivers/bus/ifpga/bus_ifpga_driver.h
> +++ b/drivers/bus/ifpga/bus_ifpga_driver.h
> @@ -16,6 +16,7 @@ extern "C" {
>  #endif /* __cplusplus */
> 
>  #include <rte_compat.h>
> +#include <dev_driver.h>
>  #include <rte_pci.h>
>  #include <rte_interrupts.h>
>  #include <rte_spinlock.h>
> --
> 2.41.0

Acked-by: Rosen Xu <rosen.xu@intel.com>
David Marchand Oct. 26, 2023, 8:41 a.m. UTC | #3 
On Tue, Oct 24, 2023 at 2:23 AM Xu, Rosen <rosen.xu@intel.com> wrote:
> > The driver header bus_ifpga_driver.h was not self sufficient.
> > Fix this by including dev_driver.h.
> >
> > Fixes: 925c074e377b ("bus/ifpga: make driver-only headers private")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Rosen Xu <rosen.xu@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/bus/ifpga/bus_ifpga_driver.h b/drivers/bus/ifpga/bus_ifpga_driver.h
index 7b75c2ddbc..5bbe36d6e0 100644
--- a/drivers/bus/ifpga/bus_ifpga_driver.h
+++ b/drivers/bus/ifpga/bus_ifpga_driver.h
@@ -16,6 +16,7 @@  extern "C" {
 #endif /* __cplusplus */
 
 #include <rte_compat.h>
+#include <dev_driver.h>
 #include <rte_pci.h>
 #include <rte_interrupts.h>
 #include <rte_spinlock.h>