From patchwork Mon Oct 23 21:07:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 133202 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FB9D431E6; Mon, 23 Oct 2023 23:08:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BD8340698; Mon, 23 Oct 2023 23:08:25 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2064.outbound.protection.outlook.com [40.107.95.64]) by mails.dpdk.org (Postfix) with ESMTP id 90DAD402E1 for ; Mon, 23 Oct 2023 23:08:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GdLogrpnDW5E65uklBIa6+0amC/3+KIZJT7RCorqt+uUw2yJ1eAOqBVDhdqQtC32LXHRMft27LghJaRJWV2Q5D3Wj4E+YQDcIlak18RFhqXE+6EFa3g9DC492fHEbdMi04kFpdqwrlynNxFb76N4X6Antxj20rOdnY25zq94tX/WCyG8tkNvtjzk8X41xq0plqiEq361UyQDuQqShDl/P9MISvlwEi08GHgq+i4PYJzqgXloozVgvYPeMqv+/gXrFE/WtMLP1YDHzLFm8tw1TykQpu4i08Isl2b0g6H5VUPrpjnmvRgp09Qxugd6CPoHek/0hqDHKiJK8rHnDGBFSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=doVg3uloVj0g4isFYPoHdrJRqmk4hf5XRqDqwcYQMWM=; b=ehZMdwkUqYYCKwZfTgvXcYcus9M0ncXUk8PxBRlTKY59YnLIOv1yTsKLgetlrZhc6UP+lSUqCZqSzmYHMmVxIUzYXDf7xVpuFmzznyDzEWxB6BoBn1tjZBKdjBhSZ6qG3wf3yyxC7UEtQepyiXvsbY4ZgCtA2nFd/TnjqbGFUzT0ztnyUycAhfsRUWedGpZ5KEqDUDUOVfiEkGOPSQNnvr/fc05zo9JkHQFEptf+8BXO4E2wj1Wh+O13B2wc9jFd2/pqktbYeCcFw9/pGh08cNQtgbhBxKMKc63VVWE1OCL8YuldBP68Cv45SKLdIZc9CThagVVgT4Vj9fM457S1DQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=doVg3uloVj0g4isFYPoHdrJRqmk4hf5XRqDqwcYQMWM=; b=Dq4xddHgJWPQAGuXIC6C6kyNUjDmnh7QbAHf9jWdUPoghv4M15P0phTh9MqEHl0mjsMPwE1Z9P42RXFZ85eg1cSkCTe7vX4pV2aMOqAHZD983DF9ufpwfGP86P7J0wYopt3Ok4AJM6qYODAjm/yAbvaHiYgUUswQarZOLPlfuBPI0KS0LYhkXj5ZYQwTmsggxStnto0PYFypGKmN/fGh7tKYnNVuY2Nx9ctsc9cYUWmwCqyJE+/r9Z5/iWYOUvWaCb8TB8onP3VrTdQVRVg8ih0ctbwdBwBBwYitjKhUnblfVJq7aGNglnS5h6nGIOS9qNnnQWZno5NrADrVVMHbYg== Received: from PA7P264CA0514.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:3da::11) by MN0PR12MB6056.namprd12.prod.outlook.com (2603:10b6:208:3cc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Mon, 23 Oct 2023 21:08:19 +0000 Received: from SN1PEPF0002BA4B.namprd03.prod.outlook.com (2603:10a6:102:3da:cafe::2d) by PA7P264CA0514.outlook.office365.com (2603:10a6:102:3da::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Mon, 23 Oct 2023 21:08:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF0002BA4B.mail.protection.outlook.com (10.167.242.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Mon, 23 Oct 2023 21:08:18 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 23 Oct 2023 14:08:10 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 23 Oct 2023 14:08:07 -0700 From: Alexander Kozyrev To: CC: , , , , , Subject: [PATCH v2 7/7] net/mlx5/hws: fix integrity bits level Date: Tue, 24 Oct 2023 00:07:07 +0300 Message-ID: <20231023210707.1344241-8-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20231023210707.1344241-1-akozyrev@nvidia.com> References: <20231009163617.3999365-1-akozyrev@nvidia.com> <20231023210707.1344241-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA4B:EE_|MN0PR12MB6056:EE_ X-MS-Office365-Filtering-Correlation-Id: f53729cd-b256-4ac4-fa0b-08dbd40c2e92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wPUqg+kcnkMLvvpdxWBKKTpdSqq2uKa6O/LrrQ20dZoavWaAc2VJc8Uh6oItGpUtQq/adP5LKUHp0BqirnSaITDjjhWRsQY30wk43vKCifha1mpjSjb1n8BZxCpUoO0DfiszCN/3PntxE0iWistcDjcdGGNbwLpbFDYv03ck7s9xJlsYVGeqbJNucU+1nkJIGT6esJ4aVx2dHHm90ou5uXrwXSoj9NFhncSmyFMqFtKrmoqTmTmn+TFu6TweJeo2Dz6AwcpKihRmVcUuufbSsDvpWff+VsYiE8GtySEp0Q/PclrTAvyIypEsJFIaSUSTXbm63qusAgnLPjPSLMcBtv98Zdms8Cvdx6Qnw+iPIMUflFiTd42F+PsPqCLbXFhG/YU2IuP4i5fYdtuIkByClzeWyztODsrgLl0Bgzh2bxvQ1M+HONydjGzxSkzTQAA7W2AgOlwkIvV/7I6qPhOO9OnyHWLwIliIQcg4TRWF/nDlXkBiPXxqhNpnIedSDlLHTUcAOehrC+3y24JHtg+pto+0QC0AcBogAW+Sja0+mc6glq9L4LdGyhD5yT66vmJBHCTBlWEw8p0fEezxuY9GW663n66n3nF5D5T0iRZeWkHzAdMg87lhu3qVBypVvZ553j0Doq9JXVEyq/8mga0935403GA+uFjtPArQcQuPAbGTQKvPn1LM6HkVEdfJdt/igaAMOo6oBqGvG7hg5U22aZoCWlzYJ4kEPCCBLUwV9d0HKFWjQSpjV1haR5T8qQVI X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(346002)(39860400002)(396003)(376002)(136003)(230922051799003)(186009)(451199024)(1800799009)(64100799003)(82310400011)(40470700004)(46966006)(36840700001)(40460700003)(8676002)(86362001)(6916009)(36756003)(41300700001)(4326008)(2906002)(1076003)(7636003)(47076005)(40480700001)(356005)(16526019)(5660300002)(26005)(2616005)(82740400003)(36860700001)(336012)(83380400001)(107886003)(426003)(70206006)(478600001)(8936002)(70586007)(54906003)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 21:08:18.7731 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f53729cd-b256-4ac4-fa0b-08dbd40c2e92 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA4B.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6056 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The level field in the integrity item is not taken into account in the current implementation of hardware steering. Use this value instead of trying to find out the encapsulation level according to the protocol items involved. Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/hws/mlx5dr_definer.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index c752896ca7..f1f9235956 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -1905,7 +1905,6 @@ mlx5dr_definer_conv_item_integrity(struct mlx5dr_definer_conv_data *cd, { const struct rte_flow_item_integrity *m = item->mask; struct mlx5dr_definer_fc *fc; - bool inner = cd->tunnel; if (!m) return 0; @@ -1916,7 +1915,7 @@ mlx5dr_definer_conv_item_integrity(struct mlx5dr_definer_conv_data *cd, } if (m->l3_ok || m->ipv4_csum_ok || m->l4_ok || m->l4_csum_ok) { - fc = &cd->fc[DR_CALC_FNAME(INTEGRITY, inner)]; + fc = &cd->fc[DR_CALC_FNAME(INTEGRITY, m->level)]; fc->item_idx = item_idx; fc->tag_set = &mlx5dr_definer_integrity_set; DR_CALC_SET_HDR(fc, oks1, oks1_bits); @@ -2471,8 +2470,7 @@ mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx, break; case RTE_FLOW_ITEM_TYPE_INTEGRITY: ret = mlx5dr_definer_conv_item_integrity(&cd, items, i); - item_flags |= cd.tunnel ? MLX5_FLOW_ITEM_INNER_INTEGRITY : - MLX5_FLOW_ITEM_OUTER_INTEGRITY; + item_flags |= MLX5_FLOW_ITEM_INTEGRITY; break; case RTE_FLOW_ITEM_TYPE_CONNTRACK: ret = mlx5dr_definer_conv_item_conntrack(&cd, items, i);