From patchwork Tue Oct 24 17:51:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 133273 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 376F74316B; Tue, 24 Oct 2023 19:52:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6659B41611; Tue, 24 Oct 2023 19:52:32 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2066.outbound.protection.outlook.com [40.107.93.66]) by mails.dpdk.org (Postfix) with ESMTP id 0695041149 for ; Tue, 24 Oct 2023 19:52:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oP3CBJcGumdpIVRzsQ058neF+stuvxxHgyL/xqtPXkYK01Zb/ybwmLkjyPnxTivfTAKCBAfVhhdVNkoKZJhYKk1GR8JahnPUZirRgIwlz6Y00uUdRtnSjMU31ygQl3jQXVzbK6z16qdlRw/d2TaI2WeJH8DIss3qBoHBSozma2LkELAoQOe0Z4sAi1DK6cX0r7mdV6jKKnJ+e1/lPQ0ez+b1y7R11zGOo7PmJZN+kuL8Bob6WWruwwy9Qhn8jfQH9UfN3M8A6HPCL93B0ICTfVAJxrZKoNSj0/GMqOxpcJkmAi5s2DHuokcy2IV4DhdFsIGZboTIueatcKtoLZhJKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oWeZwn5xG7H5zSU/ocy7CMHvsOSmmGtJ+ZRFpze9oXk=; b=ISfUsd60DOrMapn7n/CJqYzxf/isNJ7kAUCmOi1erG401UwYToHewwaxR0591cU8yBpSk71jvRLxCw2d9rUQufFYnHRNGxuY9MGI225XIPczSsyaFlZVbWrN/fhZd/f6JGjCSgO1Z7jtYaeakZpBkGm3jl1XJ93wY4RzTsfyaG169l6erJpsdmKyyuNLkH67eMMk9SQOnwJmDkaR3TT5VMDGyZfmEbx0pJ/Ju6mX14quibDEg0qrMghkWywE+nFWhGB8FN3vwRWQ4Lry4/hykh9oCCWLQu76PBQdQDV1pdORGCmxb/v0f5ppJLQhFHwt+P9bNVhxq9oTSFEk7Ax79w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oWeZwn5xG7H5zSU/ocy7CMHvsOSmmGtJ+ZRFpze9oXk=; b=i5bbWTV2S56On9+8E+LR/woed0eMTcUDQW3VMSjvTbD5ijeTO/RJc8WWHipeJxGH96f6HJR0rgN9uXDTnreB8LIGVms4fV/Kab4p9f1KQCXYDcPoq1QS88Tb+zF6GO1v0g/YlIo58MdEQF7rGn8GFpoBzraLWl0h8/HsFCNb6/A/cZBDZaUmTI/6CGUyllSD6WqtROop5ezuvQPicLkvsDLjiGiz0FLy2oL9TC39kqPrvYm0CF0w3sbRYPQU+qGmQT3DlOJPaj2Hyrif94HT4PhL2ZqOX4HM5n9tDliQRD7Q3Zv5BCn5Qt0GSpKxzHqtq9XJ03d8jrvC/UIKvu7/kw== Received: from PH8PR22CA0005.namprd22.prod.outlook.com (2603:10b6:510:2d1::18) by DM6PR12MB4122.namprd12.prod.outlook.com (2603:10b6:5:214::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19; Tue, 24 Oct 2023 17:52:29 +0000 Received: from DS1PEPF0001709B.namprd05.prod.outlook.com (2603:10b6:510:2d1:cafe::2b) by PH8PR22CA0005.outlook.office365.com (2603:10b6:510:2d1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.36 via Frontend Transport; Tue, 24 Oct 2023 17:52:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF0001709B.mail.protection.outlook.com (10.167.18.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.18 via Frontend Transport; Tue, 24 Oct 2023 17:52:28 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:16 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 24 Oct 2023 10:52:13 -0700 From: Alexander Kozyrev To: CC: , , , , , Subject: [PATCH v3 6/7] net/mlx5/hws: remove csum check from L3 ok check Date: Tue, 24 Oct 2023 20:51:31 +0300 Message-ID: <20231024175132.1435553-7-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20231024175132.1435553-1-akozyrev@nvidia.com> References: <20230828182251.3917624-1-akozyrev@nvidia.com> <20231024175132.1435553-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001709B:EE_|DM6PR12MB4122:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a678d53-7eeb-4ffd-de80-08dbd4b9fd24 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aLY+rEqKx/PEtwBloEX/iLbFUUDA+ZtfqWatq9fYz7nTI+TFs4ApG97YyZhvFqamIcCk4zXpiDktfHg2Le6hMil/52pkRvx1LYQBSPjzLT0oUh9wztdlmhlHSKhIUdafDAMSK9yauHX8K2hueLIlWNs/zulMqgrfXopQY0dAJAAgeCMu7pbuFsjt5Gt5hobiRpaAhJ5mTYGJQQiwHfbpeMEbPBAd+At81DMV6enTwS4x144BUggl80Afb6NWm2So1dNVX/6d7AxSnsodCdXhAQFIUrBVHNGtivqSj2EYUZZShmTm8njwRsoNt6GV5AwVA6VYUtVzuD8FOJv1iyHaiG3mJoB1AXCLWNlHb7SP0JLdmD23apIjNMs6/xscixTrA61dYDvGv6L6BG5FcH4ext18Of1CJgC3IZYKt8nSrAuhJpHlw8q9rHp+K8OAdCPb6nU2iiTB1fANxH6wlbQmcJGefpvBg+aB6WMwnWKE4GendR+ba9NM/daJD0XCx51AqPIfSPEBKsEjVfpzSOziR14b24NQkKLLrCxK7OqieYXVTRJb2W6QIS1MTEVfg9vmn8Opa/2aJ4+J3DOM5DLf5ZdIMAoaSGzxco0V8hQstMsuI7Gc7hD9GnlHpJPIET6rABubu72ELn/9CCM3xCO6qtbdARUbflj8fDO5XgpjbfP3PgI2CSxaWz4jLbISV2KdODxZUaNlYL70KqUx5DPrMxpS0mcdbkSLghkbbImN2Sf+bRWjeJs8ClZecXfTLiyK X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(136003)(39860400002)(376002)(346002)(396003)(230922051799003)(82310400011)(451199024)(1800799009)(186009)(64100799003)(46966006)(40470700004)(36840700001)(36860700001)(2906002)(47076005)(5660300002)(83380400001)(41300700001)(82740400003)(7636003)(356005)(426003)(336012)(16526019)(1076003)(107886003)(26005)(40480700001)(40460700003)(6666004)(4326008)(2616005)(8676002)(8936002)(70206006)(316002)(54906003)(6916009)(86362001)(36756003)(478600001)(70586007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 17:52:28.2584 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a678d53-7eeb-4ffd-de80-08dbd4b9fd24 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001709B.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4122 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Michael Baum This patch changes the integrity item behavior for HW steering. Old behavior: the "ipv4_csum_ok" checks only IPv4 checksum and "l3_ok" checks everything is ok including IPv4 checksum. New behavior: the "l3_ok" checks everything is ok excluding IPv4 checksum. This change enables matching "l3_ok" in IPv6 packets since for IPv6 packets "ipv4_csum_ok" is always miss. For SW steering the old behavior is kept as same as for L4 ok. Signed-off-by: Michael Baum --- doc/guides/nics/mlx5.rst | 11 ++++++++--- drivers/net/mlx5/hws/mlx5dr_definer.c | 6 ++---- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index c9e74948cc..8d7e0aad7e 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -663,12 +663,13 @@ Limitations - Integrity: - - Integrity offload is enabled starting from **ConnectX-6 Dx**. - Verification bits provided by the hardware are ``l3_ok``, ``ipv4_csum_ok``, ``l4_ok``, ``l4_csum_ok``. - ``level`` value 0 references outer headers. - Negative integrity item verification is not supported. - - Multiple integrity items not supported in a single flow rule. - - Flow rule items supplied by application must explicitly specify network headers referred by integrity item. + - With SW steering (``dv_flow_en=1``) + - Integrity offload is enabled starting from **ConnectX-6 Dx**. + - Multiple integrity items not supported in a single flow rule. + - Flow rule items supplied by application must explicitly specify network headers referred by integrity item. For example, if integrity item mask sets ``l4_ok`` or ``l4_csum_ok`` bits, reference to L4 network header, TCP or UDP, must be in the rule pattern as well:: @@ -676,6 +677,10 @@ Limitations flow create 0 ingress pattern integrity level is 0 value mask l4_ok value spec l4_ok / eth / ipv4 proto is udp / end … + - With HW steering (``dv_flow_en=2``) + - The ``l3_ok`` field represents all L3 checks, but nothing about whether IPv4 checksum ok. + - The ``l4_ok`` field represents all L4 checks including L4 checksum ok. + - Connection tracking: - Cannot co-exist with ASO meter, ASO age action in a single flow rule. diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 0e1035c6bd..c752896ca7 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -380,10 +380,8 @@ mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc, uint32_t ok1_bits = 0; if (v->l3_ok) - ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_L3_OK) | - BIT(MLX5DR_DEFINER_OKS1_SECOND_IPV4_CSUM_OK) : - BIT(MLX5DR_DEFINER_OKS1_FIRST_L3_OK) | - BIT(MLX5DR_DEFINER_OKS1_FIRST_IPV4_CSUM_OK); + ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_L3_OK) : + BIT(MLX5DR_DEFINER_OKS1_FIRST_L3_OK); if (v->ipv4_csum_ok) ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_IPV4_CSUM_OK) :