From patchwork Wed Oct 25 20:39:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 133315 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48B2D431FE; Wed, 25 Oct 2023 22:39:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AC2B402E1; Wed, 25 Oct 2023 22:39:54 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2060.outbound.protection.outlook.com [40.107.223.60]) by mails.dpdk.org (Postfix) with ESMTP id CD9FD402C5 for ; Wed, 25 Oct 2023 22:39:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F6v4dEKOkyuy1sU3h0CdmuIbUlG3br8sFVMUXGTlkH3SoU1zJGYTGtwJ2cIH8/H4pFfsxLASJpkLI+eeC5o0KPBcgiEFSaV5sxx2aUtIJkrr3K0pz1sRqo13cTz7k60TljDQPea1HiYIwsUuxDCH6gAk4iUfsCRjqPOv1c7nllQ3aODF5xtmk9WRHQZ0QytylJdOkAHNmQ4B1EfRTEr7Z8WRs3vGgfl9ZP0WKo+2FdSyF69foI3CqtIUgqIJsG8T0fYJ/oqlP9U0ZLJd64PWofFcE/FyC4XYomkYZQn6QHV+gsUX3ysIgx2gCxKt0Nlb+z71fP74Bz8lL3Iobs28lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gWr4EZymqIYOb8uKqC4gULqQom4S8ktQpI8VZ8maT5o=; b=lVEe1fejHlKoZAMhzLjDAKN/dqiZs7ygFl3+q6YQ7Jl+uooUnrSW5yRwR130tXDgJhStVCvQrsr6FvfxoPDYuHBEAwr5EC3NPNatGiQNdHvS2N8w7lJFbMpVxfR/wxJcM0hj5iNOJ+4cPzGJjgkQRBSwMrouOLe6R94QY4VBli+mAShsvk5ifX1EIaVuT6tvHvVHxJznGpPjH3JN3FtV9Bq3THVzpa0sGmMbhyxacy/gFTRpPsIR8z08r5kdS4Ut+UVtOtF/AB+yA6+p+SoqEVopaXOBRuNx118d9Umzv9NXwToHV7/UbPXgeWAQgnnH+JIiWLZUP8oUOCcUtKCINg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gWr4EZymqIYOb8uKqC4gULqQom4S8ktQpI8VZ8maT5o=; b=lzjNdRbFzMQpCRj7X+WtqKGBtIdeHAjzGIe1Wh1BKTaSVPKMm33hfZhBRYVR9rLuMYN90KI4nafmHt7CuGY453D6rwcjJc6uYt/wWKte9+J91Cqn5ejD/htR7XV+dSYjkm7xNjDRemLweUVuIxZhqqwt8aROj0zjlKEJnqM6t4snh1cs5NCdp2KJQo+mDlesUgQERux0VX5B9GDBDcc9k6OUvE6WwQ8misj8zobSHqw6ESGtpUE+RiQlLP5hzBjAYyRCx6XPEP5mWvb5YAr5wmBMxOi+w3DYZJjSdQxq7deDXsC+dvTz+GtObPU2aUs6khTsJ/vRBJsj6A5RjEZM7A== Received: from MW3PR06CA0024.namprd06.prod.outlook.com (2603:10b6:303:2a::29) by DS0PR12MB8413.namprd12.prod.outlook.com (2603:10b6:8:f9::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Wed, 25 Oct 2023 20:39:51 +0000 Received: from MWH0EPF000971E6.namprd02.prod.outlook.com (2603:10b6:303:2a:cafe::d7) by MW3PR06CA0024.outlook.office365.com (2603:10b6:303:2a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.34 via Frontend Transport; Wed, 25 Oct 2023 20:39:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by MWH0EPF000971E6.mail.protection.outlook.com (10.167.243.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Wed, 25 Oct 2023 20:39:50 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 25 Oct 2023 13:39:38 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 25 Oct 2023 13:39:35 -0700 From: Alexander Kozyrev To: CC: , , , , , , Subject: [PATCH] net/mlx5/hws: remove csum check from L3 ok check Date: Wed, 25 Oct 2023 23:39:18 +0300 Message-ID: <20231025203918.1603751-1-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000971E6:EE_|DS0PR12MB8413:EE_ X-MS-Office365-Filtering-Correlation-Id: 42d70ff3-4cee-4008-c304-08dbd59a8963 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jVJBre3SZtPbOhsqIbl2iDjcs93+V3xnxdW9qEE8MozS2A5enU/1W53GQXu2vwud+JFSqfxM7+Dv/fn9R9hlknvyaucSJKo+68b7E4IInArBqbWKtFnU8xB4V5mlw/jLYwQzq2+XwC2vqFo0lkDPq/4vSmCwvi1Wr/FZF3i3AfWLgEHgr5h3cCe/zTH6LgiMarUUNyY728rME300O+e8tveTIFcppSNZ3Obe+dj5XJzwYkpkIbt+k8Xqv3WHTME0ImqBZZpoX2MVNnpUK9Lk/sBhxo4Kf9RBCmomWxQjiiXl8scGfBDc2Q1q4fLaAerE042pG7NI87DcH0Y4S6ZcFh+QKG7vAqmQRW+JFWtktfZ1xkW32aD/VZCq+vAK4ftpd9u3zRgI5e+cisI+n4azznlPwt2P19qCai1FqPQ9y3JNuFKErn4KgCGFddjR1ahJXgl+QybIcj6mY67J0WiAhg3LHZq3YsLRrgHIftH4UKOMplQW/2ZBGOTMCDnwud5eIWFnu7krkSxB20/3r0+HAVUYrk7Mp/Wg49hGYLXfPd64z+RGqZ/YYWiuYW2V1KDvEznnA9SBeJfqJnE5Q9rjxrkJvftG9tsmdg+V2/lG9Oh5S1KA5CrupShr8OK+tnW21+kIAr8ms8k19Sni9iZnAbI8pt6jluGvotLQ4GjtsjI2Pq32TL4LsMlmoNkhgPmuNO02FQHDF7NbYMX2dNV8qFjN+YYHFrWp57xJMzKFYViT+tZg/KU4GpJ6Ob4Vi0b6 X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(136003)(376002)(396003)(346002)(39860400002)(230922051799003)(82310400011)(451199024)(64100799003)(1800799009)(186009)(36840700001)(40470700004)(46966006)(40480700001)(40460700003)(316002)(83380400001)(36860700001)(47076005)(4326008)(86362001)(36756003)(356005)(8936002)(8676002)(7636003)(2906002)(5660300002)(41300700001)(478600001)(6666004)(70206006)(70586007)(54906003)(82740400003)(1076003)(107886003)(26005)(336012)(426003)(16526019)(2616005)(6916009); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 20:39:50.8659 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 42d70ff3-4cee-4008-c304-08dbd59a8963 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000971E6.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8413 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Michael Baum This patch changes the integrity item behavior for HW steering. Old behavior: the "ipv4_csum_ok" checks only IPv4 checksum and "l3_ok" checks everything is ok including IPv4 checksum. New behavior: the "l3_ok" checks everything is ok excluding IPv4 checksum. This change enables matching "l3_ok" in IPv6 packets since for IPv6 packets "ipv4_csum_ok" is always miss. For SW steering the old behavior is kept as same as for L4 ok. Signed-off-by: Michael Baum Acked-by: Ori Kam --- doc/guides/nics/mlx5.rst | 11 ++++++++--- drivers/net/mlx5/hws/mlx5dr_definer.c | 6 ++---- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 7086f3d1d4..4d9c8f53cf 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -648,12 +648,13 @@ Limitations - Integrity: - - Integrity offload is enabled starting from **ConnectX-6 Dx**. - Verification bits provided by the hardware are ``l3_ok``, ``ipv4_csum_ok``, ``l4_ok``, ``l4_csum_ok``. - ``level`` value 0 references outer headers. - Negative integrity item verification is not supported. - - Multiple integrity items not supported in a single flow rule. - - Flow rule items supplied by application must explicitly specify network headers referred by integrity item. + - With SW steering (``dv_flow_en=1``) + - Integrity offload is enabled starting from **ConnectX-6 Dx**. + - Multiple integrity items not supported in a single flow rule. + - Flow rule items supplied by application must explicitly specify network headers referred by integrity item. For example, if integrity item mask sets ``l4_ok`` or ``l4_csum_ok`` bits, reference to L4 network header, TCP or UDP, must be in the rule pattern as well:: @@ -661,6 +662,10 @@ Limitations flow create 0 ingress pattern integrity level is 0 value mask l4_ok value spec l4_ok / eth / ipv4 proto is udp / end … + - With HW steering (``dv_flow_en=2``) + - The ``l3_ok`` field represents all L3 checks, but nothing about whether IPv4 checksum ok. + - The ``l4_ok`` field represents all L4 checks including L4 checksum ok. + - Connection tracking: - Cannot co-exist with ASO meter, ASO age action in a single flow rule. diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 95b5d4b70e..6b63ccedac 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -287,10 +287,8 @@ mlx5dr_definer_integrity_set(struct mlx5dr_definer_fc *fc, uint32_t ok1_bits = 0; if (v->l3_ok) - ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_L3_OK) | - BIT(MLX5DR_DEFINER_OKS1_SECOND_IPV4_CSUM_OK) : - BIT(MLX5DR_DEFINER_OKS1_FIRST_L3_OK) | - BIT(MLX5DR_DEFINER_OKS1_FIRST_IPV4_CSUM_OK); + ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_L3_OK) : + BIT(MLX5DR_DEFINER_OKS1_FIRST_L3_OK); if (v->ipv4_csum_ok) ok1_bits |= inner ? BIT(MLX5DR_DEFINER_OKS1_SECOND_IPV4_CSUM_OK) :