[2/7] compress/nitrox: add nitrox compressdev driver

Message ID 20231027145534.16803-3-rnagadheeraj@marvell.com (mailing list archive)
State Superseded
Delegated to: akhil goyal
Headers
Series add Nitrox compress device support |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Nagadheeraj Rottela Oct. 27, 2023, 2:55 p.m. UTC
  Introduce nitrox compressdev driver which implements below operations
- dev_configure
- dev_close
- dev_infos_get
- private_xform_create
- private_xform_free

Signed-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
---
 MAINTAINERS                                  |   7 +
 doc/guides/compressdevs/features/nitrox.ini  |  13 +
 doc/guides/compressdevs/index.rst            |   1 +
 doc/guides/compressdevs/nitrox.rst           |  50 +++
 drivers/common/nitrox/meson.build            |  19 +-
 drivers/common/nitrox/nitrox_device.c        |  36 +-
 drivers/common/nitrox/nitrox_device.h        |   3 +
 drivers/compress/nitrox/nitrox_comp.c        | 405 +++++++++++++++++++
 drivers/compress/nitrox/nitrox_comp.h        |  13 +
 drivers/compress/nitrox/nitrox_comp_reqmgr.c |   3 +
 10 files changed, 543 insertions(+), 7 deletions(-)
 create mode 100644 doc/guides/compressdevs/features/nitrox.ini
 create mode 100644 doc/guides/compressdevs/nitrox.rst
 create mode 100644 drivers/compress/nitrox/nitrox_comp.c
 create mode 100644 drivers/compress/nitrox/nitrox_comp.h
 create mode 100644 drivers/compress/nitrox/nitrox_comp_reqmgr.c
  

Comments

Akhil Goyal Feb. 8, 2024, 7:59 a.m. UTC | #1
> Introduce nitrox compressdev driver which implements below operations
> - dev_configure
> - dev_close
> - dev_infos_get
> - private_xform_create
> - private_xform_free
> 
> Signed-off-by: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
> ---
>  MAINTAINERS                                  |   7 +
>  doc/guides/compressdevs/features/nitrox.ini  |  13 +
>  doc/guides/compressdevs/index.rst            |   1 +
>  doc/guides/compressdevs/nitrox.rst           |  50 +++
>  drivers/common/nitrox/meson.build            |  19 +-
>  drivers/common/nitrox/nitrox_device.c        |  36 +-
>  drivers/common/nitrox/nitrox_device.h        |   3 +
>  drivers/compress/nitrox/nitrox_comp.c        | 405 +++++++++++++++++++
>  drivers/compress/nitrox/nitrox_comp.h        |  13 +
>  drivers/compress/nitrox/nitrox_comp_reqmgr.c |   3 +
>  10 files changed, 543 insertions(+), 7 deletions(-)
>  create mode 100644 doc/guides/compressdevs/features/nitrox.ini
>  create mode 100644 doc/guides/compressdevs/nitrox.rst
>  create mode 100644 drivers/compress/nitrox/nitrox_comp.c
>  create mode 100644 drivers/compress/nitrox/nitrox_comp.h
>  create mode 100644 drivers/compress/nitrox/nitrox_comp_reqmgr.c
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7e8272c0e0..be566d6c6c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1217,6 +1217,13 @@ F: drivers/compress/isal/
>  F: doc/guides/compressdevs/isal.rst
>  F: doc/guides/compressdevs/features/isal.ini
> 
> +Marvell Nitrox
> +M: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
> +F: drivers/compress/nitrox/
> +F: drivers/common/nitrox/
> +F: doc/guides/compressdevs/nitrox.rst
> +F: doc/guides/compressdevs/features/nitrox.ini
> +
>  NVIDIA mlx5
>  M: Matan Azrad <matan@nvidia.com>
>  F: drivers/compress/mlx5/
> diff --git a/doc/guides/compressdevs/features/nitrox.ini
> b/doc/guides/compressdevs/features/nitrox.ini
> new file mode 100644
> index 0000000000..f045e891c4
> --- /dev/null
> +++ b/doc/guides/compressdevs/features/nitrox.ini
> @@ -0,0 +1,13 @@
> +;
> +; Refer to default.ini for the full list of available PMD features.
> +;
> +; Supported features of 'nitrox' compression driver.
> +;
> +[Features]
> +HW Accelerated = Y
> +Deflate        = Y
> +Fixed          = Y
> +Dynamic        = Y
> +OOP SGL In SGL Out  = Y
> +OOP SGL In LB  Out  = Y
> +OOP LB  In SGL Out  = Y
> diff --git a/doc/guides/compressdevs/index.rst
> b/doc/guides/compressdevs/index.rst
> index 54a3ef4273..849f211688 100644
> --- a/doc/guides/compressdevs/index.rst
> +++ b/doc/guides/compressdevs/index.rst
> @@ -12,6 +12,7 @@ Compression Device Drivers
>      overview
>      isal
>      mlx5
> +    nitrox
>      octeontx
>      qat_comp
>      zlib
> diff --git a/doc/guides/compressdevs/nitrox.rst
> b/doc/guides/compressdevs/nitrox.rst
> new file mode 100644
> index 0000000000..a1989b400d
> --- /dev/null
> +++ b/doc/guides/compressdevs/nitrox.rst
> @@ -0,0 +1,50 @@
> +..  SPDX-License-Identifier: BSD-3-Clause
> +    Copyright(C) 2023 Marvell International Ltd.
> +
> +Marvell NITROX Compression Poll Mode Driver
> +===========================================
> +
> +The Nitrox compression poll mode driver provides support for offloading
> +compression and decompression operations to the NITROX V processor.
> +Detailed information about the NITROX V processor can be obtained here:
> +
> +* https://www.marvell.com/security-solutions/nitrox-security-
> processors/nitrox-v/
> +
> +Features
> +--------
> +
> +NITROX V compression PMD has support for:
> +
> +Compression/Decompression algorithm:
> +
> +* DEFLATE
> +
> +Huffman code type:
> +
> +* FIXED
> +* DYNAMIC
> +
> +Window size support:
> +
> +* Min - 2 bytes
> +* Max - 32KB
> +
> +Checksum generation:
> +
> +* CRC32, Adler
> +
> +Limitations
> +-----------
> +
> +* Compressdev level 0, no compression, is not supported.
> +
> +Initialization
> +--------------
> +
> +Nitrox compression PMD depends on Nitrox kernel PF driver being installed on
> +the platform. Nitrox PF driver is required to create VF devices which will
> +be used by the PMD. Each VF device can enable one compressdev PMD.
> +
> +Nitrox kernel PF driver is available as part of CNN55XX-Driver SDK. The SDK
> +and it's installation instructions can be obtained from:
> +`Marvell Customer Portal
> <https://www.marvell.com/support/extranets.html>`_.
> diff --git a/drivers/common/nitrox/meson.build
> b/drivers/common/nitrox/meson.build
> index eb989a04e5..9334b077ad 100644
> --- a/drivers/common/nitrox/meson.build
> +++ b/drivers/common/nitrox/meson.build
> @@ -1,5 +1,5 @@
>  # SPDX-License-Identifier: BSD-3-Clause
> -# Copyright(C) 2019 Marvell International Ltd.
> +# Copyright(C) 2019-2023 Marvell International Ltd.
> 
>  if not is_linux
>      build = false
> @@ -9,12 +9,18 @@ endif
>  nitrox_crypto = true
>  nitrox_crypto_path = 'crypto/nitrox'
>  nitrox_crypto_relpath = '../../' + nitrox_crypto_path
> +nitrox_compress = true
> +nitrox_compress_path = 'compress/nitrox'
> +nitrox_compress_relpath = '../../' + nitrox_compress_path
> 
>  if disable_drivers.contains(nitrox_crypto_path)
>      nitrox_crypto = false
>  endif
> +if disable_drivers.contains(nitrox_compress_path)
> +    nitrox_compress = false
> +endif
> 
> -deps += ['bus_pci', 'cryptodev']
> +deps += ['bus_pci', 'cryptodev', 'compressdev']
>  sources = files(
>          'nitrox_device.c',
>          'nitrox_hal.c',
> @@ -23,6 +29,7 @@ sources = files(
>  )
>  includes += include_directories(
>          nitrox_crypto_relpath,
> +        nitrox_compress_relpath,
>  )
> 
>  if nitrox_crypto
> @@ -33,3 +40,11 @@ if nitrox_crypto
>          sources += files(join_paths(nitrox_crypto_relpath, f))
>      endforeach
>  endif
> +
> +if nitrox_compress
> +    foreach f: ['nitrox_comp.c',
> +		'nitrox_comp_reqmgr.c',
> +        ]
> +        sources += files(join_paths(nitrox_compress_relpath, f))
> +    endforeach
> +endif
> diff --git a/drivers/common/nitrox/nitrox_device.c
> b/drivers/common/nitrox/nitrox_device.c
> index b2f638ec8a..6ac25d5ccc 100644
> --- a/drivers/common/nitrox/nitrox_device.c
> +++ b/drivers/common/nitrox/nitrox_device.c
> @@ -7,6 +7,7 @@
>  #include "nitrox_device.h"
>  #include "nitrox_hal.h"
>  #include "nitrox_sym.h"
> +#include "nitrox_comp.h"
> 
>  #define PCI_VENDOR_ID_CAVIUM	0x177d
>  #define NITROX_V_PCI_VF_DEV_ID	0x13
> @@ -67,7 +68,7 @@ nitrox_pci_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
>  		struct rte_pci_device *pdev)
>  {
>  	struct nitrox_device *ndev;
> -	int err;
> +	int err = -1;
> 
>  	/* Nitrox CSR space */
>  	if (!pdev->mem_resource[0].addr)
> @@ -79,12 +80,19 @@ nitrox_pci_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
> 
>  	ndev_init(ndev, pdev);
>  	err = nitrox_sym_pmd_create(ndev);
> -	if (err) {
> -		ndev_release(ndev);
> -		return err;
> -	}
> +	if (err)
> +		goto err_exit;
> +
> +	err = nitrox_comp_pmd_create(ndev);
> +	if (err)
> +		goto err_exit;
> 
>  	return 0;
> +err_exit:
> +	nitrox_comp_pmd_destroy(ndev);
> +	nitrox_sym_pmd_destroy(ndev);
> +	ndev_release(ndev);
> +	return err;

There should be separate gotos for above errors.

>  }
> 
>  static int
> @@ -101,6 +109,10 @@ nitrox_pci_remove(struct rte_pci_device *pdev)
>  	if (err)
>  		return err;
> 
> +	err = nitrox_comp_pmd_destroy(ndev);
> +	if (err)
> +		return err;
> +
>  	ndev_release(ndev);
>  	return 0;
>  }
> @@ -134,5 +146,19 @@ nitrox_sym_pmd_destroy(struct nitrox_device *ndev)
>  	return 0;
>  }
> 
> +__rte_weak int
> +nitrox_comp_pmd_create(struct nitrox_device *ndev)
> +{
> +	RTE_SET_USED(ndev);
> +	return 0;
> +}
> +
> +__rte_weak int
> +nitrox_comp_pmd_destroy(struct nitrox_device *ndev)
> +{
> +	RTE_SET_USED(ndev);
> +	return 0;
> +}
> +
>  RTE_PMD_REGISTER_PCI(nitrox, nitrox_pmd);
>  RTE_PMD_REGISTER_PCI_TABLE(nitrox, pci_id_nitrox_map);
> diff --git a/drivers/common/nitrox/nitrox_device.h
> b/drivers/common/nitrox/nitrox_device.h
> index 1ff7c59b63..df6b358e14 100644
> --- a/drivers/common/nitrox/nitrox_device.h
> +++ b/drivers/common/nitrox/nitrox_device.h
> @@ -9,13 +9,16 @@
>  #include <rte_cryptodev.h>
> 
>  struct nitrox_sym_device;
> +struct nitrox_comp_device;
> 
>  struct nitrox_device {
>  	TAILQ_ENTRY(nitrox_device) next;
>  	struct rte_pci_device *pdev;
>  	uint8_t *bar_addr;
>  	struct nitrox_sym_device *sym_dev;
> +	struct nitrox_comp_device *comp_dev;
>  	struct rte_device rte_sym_dev;
> +	struct rte_device rte_comp_dev;
>  	uint16_t nr_queues;
>  };
> 
> diff --git a/drivers/compress/nitrox/nitrox_comp.c
> b/drivers/compress/nitrox/nitrox_comp.c
> new file mode 100644
> index 0000000000..d9bd04db06
> --- /dev/null
> +++ b/drivers/compress/nitrox/nitrox_comp.c
> @@ -0,0 +1,405 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(C) 2023 Marvell International Ltd.
> + */
> +
> +#include <rte_compressdev_pmd.h>
> +#include <rte_comp.h>
> +#include <rte_errno.h>
> +
> +#include "nitrox_comp.h"
> +#include "nitrox_device.h"
> +#include "nitrox_logs.h"
> +
> +#define COMPRESSDEV_NAME_NITROX_PMD	compress_nitrox
> +#define NITROX_DECOMP_CTX_SIZE 2048
> +#define NITROX_CONSTANTS_MAX_SEARCH_DEPTH 31744
> +#define NITROX_COMP_LEVEL_LOWEST_START 1
> +#define NITROX_COMP_LEVEL_LOWEST_END 2
> +#define NITROX_COMP_LEVEL_LOWER_START 3
> +#define NITROX_COMP_LEVEL_LOWER_END 4
> +#define NITROX_COMP_LEVEL_MEDIUM_START 5
> +#define NITROX_COMP_LEVEL_MEDIUM_END 6
> +#define NITROX_COMP_LEVEL_BEST_START 7
> +#define NITROX_COMP_LEVEL_BEST_END 9
> +
> +struct nitrox_comp_device {
> +	struct rte_compressdev *cdev;
> +	struct nitrox_device *ndev;
> +	struct rte_mempool *xform_pool;
> +};
> +
> +enum nitrox_comp_op {
> +	NITROX_COMP_OP_DECOMPRESS,
> +	NITROX_COMP_OP_COMPRESS,
> +};
> +
> +enum nitrox_comp_algo {
> +	NITROX_COMP_ALGO_DEFLATE_DEFAULT,
> +	NITROX_COMP_ALGO_DEFLATE_DYNHUFF,
> +	NITROX_COMP_ALGO_DEFLATE_FIXEDHUFF,
> +	NITROX_COMP_ALGO_LZS,
> +};
> +
> +enum nitrox_comp_level {
> +	NITROX_COMP_LEVEL_BEST,
> +	NITROX_COMP_LEVEL_MEDIUM,
> +	NITROX_COMP_LEVEL_LOWER,
> +	NITROX_COMP_LEVEL_LOWEST,
> +};
> +
> +enum nitrox_chksum_type {
> +	NITROX_CHKSUM_TYPE_CRC32,
> +	NITROX_CHKSUM_TYPE_ADLER32,
> +	NITROX_CHKSUM_TYPE_NONE,
> +};
> +
> +struct nitrox_comp_xform {
> +	enum nitrox_comp_op op;
> +	enum nitrox_comp_algo algo;
> +	enum nitrox_comp_level level;
> +	enum nitrox_chksum_type chksum_type;
> +};
> +
> +struct nitrox_comp_stream {
> +	struct nitrox_comp_xform xform;
> +	int window_size;
> +	char context[NITROX_DECOMP_CTX_SIZE] __rte_aligned(8);
> +	char history_window[NITROX_CONSTANTS_MAX_SEARCH_DEPTH]
> __rte_aligned(8);
> +};

Can we define these structures and enums in a header file.

> +
> +static const char nitrox_comp_drv_name[] =
> RTE_STR(COMPRESSDEV_NAME_NITROX_PMD);
> +static const struct rte_driver nitrox_rte_comp_drv = {
> +	.name = nitrox_comp_drv_name,
> +	.alias = nitrox_comp_drv_name
> +};
> +
> +static const struct rte_compressdev_capabilities
> +				nitrox_comp_pmd_capabilities[] = {
> +	{	.algo = RTE_COMP_ALGO_DEFLATE,
> +		.comp_feature_flags = RTE_COMP_FF_HUFFMAN_FIXED |
> +				      RTE_COMP_FF_HUFFMAN_DYNAMIC |
> +				      RTE_COMP_FF_CRC32_CHECKSUM |
> +				      RTE_COMP_FF_ADLER32_CHECKSUM |
> +				      RTE_COMP_FF_SHAREABLE_PRIV_XFORM |
> +				      RTE_COMP_FF_OOP_SGL_IN_SGL_OUT |
> +				      RTE_COMP_FF_OOP_SGL_IN_LB_OUT |
> +				      RTE_COMP_FF_OOP_LB_IN_SGL_OUT,

I cannot see all these feature flags being updated in nitrox.ini file.

> +		.window_size = {
> +			.min = 1,
> +			.max = 15,
> +			.increment = 1
> +		},
> +	},
> +	RTE_COMP_END_OF_CAPABILITIES_LIST()
> +};
> +
> +static int nitrox_comp_dev_configure(struct rte_compressdev *dev,
> +				     struct rte_compressdev_config *config)
> +{
> +	struct nitrox_comp_device *comp_dev = dev->data->dev_private;
> +	struct nitrox_device *ndev = comp_dev->ndev;
> +
> +	if (config->nb_queue_pairs > ndev->nr_queues) {
> +		NITROX_LOG(ERR, "Invalid queue pairs, max supported %d\n",
> +			   ndev->nr_queues);
> +		return -EINVAL;
> +	}
> +
> +	if (config->max_nb_priv_xforms) {
> +		char xform_name[RTE_MEMPOOL_NAMESIZE];
> +
> +		snprintf(xform_name, sizeof(xform_name), "%s_xform",
> +			 dev->data->name);
> +		comp_dev->xform_pool = rte_mempool_create(xform_name,
> +				config->max_nb_priv_xforms,
> +				sizeof(struct nitrox_comp_xform),
> +				0, 0, NULL, NULL, NULL, NULL,
> +				config->socket_id, 0);
> +		if (comp_dev->xform_pool == NULL) {
> +			NITROX_LOG(ERR, "Failed to create xform pool, err
> %d\n",
> +				   rte_errno);
> +			return -rte_errno;
> +		}
> +	}
> +
> +	return 0;
> +}
> +
> +static int nitrox_comp_dev_start(struct rte_compressdev *dev)
> +{
> +	RTE_SET_USED(dev);
> +	return 0;
> +}
> +
> +static void nitrox_comp_dev_stop(struct rte_compressdev *dev)
> +{
> +	RTE_SET_USED(dev);
> +}
> +
> +static int nitrox_comp_dev_close(struct rte_compressdev *dev)
> +{
> +	struct nitrox_comp_device *comp_dev = dev->data->dev_private;
> +
> +	rte_mempool_free(comp_dev->xform_pool);
> +	comp_dev->xform_pool = NULL;
> +	return 0;
> +}
> +
> +static void nitrox_comp_stats_get(struct rte_compressdev *dev,
> +				  struct rte_compressdev_stats *stats)
> +{
> +	RTE_SET_USED(dev);
> +	RTE_SET_USED(stats);
> +}
> +
> +static void nitrox_comp_stats_reset(struct rte_compressdev *dev)
> +{
> +	RTE_SET_USED(dev);
> +}
> +
> +static void nitrox_comp_dev_info_get(struct rte_compressdev *dev,
> +				     struct rte_compressdev_info *info)
> +{
> +	struct nitrox_comp_device *comp_dev = dev->data->dev_private;
> +	struct nitrox_device *ndev = comp_dev->ndev;
> +
> +	if (!info)
> +		return;
> +
> +	info->max_nb_queue_pairs = ndev->nr_queues;
> +	info->feature_flags = dev->feature_flags;
> +	info->capabilities = nitrox_comp_pmd_capabilities;
> +}
> +
> +static int nitrox_comp_queue_pair_setup(struct rte_compressdev *dev,
> +					uint16_t qp_id,
> +					uint32_t max_inflight_ops, int
> socket_id)
> +{
> +	RTE_SET_USED(dev);
> +	RTE_SET_USED(qp_id);
> +	RTE_SET_USED(max_inflight_ops);
> +	RTE_SET_USED(socket_id);
> +	return -1;
> +}
> +
> +static int nitrox_comp_queue_pair_release(struct rte_compressdev *dev,
> +					  uint16_t qp_id)
> +{
> +	RTE_SET_USED(dev);
> +	RTE_SET_USED(qp_id);
> +	return 0;
> +}
> +
> +static int nitrox_comp_private_xform_create(struct rte_compressdev *dev,
> +					    const struct rte_comp_xform *xform,
> +					    void **private_xform)
> +{
> +	struct nitrox_comp_device *comp_dev = dev->data->dev_private;
> +	struct nitrox_comp_xform *nitrox_xform;
> +	enum rte_comp_checksum_type chksum_type;
> +	int ret;
> +
> +	if (unlikely(comp_dev->xform_pool == NULL)) {
> +		NITROX_LOG(ERR, "private xform pool not yet created\n");
> +		return -EINVAL;
> +	}
> +
> +	if (rte_mempool_get(comp_dev->xform_pool, private_xform)) {
> +		NITROX_LOG(ERR, "Failed to get from private xform pool\n");
> +		return -ENOMEM;
> +	}
> +
> +	nitrox_xform = (struct nitrox_comp_xform *)*private_xform;
> +	if (xform->type == RTE_COMP_COMPRESS) {
> +		enum rte_comp_huffman algo;
> +		int level;
> +
> +		nitrox_xform->op = NITROX_COMP_OP_COMPRESS;
> +		if (xform->compress.algo != RTE_COMP_ALGO_DEFLATE) {
> +			NITROX_LOG(ERR, "Only deflate is supported\n");
> +			ret = -ENOTSUP;
> +			goto err_exit;
> +		}
> +
> +		algo = xform->compress.deflate.huffman;
> +		if (algo == RTE_COMP_HUFFMAN_DEFAULT)
> +			nitrox_xform->algo =
> NITROX_COMP_ALGO_DEFLATE_DEFAULT;
> +		else if (algo == RTE_COMP_HUFFMAN_FIXED)
> +			nitrox_xform->algo =
> NITROX_COMP_ALGO_DEFLATE_FIXEDHUFF;
> +		else if (algo == RTE_COMP_HUFFMAN_DYNAMIC)
> +			nitrox_xform->algo =
> NITROX_COMP_ALGO_DEFLATE_DYNHUFF;
> +		else {
> +			NITROX_LOG(ERR, "Invalid deflate algorithm %d\n",
> algo);
> +			ret = -EINVAL;
> +			goto err_exit;
> +		}
> +
> +		level = xform->compress.level;
> +		if (level >= NITROX_COMP_LEVEL_LOWEST_START &&
> +		    level <= NITROX_COMP_LEVEL_LOWEST_END) {
> +			nitrox_xform->level = NITROX_COMP_LEVEL_LOWEST;
> +		} else if (level >= NITROX_COMP_LEVEL_LOWER_START &&
> +			   level <= NITROX_COMP_LEVEL_LOWER_END) {
> +			nitrox_xform->level = NITROX_COMP_LEVEL_LOWER;
> +		} else if (level >= NITROX_COMP_LEVEL_MEDIUM_START &&
> +			   level <= NITROX_COMP_LEVEL_MEDIUM_END) {
> +			nitrox_xform->level = NITROX_COMP_LEVEL_MEDIUM;
> +		} else if (level >= NITROX_COMP_LEVEL_BEST_START &&
> +			   level <= NITROX_COMP_LEVEL_BEST_END) {
> +			nitrox_xform->level = NITROX_COMP_LEVEL_BEST;
> +		} else {
> +			NITROX_LOG(ERR, "Unsupported compression level
> %d\n",
> +				   xform->compress.level);
> +			ret = -ENOTSUP;
> +			goto err_exit;
> +		}
> +
> +		chksum_type = xform->compress.chksum;
> +	} else if (xform->type == RTE_COMP_DECOMPRESS) {
> +		nitrox_xform->op = NITROX_COMP_OP_DECOMPRESS;
> +		if (xform->decompress.algo != RTE_COMP_ALGO_DEFLATE) {
> +			NITROX_LOG(ERR, "Only deflate is supported\n");
> +			ret = -ENOTSUP;
> +			goto err_exit;
> +		}
> +
> +		nitrox_xform->algo = NITROX_COMP_ALGO_DEFLATE_DEFAULT;
> +		nitrox_xform->level = NITROX_COMP_LEVEL_BEST;
> +		chksum_type = xform->decompress.chksum;
> +	} else {
> +		ret = -EINVAL;
> +		goto err_exit;
> +	}
> +
> +	if (chksum_type == RTE_COMP_CHECKSUM_NONE)
> +		nitrox_xform->chksum_type = NITROX_CHKSUM_TYPE_NONE;
> +	else if (chksum_type == RTE_COMP_CHECKSUM_CRC32)
> +		nitrox_xform->chksum_type = NITROX_CHKSUM_TYPE_CRC32;
> +	else if (chksum_type == RTE_COMP_CHECKSUM_ADLER32)
> +		nitrox_xform->chksum_type =
> NITROX_CHKSUM_TYPE_ADLER32;
> +	else {
> +		NITROX_LOG(ERR, "Unsupported checksum type %d\n",
> +			   chksum_type);
> +		ret = -ENOTSUP;
> +		goto err_exit;
> +	}
> +
> +	return 0;
> +err_exit:
> +	memset(nitrox_xform, 0, sizeof(*nitrox_xform));
> +	rte_mempool_put(comp_dev->xform_pool, nitrox_xform);
> +	return ret;
> +}
> +
> +static int nitrox_comp_private_xform_free(struct rte_compressdev *dev,
> +					  void *private_xform)
> +{
> +	struct nitrox_comp_xform *nitrox_xform = private_xform;
> +	struct rte_mempool *mp = rte_mempool_from_obj(nitrox_xform);
> +
> +	RTE_SET_USED(dev);
> +	if (nitrox_xform == NULL)
> +		return -EINVAL;
> +
> +	memset(nitrox_xform, 0, sizeof(*nitrox_xform));
> +	mp = rte_mempool_from_obj(nitrox_xform);
> +	rte_mempool_put(mp, nitrox_xform);
> +	return 0;
> +}
> +
> +static uint16_t nitrox_comp_dev_enq_burst(void *qp,
> +					  struct rte_comp_op **ops,
> +					  uint16_t nb_ops)
> +{
> +	RTE_SET_USED(qp);
> +	RTE_SET_USED(ops);
> +	RTE_SET_USED(nb_ops);
> +	return 0;
> +}
> +
> +static uint16_t nitrox_comp_dev_deq_burst(void *qp,
> +					  struct rte_comp_op **ops,
> +					  uint16_t nb_ops)
> +{
> +	RTE_SET_USED(qp);
> +	RTE_SET_USED(ops);
> +	RTE_SET_USED(nb_ops);
> +	return 0;
> +}
> +
> +static struct rte_compressdev_ops nitrox_compressdev_ops = {
> +		.dev_configure		= nitrox_comp_dev_configure,
> +		.dev_start		= nitrox_comp_dev_start,
> +		.dev_stop		= nitrox_comp_dev_stop,
> +		.dev_close		= nitrox_comp_dev_close,
> +
> +		.stats_get		= nitrox_comp_stats_get,
> +		.stats_reset		= nitrox_comp_stats_reset,
> +
> +		.dev_infos_get		= nitrox_comp_dev_info_get,
> +
> +		.queue_pair_setup	= nitrox_comp_queue_pair_setup,
> +		.queue_pair_release	= nitrox_comp_queue_pair_release,
> +
> +		.private_xform_create	= nitrox_comp_private_xform_create,
> +		.private_xform_free	= nitrox_comp_private_xform_free,
> +		.stream_create		= NULL,
> +		.stream_free		= NULL
> +};
> +
> +int
> +nitrox_comp_pmd_create(struct nitrox_device *ndev)
> +{
> +	char name[RTE_COMPRESSDEV_NAME_MAX_LEN];
> +	struct rte_compressdev_pmd_init_params init_params = {
> +			.name = "",
> +			.socket_id = ndev->pdev->device.numa_node,
> +	};
> +	struct rte_compressdev *cdev;
> +
> +	rte_pci_device_name(&ndev->pdev->addr, name, sizeof(name));
> +	snprintf(name + strlen(name),
> +		 RTE_COMPRESSDEV_NAME_MAX_LEN - strlen(name),
> +		 "_n5comp");
> +	ndev->rte_comp_dev.driver = &nitrox_rte_comp_drv;
> +	ndev->rte_comp_dev.numa_node = ndev->pdev->device.numa_node;
> +	ndev->rte_comp_dev.devargs = NULL;
> +	cdev = rte_compressdev_pmd_create(name,
> +					  &ndev->rte_comp_dev,
> +					  sizeof(struct nitrox_comp_device),
> +					  &init_params);
> +	if (!cdev) {
> +		NITROX_LOG(ERR, "Cryptodev '%s' creation failed\n", name);
> +		return -ENODEV;
> +	}
> +
> +	cdev->dev_ops = &nitrox_compressdev_ops;
> +	cdev->enqueue_burst = nitrox_comp_dev_enq_burst;
> +	cdev->dequeue_burst = nitrox_comp_dev_deq_burst;
> +	cdev->feature_flags = RTE_COMPDEV_FF_HW_ACCELERATED;
> +
> +	ndev->comp_dev = cdev->data->dev_private;
> +	ndev->comp_dev->cdev = cdev;
> +	ndev->comp_dev->ndev = ndev;
> +	ndev->comp_dev->xform_pool = NULL;
> +	NITROX_LOG(DEBUG, "Created compressdev '%s', dev_id %d\n",
> +		   cdev->data->name, cdev->data->dev_id);
> +	return 0;
> +}
> +
> +int
> +nitrox_comp_pmd_destroy(struct nitrox_device *ndev)
> +{
> +	int err;
> +
> +	if (ndev->comp_dev == NULL)
> +		return 0;
> +
> +	err = rte_compressdev_pmd_destroy(ndev->comp_dev->cdev);
> +	if (err)
> +		return err;
> +
> +	ndev->comp_dev = NULL;
> +	return 0;
> +}
> +
> diff --git a/drivers/compress/nitrox/nitrox_comp.h
> b/drivers/compress/nitrox/nitrox_comp.h
> new file mode 100644
> index 0000000000..536d314ca9
> --- /dev/null
> +++ b/drivers/compress/nitrox/nitrox_comp.h
> @@ -0,0 +1,13 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(C) 2023 Marvell International Ltd.
> + */
> +
> +#ifndef _NITROX_COMP_H_
> +#define _NITROX_COMP_H_
> +
> +struct nitrox_device;
> +
> +int nitrox_comp_pmd_create(struct nitrox_device *ndev);
> +int nitrox_comp_pmd_destroy(struct nitrox_device *ndev);
> +
> +#endif /* _NITROX_COMP_H_ */
> diff --git a/drivers/compress/nitrox/nitrox_comp_reqmgr.c
> b/drivers/compress/nitrox/nitrox_comp_reqmgr.c
> new file mode 100644
> index 0000000000..5ff64fabce
> --- /dev/null
> +++ b/drivers/compress/nitrox/nitrox_comp_reqmgr.c
> @@ -0,0 +1,3 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(C) 2023 Marvell International Ltd.
> + */

Move this in the patch where content is added to this file.
We should not have empty files with only copyright.
  

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 7e8272c0e0..be566d6c6c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1217,6 +1217,13 @@  F: drivers/compress/isal/
 F: doc/guides/compressdevs/isal.rst
 F: doc/guides/compressdevs/features/isal.ini
 
+Marvell Nitrox
+M: Nagadheeraj Rottela <rnagadheeraj@marvell.com>
+F: drivers/compress/nitrox/
+F: drivers/common/nitrox/
+F: doc/guides/compressdevs/nitrox.rst
+F: doc/guides/compressdevs/features/nitrox.ini
+
 NVIDIA mlx5
 M: Matan Azrad <matan@nvidia.com>
 F: drivers/compress/mlx5/
diff --git a/doc/guides/compressdevs/features/nitrox.ini b/doc/guides/compressdevs/features/nitrox.ini
new file mode 100644
index 0000000000..f045e891c4
--- /dev/null
+++ b/doc/guides/compressdevs/features/nitrox.ini
@@ -0,0 +1,13 @@ 
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+; Supported features of 'nitrox' compression driver.
+;
+[Features]
+HW Accelerated = Y
+Deflate        = Y
+Fixed          = Y
+Dynamic        = Y
+OOP SGL In SGL Out  = Y
+OOP SGL In LB  Out  = Y
+OOP LB  In SGL Out  = Y
diff --git a/doc/guides/compressdevs/index.rst b/doc/guides/compressdevs/index.rst
index 54a3ef4273..849f211688 100644
--- a/doc/guides/compressdevs/index.rst
+++ b/doc/guides/compressdevs/index.rst
@@ -12,6 +12,7 @@  Compression Device Drivers
     overview
     isal
     mlx5
+    nitrox
     octeontx
     qat_comp
     zlib
diff --git a/doc/guides/compressdevs/nitrox.rst b/doc/guides/compressdevs/nitrox.rst
new file mode 100644
index 0000000000..a1989b400d
--- /dev/null
+++ b/doc/guides/compressdevs/nitrox.rst
@@ -0,0 +1,50 @@ 
+..  SPDX-License-Identifier: BSD-3-Clause
+    Copyright(C) 2023 Marvell International Ltd.
+
+Marvell NITROX Compression Poll Mode Driver
+===========================================
+
+The Nitrox compression poll mode driver provides support for offloading
+compression and decompression operations to the NITROX V processor.
+Detailed information about the NITROX V processor can be obtained here:
+
+* https://www.marvell.com/security-solutions/nitrox-security-processors/nitrox-v/
+
+Features
+--------
+
+NITROX V compression PMD has support for:
+
+Compression/Decompression algorithm:
+
+* DEFLATE
+
+Huffman code type:
+
+* FIXED
+* DYNAMIC
+
+Window size support:
+
+* Min - 2 bytes
+* Max - 32KB
+
+Checksum generation:
+
+* CRC32, Adler
+
+Limitations
+-----------
+
+* Compressdev level 0, no compression, is not supported.
+
+Initialization
+--------------
+
+Nitrox compression PMD depends on Nitrox kernel PF driver being installed on
+the platform. Nitrox PF driver is required to create VF devices which will
+be used by the PMD. Each VF device can enable one compressdev PMD.
+
+Nitrox kernel PF driver is available as part of CNN55XX-Driver SDK. The SDK
+and it's installation instructions can be obtained from:
+`Marvell Customer Portal <https://www.marvell.com/support/extranets.html>`_.
diff --git a/drivers/common/nitrox/meson.build b/drivers/common/nitrox/meson.build
index eb989a04e5..9334b077ad 100644
--- a/drivers/common/nitrox/meson.build
+++ b/drivers/common/nitrox/meson.build
@@ -1,5 +1,5 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
-# Copyright(C) 2019 Marvell International Ltd.
+# Copyright(C) 2019-2023 Marvell International Ltd.
 
 if not is_linux
     build = false
@@ -9,12 +9,18 @@  endif
 nitrox_crypto = true
 nitrox_crypto_path = 'crypto/nitrox'
 nitrox_crypto_relpath = '../../' + nitrox_crypto_path
+nitrox_compress = true
+nitrox_compress_path = 'compress/nitrox'
+nitrox_compress_relpath = '../../' + nitrox_compress_path
 
 if disable_drivers.contains(nitrox_crypto_path)
     nitrox_crypto = false
 endif
+if disable_drivers.contains(nitrox_compress_path)
+    nitrox_compress = false
+endif
 
-deps += ['bus_pci', 'cryptodev']
+deps += ['bus_pci', 'cryptodev', 'compressdev']
 sources = files(
         'nitrox_device.c',
         'nitrox_hal.c',
@@ -23,6 +29,7 @@  sources = files(
 )
 includes += include_directories(
         nitrox_crypto_relpath,
+        nitrox_compress_relpath,
 )
 
 if nitrox_crypto
@@ -33,3 +40,11 @@  if nitrox_crypto
         sources += files(join_paths(nitrox_crypto_relpath, f))
     endforeach
 endif
+
+if nitrox_compress
+    foreach f: ['nitrox_comp.c',
+		'nitrox_comp_reqmgr.c',
+        ]
+        sources += files(join_paths(nitrox_compress_relpath, f))
+    endforeach
+endif
diff --git a/drivers/common/nitrox/nitrox_device.c b/drivers/common/nitrox/nitrox_device.c
index b2f638ec8a..6ac25d5ccc 100644
--- a/drivers/common/nitrox/nitrox_device.c
+++ b/drivers/common/nitrox/nitrox_device.c
@@ -7,6 +7,7 @@ 
 #include "nitrox_device.h"
 #include "nitrox_hal.h"
 #include "nitrox_sym.h"
+#include "nitrox_comp.h"
 
 #define PCI_VENDOR_ID_CAVIUM	0x177d
 #define NITROX_V_PCI_VF_DEV_ID	0x13
@@ -67,7 +68,7 @@  nitrox_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 		struct rte_pci_device *pdev)
 {
 	struct nitrox_device *ndev;
-	int err;
+	int err = -1;
 
 	/* Nitrox CSR space */
 	if (!pdev->mem_resource[0].addr)
@@ -79,12 +80,19 @@  nitrox_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 
 	ndev_init(ndev, pdev);
 	err = nitrox_sym_pmd_create(ndev);
-	if (err) {
-		ndev_release(ndev);
-		return err;
-	}
+	if (err)
+		goto err_exit;
+
+	err = nitrox_comp_pmd_create(ndev);
+	if (err)
+		goto err_exit;
 
 	return 0;
+err_exit:
+	nitrox_comp_pmd_destroy(ndev);
+	nitrox_sym_pmd_destroy(ndev);
+	ndev_release(ndev);
+	return err;
 }
 
 static int
@@ -101,6 +109,10 @@  nitrox_pci_remove(struct rte_pci_device *pdev)
 	if (err)
 		return err;
 
+	err = nitrox_comp_pmd_destroy(ndev);
+	if (err)
+		return err;
+
 	ndev_release(ndev);
 	return 0;
 }
@@ -134,5 +146,19 @@  nitrox_sym_pmd_destroy(struct nitrox_device *ndev)
 	return 0;
 }
 
+__rte_weak int
+nitrox_comp_pmd_create(struct nitrox_device *ndev)
+{
+	RTE_SET_USED(ndev);
+	return 0;
+}
+
+__rte_weak int
+nitrox_comp_pmd_destroy(struct nitrox_device *ndev)
+{
+	RTE_SET_USED(ndev);
+	return 0;
+}
+
 RTE_PMD_REGISTER_PCI(nitrox, nitrox_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(nitrox, pci_id_nitrox_map);
diff --git a/drivers/common/nitrox/nitrox_device.h b/drivers/common/nitrox/nitrox_device.h
index 1ff7c59b63..df6b358e14 100644
--- a/drivers/common/nitrox/nitrox_device.h
+++ b/drivers/common/nitrox/nitrox_device.h
@@ -9,13 +9,16 @@ 
 #include <rte_cryptodev.h>
 
 struct nitrox_sym_device;
+struct nitrox_comp_device;
 
 struct nitrox_device {
 	TAILQ_ENTRY(nitrox_device) next;
 	struct rte_pci_device *pdev;
 	uint8_t *bar_addr;
 	struct nitrox_sym_device *sym_dev;
+	struct nitrox_comp_device *comp_dev;
 	struct rte_device rte_sym_dev;
+	struct rte_device rte_comp_dev;
 	uint16_t nr_queues;
 };
 
diff --git a/drivers/compress/nitrox/nitrox_comp.c b/drivers/compress/nitrox/nitrox_comp.c
new file mode 100644
index 0000000000..d9bd04db06
--- /dev/null
+++ b/drivers/compress/nitrox/nitrox_comp.c
@@ -0,0 +1,405 @@ 
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Marvell International Ltd.
+ */
+
+#include <rte_compressdev_pmd.h>
+#include <rte_comp.h>
+#include <rte_errno.h>
+
+#include "nitrox_comp.h"
+#include "nitrox_device.h"
+#include "nitrox_logs.h"
+
+#define COMPRESSDEV_NAME_NITROX_PMD	compress_nitrox
+#define NITROX_DECOMP_CTX_SIZE 2048
+#define NITROX_CONSTANTS_MAX_SEARCH_DEPTH 31744
+#define NITROX_COMP_LEVEL_LOWEST_START 1
+#define NITROX_COMP_LEVEL_LOWEST_END 2
+#define NITROX_COMP_LEVEL_LOWER_START 3
+#define NITROX_COMP_LEVEL_LOWER_END 4
+#define NITROX_COMP_LEVEL_MEDIUM_START 5
+#define NITROX_COMP_LEVEL_MEDIUM_END 6
+#define NITROX_COMP_LEVEL_BEST_START 7
+#define NITROX_COMP_LEVEL_BEST_END 9
+
+struct nitrox_comp_device {
+	struct rte_compressdev *cdev;
+	struct nitrox_device *ndev;
+	struct rte_mempool *xform_pool;
+};
+
+enum nitrox_comp_op {
+	NITROX_COMP_OP_DECOMPRESS,
+	NITROX_COMP_OP_COMPRESS,
+};
+
+enum nitrox_comp_algo {
+	NITROX_COMP_ALGO_DEFLATE_DEFAULT,
+	NITROX_COMP_ALGO_DEFLATE_DYNHUFF,
+	NITROX_COMP_ALGO_DEFLATE_FIXEDHUFF,
+	NITROX_COMP_ALGO_LZS,
+};
+
+enum nitrox_comp_level {
+	NITROX_COMP_LEVEL_BEST,
+	NITROX_COMP_LEVEL_MEDIUM,
+	NITROX_COMP_LEVEL_LOWER,
+	NITROX_COMP_LEVEL_LOWEST,
+};
+
+enum nitrox_chksum_type {
+	NITROX_CHKSUM_TYPE_CRC32,
+	NITROX_CHKSUM_TYPE_ADLER32,
+	NITROX_CHKSUM_TYPE_NONE,
+};
+
+struct nitrox_comp_xform {
+	enum nitrox_comp_op op;
+	enum nitrox_comp_algo algo;
+	enum nitrox_comp_level level;
+	enum nitrox_chksum_type chksum_type;
+};
+
+struct nitrox_comp_stream {
+	struct nitrox_comp_xform xform;
+	int window_size;
+	char context[NITROX_DECOMP_CTX_SIZE] __rte_aligned(8);
+	char history_window[NITROX_CONSTANTS_MAX_SEARCH_DEPTH] __rte_aligned(8);
+};
+
+static const char nitrox_comp_drv_name[] = RTE_STR(COMPRESSDEV_NAME_NITROX_PMD);
+static const struct rte_driver nitrox_rte_comp_drv = {
+	.name = nitrox_comp_drv_name,
+	.alias = nitrox_comp_drv_name
+};
+
+static const struct rte_compressdev_capabilities
+				nitrox_comp_pmd_capabilities[] = {
+	{	.algo = RTE_COMP_ALGO_DEFLATE,
+		.comp_feature_flags = RTE_COMP_FF_HUFFMAN_FIXED |
+				      RTE_COMP_FF_HUFFMAN_DYNAMIC |
+				      RTE_COMP_FF_CRC32_CHECKSUM |
+				      RTE_COMP_FF_ADLER32_CHECKSUM |
+				      RTE_COMP_FF_SHAREABLE_PRIV_XFORM |
+				      RTE_COMP_FF_OOP_SGL_IN_SGL_OUT |
+				      RTE_COMP_FF_OOP_SGL_IN_LB_OUT |
+				      RTE_COMP_FF_OOP_LB_IN_SGL_OUT,
+		.window_size = {
+			.min = 1,
+			.max = 15,
+			.increment = 1
+		},
+	},
+	RTE_COMP_END_OF_CAPABILITIES_LIST()
+};
+
+static int nitrox_comp_dev_configure(struct rte_compressdev *dev,
+				     struct rte_compressdev_config *config)
+{
+	struct nitrox_comp_device *comp_dev = dev->data->dev_private;
+	struct nitrox_device *ndev = comp_dev->ndev;
+
+	if (config->nb_queue_pairs > ndev->nr_queues) {
+		NITROX_LOG(ERR, "Invalid queue pairs, max supported %d\n",
+			   ndev->nr_queues);
+		return -EINVAL;
+	}
+
+	if (config->max_nb_priv_xforms) {
+		char xform_name[RTE_MEMPOOL_NAMESIZE];
+
+		snprintf(xform_name, sizeof(xform_name), "%s_xform",
+			 dev->data->name);
+		comp_dev->xform_pool = rte_mempool_create(xform_name,
+				config->max_nb_priv_xforms,
+				sizeof(struct nitrox_comp_xform),
+				0, 0, NULL, NULL, NULL, NULL,
+				config->socket_id, 0);
+		if (comp_dev->xform_pool == NULL) {
+			NITROX_LOG(ERR, "Failed to create xform pool, err %d\n",
+				   rte_errno);
+			return -rte_errno;
+		}
+	}
+
+	return 0;
+}
+
+static int nitrox_comp_dev_start(struct rte_compressdev *dev)
+{
+	RTE_SET_USED(dev);
+	return 0;
+}
+
+static void nitrox_comp_dev_stop(struct rte_compressdev *dev)
+{
+	RTE_SET_USED(dev);
+}
+
+static int nitrox_comp_dev_close(struct rte_compressdev *dev)
+{
+	struct nitrox_comp_device *comp_dev = dev->data->dev_private;
+
+	rte_mempool_free(comp_dev->xform_pool);
+	comp_dev->xform_pool = NULL;
+	return 0;
+}
+
+static void nitrox_comp_stats_get(struct rte_compressdev *dev,
+				  struct rte_compressdev_stats *stats)
+{
+	RTE_SET_USED(dev);
+	RTE_SET_USED(stats);
+}
+
+static void nitrox_comp_stats_reset(struct rte_compressdev *dev)
+{
+	RTE_SET_USED(dev);
+}
+
+static void nitrox_comp_dev_info_get(struct rte_compressdev *dev,
+				     struct rte_compressdev_info *info)
+{
+	struct nitrox_comp_device *comp_dev = dev->data->dev_private;
+	struct nitrox_device *ndev = comp_dev->ndev;
+
+	if (!info)
+		return;
+
+	info->max_nb_queue_pairs = ndev->nr_queues;
+	info->feature_flags = dev->feature_flags;
+	info->capabilities = nitrox_comp_pmd_capabilities;
+}
+
+static int nitrox_comp_queue_pair_setup(struct rte_compressdev *dev,
+					uint16_t qp_id,
+					uint32_t max_inflight_ops, int socket_id)
+{
+	RTE_SET_USED(dev);
+	RTE_SET_USED(qp_id);
+	RTE_SET_USED(max_inflight_ops);
+	RTE_SET_USED(socket_id);
+	return -1;
+}
+
+static int nitrox_comp_queue_pair_release(struct rte_compressdev *dev,
+					  uint16_t qp_id)
+{
+	RTE_SET_USED(dev);
+	RTE_SET_USED(qp_id);
+	return 0;
+}
+
+static int nitrox_comp_private_xform_create(struct rte_compressdev *dev,
+					    const struct rte_comp_xform *xform,
+					    void **private_xform)
+{
+	struct nitrox_comp_device *comp_dev = dev->data->dev_private;
+	struct nitrox_comp_xform *nitrox_xform;
+	enum rte_comp_checksum_type chksum_type;
+	int ret;
+
+	if (unlikely(comp_dev->xform_pool == NULL)) {
+		NITROX_LOG(ERR, "private xform pool not yet created\n");
+		return -EINVAL;
+	}
+
+	if (rte_mempool_get(comp_dev->xform_pool, private_xform)) {
+		NITROX_LOG(ERR, "Failed to get from private xform pool\n");
+		return -ENOMEM;
+	}
+
+	nitrox_xform = (struct nitrox_comp_xform *)*private_xform;
+	if (xform->type == RTE_COMP_COMPRESS) {
+		enum rte_comp_huffman algo;
+		int level;
+
+		nitrox_xform->op = NITROX_COMP_OP_COMPRESS;
+		if (xform->compress.algo != RTE_COMP_ALGO_DEFLATE) {
+			NITROX_LOG(ERR, "Only deflate is supported\n");
+			ret = -ENOTSUP;
+			goto err_exit;
+		}
+
+		algo = xform->compress.deflate.huffman;
+		if (algo == RTE_COMP_HUFFMAN_DEFAULT)
+			nitrox_xform->algo = NITROX_COMP_ALGO_DEFLATE_DEFAULT;
+		else if (algo == RTE_COMP_HUFFMAN_FIXED)
+			nitrox_xform->algo = NITROX_COMP_ALGO_DEFLATE_FIXEDHUFF;
+		else if (algo == RTE_COMP_HUFFMAN_DYNAMIC)
+			nitrox_xform->algo = NITROX_COMP_ALGO_DEFLATE_DYNHUFF;
+		else {
+			NITROX_LOG(ERR, "Invalid deflate algorithm %d\n", algo);
+			ret = -EINVAL;
+			goto err_exit;
+		}
+
+		level = xform->compress.level;
+		if (level >= NITROX_COMP_LEVEL_LOWEST_START &&
+		    level <= NITROX_COMP_LEVEL_LOWEST_END) {
+			nitrox_xform->level = NITROX_COMP_LEVEL_LOWEST;
+		} else if (level >= NITROX_COMP_LEVEL_LOWER_START &&
+			   level <= NITROX_COMP_LEVEL_LOWER_END) {
+			nitrox_xform->level = NITROX_COMP_LEVEL_LOWER;
+		} else if (level >= NITROX_COMP_LEVEL_MEDIUM_START &&
+			   level <= NITROX_COMP_LEVEL_MEDIUM_END) {
+			nitrox_xform->level = NITROX_COMP_LEVEL_MEDIUM;
+		} else if (level >= NITROX_COMP_LEVEL_BEST_START &&
+			   level <= NITROX_COMP_LEVEL_BEST_END) {
+			nitrox_xform->level = NITROX_COMP_LEVEL_BEST;
+		} else {
+			NITROX_LOG(ERR, "Unsupported compression level %d\n",
+				   xform->compress.level);
+			ret = -ENOTSUP;
+			goto err_exit;
+		}
+
+		chksum_type = xform->compress.chksum;
+	} else if (xform->type == RTE_COMP_DECOMPRESS) {
+		nitrox_xform->op = NITROX_COMP_OP_DECOMPRESS;
+		if (xform->decompress.algo != RTE_COMP_ALGO_DEFLATE) {
+			NITROX_LOG(ERR, "Only deflate is supported\n");
+			ret = -ENOTSUP;
+			goto err_exit;
+		}
+
+		nitrox_xform->algo = NITROX_COMP_ALGO_DEFLATE_DEFAULT;
+		nitrox_xform->level = NITROX_COMP_LEVEL_BEST;
+		chksum_type = xform->decompress.chksum;
+	} else {
+		ret = -EINVAL;
+		goto err_exit;
+	}
+
+	if (chksum_type == RTE_COMP_CHECKSUM_NONE)
+		nitrox_xform->chksum_type = NITROX_CHKSUM_TYPE_NONE;
+	else if (chksum_type == RTE_COMP_CHECKSUM_CRC32)
+		nitrox_xform->chksum_type = NITROX_CHKSUM_TYPE_CRC32;
+	else if (chksum_type == RTE_COMP_CHECKSUM_ADLER32)
+		nitrox_xform->chksum_type = NITROX_CHKSUM_TYPE_ADLER32;
+	else {
+		NITROX_LOG(ERR, "Unsupported checksum type %d\n",
+			   chksum_type);
+		ret = -ENOTSUP;
+		goto err_exit;
+	}
+
+	return 0;
+err_exit:
+	memset(nitrox_xform, 0, sizeof(*nitrox_xform));
+	rte_mempool_put(comp_dev->xform_pool, nitrox_xform);
+	return ret;
+}
+
+static int nitrox_comp_private_xform_free(struct rte_compressdev *dev,
+					  void *private_xform)
+{
+	struct nitrox_comp_xform *nitrox_xform = private_xform;
+	struct rte_mempool *mp = rte_mempool_from_obj(nitrox_xform);
+
+	RTE_SET_USED(dev);
+	if (nitrox_xform == NULL)
+		return -EINVAL;
+
+	memset(nitrox_xform, 0, sizeof(*nitrox_xform));
+	mp = rte_mempool_from_obj(nitrox_xform);
+	rte_mempool_put(mp, nitrox_xform);
+	return 0;
+}
+
+static uint16_t nitrox_comp_dev_enq_burst(void *qp,
+					  struct rte_comp_op **ops,
+					  uint16_t nb_ops)
+{
+	RTE_SET_USED(qp);
+	RTE_SET_USED(ops);
+	RTE_SET_USED(nb_ops);
+	return 0;
+}
+
+static uint16_t nitrox_comp_dev_deq_burst(void *qp,
+					  struct rte_comp_op **ops,
+					  uint16_t nb_ops)
+{
+	RTE_SET_USED(qp);
+	RTE_SET_USED(ops);
+	RTE_SET_USED(nb_ops);
+	return 0;
+}
+
+static struct rte_compressdev_ops nitrox_compressdev_ops = {
+		.dev_configure		= nitrox_comp_dev_configure,
+		.dev_start		= nitrox_comp_dev_start,
+		.dev_stop		= nitrox_comp_dev_stop,
+		.dev_close		= nitrox_comp_dev_close,
+
+		.stats_get		= nitrox_comp_stats_get,
+		.stats_reset		= nitrox_comp_stats_reset,
+
+		.dev_infos_get		= nitrox_comp_dev_info_get,
+
+		.queue_pair_setup	= nitrox_comp_queue_pair_setup,
+		.queue_pair_release	= nitrox_comp_queue_pair_release,
+
+		.private_xform_create	= nitrox_comp_private_xform_create,
+		.private_xform_free	= nitrox_comp_private_xform_free,
+		.stream_create		= NULL,
+		.stream_free		= NULL
+};
+
+int
+nitrox_comp_pmd_create(struct nitrox_device *ndev)
+{
+	char name[RTE_COMPRESSDEV_NAME_MAX_LEN];
+	struct rte_compressdev_pmd_init_params init_params = {
+			.name = "",
+			.socket_id = ndev->pdev->device.numa_node,
+	};
+	struct rte_compressdev *cdev;
+
+	rte_pci_device_name(&ndev->pdev->addr, name, sizeof(name));
+	snprintf(name + strlen(name),
+		 RTE_COMPRESSDEV_NAME_MAX_LEN - strlen(name),
+		 "_n5comp");
+	ndev->rte_comp_dev.driver = &nitrox_rte_comp_drv;
+	ndev->rte_comp_dev.numa_node = ndev->pdev->device.numa_node;
+	ndev->rte_comp_dev.devargs = NULL;
+	cdev = rte_compressdev_pmd_create(name,
+					  &ndev->rte_comp_dev,
+					  sizeof(struct nitrox_comp_device),
+					  &init_params);
+	if (!cdev) {
+		NITROX_LOG(ERR, "Cryptodev '%s' creation failed\n", name);
+		return -ENODEV;
+	}
+
+	cdev->dev_ops = &nitrox_compressdev_ops;
+	cdev->enqueue_burst = nitrox_comp_dev_enq_burst;
+	cdev->dequeue_burst = nitrox_comp_dev_deq_burst;
+	cdev->feature_flags = RTE_COMPDEV_FF_HW_ACCELERATED;
+
+	ndev->comp_dev = cdev->data->dev_private;
+	ndev->comp_dev->cdev = cdev;
+	ndev->comp_dev->ndev = ndev;
+	ndev->comp_dev->xform_pool = NULL;
+	NITROX_LOG(DEBUG, "Created compressdev '%s', dev_id %d\n",
+		   cdev->data->name, cdev->data->dev_id);
+	return 0;
+}
+
+int
+nitrox_comp_pmd_destroy(struct nitrox_device *ndev)
+{
+	int err;
+
+	if (ndev->comp_dev == NULL)
+		return 0;
+
+	err = rte_compressdev_pmd_destroy(ndev->comp_dev->cdev);
+	if (err)
+		return err;
+
+	ndev->comp_dev = NULL;
+	return 0;
+}
+
diff --git a/drivers/compress/nitrox/nitrox_comp.h b/drivers/compress/nitrox/nitrox_comp.h
new file mode 100644
index 0000000000..536d314ca9
--- /dev/null
+++ b/drivers/compress/nitrox/nitrox_comp.h
@@ -0,0 +1,13 @@ 
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Marvell International Ltd.
+ */
+
+#ifndef _NITROX_COMP_H_
+#define _NITROX_COMP_H_
+
+struct nitrox_device;
+
+int nitrox_comp_pmd_create(struct nitrox_device *ndev);
+int nitrox_comp_pmd_destroy(struct nitrox_device *ndev);
+
+#endif /* _NITROX_COMP_H_ */
diff --git a/drivers/compress/nitrox/nitrox_comp_reqmgr.c b/drivers/compress/nitrox/nitrox_comp_reqmgr.c
new file mode 100644
index 0000000000..5ff64fabce
--- /dev/null
+++ b/drivers/compress/nitrox/nitrox_comp_reqmgr.c
@@ -0,0 +1,3 @@ 
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(C) 2023 Marvell International Ltd.
+ */