diff mbox series

[01/30] net/mlx5/hws: Definer, add mlx5dr context to definer_conv_data

Message ID 20231029163202.216450-1-getelson@nvidia.com (mailing list archive)
State Superseded, archived
Delegated to: Raslan Darawsheh
Headers
Series [01/30] net/mlx5/hws: Definer, add mlx5dr context to definer_conv_data |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation warning apply patch failure

Commit Message

Gregory Etelson Oct. 29, 2023, 4:31 p.m. UTC 
  New mlx5dr_context member replaces mlx5dr_cmd_query_caps.
Capabilities structure is a member of mlx5dr_context.

Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Acked-by: Ori Kam <orika@nvidia.com>
---
 drivers/net/mlx5/hws/mlx5dr_definer.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon Nov. 5, 2023, 6:49 p.m. UTC | #1 
The description of this patch does not match the change.
Also the change is going backward, using deprecated fields.
It does not make sense, I'll skip it.


29/10/2023 17:31, Gregory Etelson:
> New mlx5dr_context member replaces mlx5dr_cmd_query_caps.
> Capabilities structure is a member of mlx5dr_context.
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
> ---
>  drivers/net/mlx5/hws/mlx5dr_definer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c
> index 95b5d4b70e..75ba46b966 100644
> --- a/drivers/net/mlx5/hws/mlx5dr_definer.c
> +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c
> @@ -1092,7 +1092,7 @@ mlx5dr_definer_conv_item_gtp(struct mlx5dr_definer_conv_data *cd,
>  		return rte_errno;
>  	}
>  
> -	if (m->hdr.teid) {
> +	if (m->teid) {
>  		if (!(caps->flex_protocols & MLX5_HCA_FLEX_GTPU_TEID_ENABLED)) {
>  			rte_errno = ENOTSUP;
>  			return rte_errno;
> @@ -1118,7 +1118,7 @@ mlx5dr_definer_conv_item_gtp(struct mlx5dr_definer_conv_data *cd,
>  	}
>  
>  
> -	if (m->hdr.msg_type) {
> +	if (m->msg_type) {
>  		if (!(caps->flex_protocols & MLX5_HCA_FLEX_GTPU_DW_0_ENABLED)) {
>  			rte_errno = ENOTSUP;
>  			return rte_errno;
>
Gregory Etelson Nov. 6, 2023, 7:32 a.m. UTC | #2 
On Sun, 5 Nov 2023, Thomas Monjalon wrote:

> External email: Use caution opening links or attachments
>
>
> The description of this patch does not match the change.
> Also the change is going backward, using deprecated fields.
> It does not make sense, I'll skip it.
>
>

Hello Thomas,

Patches in that series were superseded.

Regards,
Gregory
diff mbox series

Patch

diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c
index 95b5d4b70e..75ba46b966 100644
--- a/drivers/net/mlx5/hws/mlx5dr_definer.c
+++ b/drivers/net/mlx5/hws/mlx5dr_definer.c
@@ -1092,7 +1092,7 @@  mlx5dr_definer_conv_item_gtp(struct mlx5dr_definer_conv_data *cd,
 		return rte_errno;
 	}
 
-	if (m->hdr.teid) {
+	if (m->teid) {
 		if (!(caps->flex_protocols & MLX5_HCA_FLEX_GTPU_TEID_ENABLED)) {
 			rte_errno = ENOTSUP;
 			return rte_errno;
@@ -1118,7 +1118,7 @@  mlx5dr_definer_conv_item_gtp(struct mlx5dr_definer_conv_data *cd,
 	}
 
 
-	if (m->hdr.msg_type) {
+	if (m->msg_type) {
 		if (!(caps->flex_protocols & MLX5_HCA_FLEX_GTPU_DW_0_ENABLED)) {
 			rte_errno = ENOTSUP;
 			return rte_errno;