From patchwork Sun Oct 29 18:22:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 133614 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2888343239; Sun, 29 Oct 2023 19:24:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E6ED42D2A; Sun, 29 Oct 2023 19:24:03 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2061.outbound.protection.outlook.com [40.107.93.61]) by mails.dpdk.org (Postfix) with ESMTP id 2F082415D7 for ; Sun, 29 Oct 2023 19:24:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hBCmlgm05Pp+hj+EwYmySAvEsXRBNOJUcL+w/ed2FHerHl68eUl51/v7sogk3LTN+ArSS0yTyEttxkE9DvHT8jNpld4rQYPFe95N2TwWoI+EQBRV9Uwn5zcnTR90au4sutzuxebvDG3Xf+M3x3+wiYyf1Cx4+Bq/aMOzSbVpmAVodGgz9bgpZP/S9qnWQ8qqhqjDpWHqnA2EZK5b4EWtHhIE5NzyUbHy3Q9F9uYsVAes9hpF2DroIFeKUkntckCfRCJBXBPQxq/r0kFZ76+XdNb/LMwSFyv7ayyAPZ/UX3gasIsjZAHrtys4hjjd6pVytjlFv1Ic6nY56Jyqbo4ZQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mh82l4VGSxeZGku9V16j1NW2MsjLhzKRIx/RlmCb+DQ=; b=URJuj2hiDjQiO/2ylymfHC+PmaUGL2sngNW8AhdEvOQNDFaKRSVY0u0F+I9HOCc0UEtAhR2rOwJpmNMULnwUHHd2c+PvWSmxFhCB2R2kBdDjfe7GB1fD9p+rr3rl9r83cVhZjPWh/HZIm9sbJpWlQF+HHgcJPlbUv/A+FuC3N+sJIMqKDHX9rby3lElXhiOUGtQsAxrN0l4WLRNbkjAm2NjF7Xyu2URsZZNRcqw109WUBeWwYYI0dkbMJuM2zuwBM23R4JR+sUapNbCXN3ZKkQxY6oJFZDixKytgWblaf2t2gCeF5FlOJRQ7eSCP4gokiywm+GAJkwg04wWx0ThjKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mh82l4VGSxeZGku9V16j1NW2MsjLhzKRIx/RlmCb+DQ=; b=uSTV/u/iPNZXa5NAaTuLimZlNlkJ57FwTB9TCs86UlGLwnS1rm/S2xwSbt8YZpYMq+NhcsyWm48aHRluUBf6mzGLbMVaMQ5nBBKw1nw06P1cMCl0dd+kjqTjHenpfneGv6GzUc4uXdaUT+K/ZEoG0vZ6g5ZhkS0aHNjhwRZYPvVEjknSVNnsHcjKD1q0Mf9ATcLVuj1ulR0NYji4HidFVfDLuv4FACv8lbiq35I+SJLA6jRtTvlWgWmjK5xEFVjaRdZW2UuhEZpAlaRPEyJcIaMo0qFhpSgHhAWuYdYTc38h+tDyJswKHV+Sp13JmOIlbWiOxZzG5APJJs4evlbwnA== Received: from BN8PR04CA0055.namprd04.prod.outlook.com (2603:10b6:408:d4::29) by CYYPR12MB8921.namprd12.prod.outlook.com (2603:10b6:930:c7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.27; Sun, 29 Oct 2023 18:23:58 +0000 Received: from SN1PEPF0002636E.namprd02.prod.outlook.com (2603:10b6:408:d4:cafe::88) by BN8PR04CA0055.outlook.office365.com (2603:10b6:408:d4::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.26 via Frontend Transport; Sun, 29 Oct 2023 18:23:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SN1PEPF0002636E.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22 via Frontend Transport; Sun, 29 Oct 2023 18:23:58 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 29 Oct 2023 11:23:49 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 29 Oct 2023 11:23:45 -0700 From: Gregory Etelson To: CC: , , , "Ori Kam" , , Matan Azrad , Viacheslav Ovsiienko , Suanming Mou , Alex Vesker Subject: [PATCH 10/13] net/mlx5: fix insert by index Date: Sun, 29 Oct 2023 20:22:57 +0200 Message-ID: <20231029182300.227879-11-getelson@nvidia.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231029182300.227879-1-getelson@nvidia.com> References: <20231029182300.227879-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636E:EE_|CYYPR12MB8921:EE_ X-MS-Office365-Filtering-Correlation-Id: e16c1eb0-49da-4a97-7200-08dbd8ac37d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ws+J4ORF30lVZdlu2Z3Tts2uAwoBPu6iejw6BsuH2+yX7ma5fX/yVcSzNYybU2RAPlLCQi3T2+B3KaVtPkTm5XStQBLTdDPeFjephJq45ik8TjDjgFJVAmoZPwDcGq2vnsaIe9Oc2hKEONry6JWmvKDbveGryRxCOElDVwk3EWkusgRDVx1AHBUILP+3sOgI0840fvN2eWYmvlEomC60LcxSfleEbns1/wn9RsYXAiAUOERA1JgXsDGGQPOT7wDpw6i9wZdomL/CWvY1Ohb3sXHWYFKHsK7cJGxEBe8bOuJps3Quzs0ReyNykVPO5YF2Uuh2p+o6cYsxHdrio4BRvXf+ZEnV2TAQaRiXl8uApvs5crRKFxv/v8ZeGy//ZDqusiqmARsArcnuh4qxCQBJfnfrGvJP6CS+CgBhMsMwEMfXoIEIvE9Y4ba2nQKWeN4+RDsQvx6qAVeEqCe3UHXiyB9IP1oLRT4qzzFZyivi1O8sox4y9t19B90Le1HjcSLY/+w8eJGQRX+n9Nh0Zbpe1NbMYrLBsZVjuDXxUOYMgaBG9pJ7B20D4tCw5CXRKq3PtY+esyJDxp7AyOGtXZ1/6+EEUJwHV2JW9uzMmkCAh9rMjBVsvstdtqSB7U7xW22ftJpAYU3yg3DnT+Dezrnh2AREYMJNdC7h/zqNAFrLAJaieG8Y5pft7L4XvUoHEYlUrvuOiietuJSdcammZfOKPyffNfBM39tKFHVzGtCkBPlCNKuQGWBkxWdLxhEPuymp X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(346002)(136003)(396003)(39860400002)(230922051799003)(64100799003)(82310400011)(1800799009)(186009)(451199024)(40470700004)(36840700001)(46966006)(478600001)(7696005)(6666004)(70206006)(70586007)(336012)(26005)(6286002)(16526019)(426003)(107886003)(1076003)(2616005)(41300700001)(2906002)(8676002)(8936002)(4326008)(316002)(6916009)(54906003)(5660300002)(86362001)(36756003)(36860700001)(83380400001)(47076005)(82740400003)(356005)(7636003)(55016003)(40460700003)(40480700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2023 18:23:58.4164 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e16c1eb0-49da-4a97-7200-08dbd8ac37d2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8921 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Ori Kam Due to mlx5dr internal logic calling the rule_create function must have items structure. This commit create such temp structure. Fixes: fa16fead9a68 ("net/mlx5/hws: support rule update after its creation") Cc: erezsh@nvidia.com Signed-off-by: Ori Kam Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index ea43ebb78b..2148f5a63a 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -2987,6 +2987,7 @@ flow_hw_async_flow_create_by_index(struct rte_eth_dev *dev, void *user_data, struct rte_flow_error *error) { + struct rte_flow_item items[] = {{.type = RTE_FLOW_ITEM_TYPE_END,}}; struct mlx5_priv *priv = dev->data->dev_private; struct mlx5dr_rule_attr rule_attr = { .queue_id = queue, @@ -3050,7 +3051,7 @@ flow_hw_async_flow_create_by_index(struct rte_eth_dev *dev, goto free; } ret = mlx5dr_rule_create(table->matcher, - 0, NULL, action_template_index, rule_acts, + 0, items, action_template_index, rule_acts, &rule_attr, (struct mlx5dr_rule *)flow->rule); if (likely(!ret)) return (struct rte_flow *)flow;