From patchwork Tue Oct 31 12:25:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 133651 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1612543252; Tue, 31 Oct 2023 13:25:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0385240633; Tue, 31 Oct 2023 13:25:50 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2066.outbound.protection.outlook.com [40.107.223.66]) by mails.dpdk.org (Postfix) with ESMTP id 881F8402EB for ; Tue, 31 Oct 2023 13:25:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GYeB6U0CiH7y/wEmJtVpTJdBL43iOuoaE7KqEgT0LqwpdBGC/Qac7hgCLmSvVbhbqmL6EmsHromYd0n4bH4uiapwiQa0ghiEmby9bVWxXcPzUZUyeiFiQ0VaynhUZe7nbKKaKkrl4RIboa3OlcNlWW6lm/Ty+ANKUPd3hbsXEA+ZvtmC1nzNzRB2ePu5SeDksWL8/SEhgU+6rlgtHR/wFsoRxzu0ptFlmiGba3sm2obwoQAb93DfycZeV2m8Chs2aqy8yvIVDDszBtdGg3lHsxo/JOgfsxzMXFDkG4Gne/n1dZR9GrS8tgjOi0VVVSnbjwuypDxFEGaiNUlpR10wjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/m5AA5JYDNYi2ovljwAtSnLt3Yue3paDVWTxH/MYrzE=; b=Z7mbfCSg/NfTz8y2mBoTA9iDuCxqKW4hPz0ZHw+ZTTHXi7xTmYam367/+D5iCQqywsNLZinkVgtC98udm3w3MzTRrFaEigNf6034P9BjvKk6VFC8YlAk4kCpUkgr/yiR9wrFhoL3MVasTUJsYtN7zFqZaHcWofUcZ0YbyfKHMQkVv+5PRK0qbkjmtyINI4iffa5RWQCF5boyOX+7LFPa5njvZdWp8x4QQjSW7Z2lhRgzpjtf4GTtg9I5+GmSqMNfkUnunHBZUXxwY+bsGggMjww174upXVPAABX4syRd5rBUR8/5+z/sjpJ/v1/o6/xYhzrS/LvsCr3ekCYmh5Y6OQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/m5AA5JYDNYi2ovljwAtSnLt3Yue3paDVWTxH/MYrzE=; b=nbMHABiwUPhcyYqVZV/oNhhK1gAYVyiBK/yAC1wQeSIJGPT9y29BZTFmeUTZPLyUQHXqYI9xAYIVIk4zYOTg/cqLdrg9imHnYzRoUxVSBqWo8RwJWZocnmXs7GnFOAZBiKg4LsbV9lu5kLrG4lc8YrQiOVFNrhSZRfLkYGmu2mo/6prfZWd7gJ4vRwS1DkwrXra4CXRZABDPTXb+uztHCWt67FPsbXyZcWTQwsBnCQaE60C+cu1CBSkBmLAC5TaTwxDmfRI1jIuKGykkIKIJX29Ej9eTU7orFSe/Mu8m/DjXncLAnAddMILNuxYxfiXcbMexWGFmHLXCziCcv5Xd7g== Received: from MN2PR14CA0030.namprd14.prod.outlook.com (2603:10b6:208:23e::35) by SJ2PR12MB9238.namprd12.prod.outlook.com (2603:10b6:a03:55d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.29; Tue, 31 Oct 2023 12:25:46 +0000 Received: from BL6PEPF0001AB51.namprd04.prod.outlook.com (2603:10b6:208:23e:cafe::de) by MN2PR14CA0030.outlook.office365.com (2603:10b6:208:23e::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19 via Frontend Transport; Tue, 31 Oct 2023 12:25:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF0001AB51.mail.protection.outlook.com (10.167.242.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Tue, 31 Oct 2023 12:25:45 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 31 Oct 2023 05:25:33 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 31 Oct 2023 05:25:29 -0700 From: Gregory Etelson To: CC: , , , "Itamar Gozlan" , Hamdan Igbaria , Alex Vesker , Matan Azrad , Viacheslav Ovsiienko , Ori Kam , Suanming Mou Subject: [PATCH 01/10] net/mlx5/hws: check the rule status on rule update Date: Tue, 31 Oct 2023 14:25:03 +0200 Message-ID: <20231031122512.434686-2-getelson@nvidia.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231031122512.434686-1-getelson@nvidia.com> References: <20231031122512.434686-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB51:EE_|SJ2PR12MB9238:EE_ X-MS-Office365-Filtering-Correlation-Id: ad189cbb-5b19-46dc-1bba-08dbda0c822c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0YXCciyqfOJNkiolN7b+2WgPgpPomGEsWnEVXuNq3iM+L6EkgD4Ob2BWiHezguuFTd1uEO9ldv+XwPMmn/50vJaJlGEPDB4DjqyG17msL6bD0Q0RwUJjxTtmtitUH4EEFrkdkTeCVlwu+S08+7q7aUI82uq3hBVcZfVbDpY9nDbN42el+aZQMfXBl8zd8/96jD79HqJoh/+BcSCMimpKQ1y+j6L+l5st6q5+v9USIfiiytRwqTpeLVu+aY3j4e1SK4uFTem+HNGLnJVX7muKuJv1TfS5+q1LAVGjOZ0gEqSW1ybH++7FC6nCungS4Yqmcd4gYRwxd1qjuYz8q4hRnvjL9RUgn9j/HVSO6MyAp3GCmG4E4TFXdfyKKkU8oFOJapTeGevGXAVjgmnSPzZdzTxZbbt9vulNZRwns82c9OFtjZfu1+BF5AiThvDnagLROymGo5hbvvi0gce4Kz5AdY3y7GuvV4j0EIbpEio9nwjqfNcZu/ZuMRtupFsKUu6MSEYuHfS5lxa6rQ90zo8Cq/2N+LW9iGr+8D3x64hj7mDrXkqKwW+8+yS3tlFgsM4REvNAMoyLfZPU/hZR46m+016AmzFmcHjZNb0jz0Lr9rh3Za6w7VGBCKLq35dZmvnYr+hakVbMugmP3lHdnReGcOwIrhJZ8WEiwcPQKUet8eP8jb24kuo/GBFzzeKwIsx+SiN9NGYiEk3rGHc3XX0dvBt+LETrrp8kYRyeUgHfI9i+VcnYNz09gKVfTFV6ATIx X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(136003)(376002)(346002)(39860400002)(230922051799003)(1800799009)(82310400011)(64100799003)(186009)(451199024)(36840700001)(40470700004)(46966006)(40460700003)(36756003)(55016003)(40480700001)(426003)(336012)(4326008)(83380400001)(8676002)(8936002)(54906003)(6916009)(70206006)(70586007)(316002)(26005)(6286002)(16526019)(47076005)(5660300002)(2906002)(36860700001)(15650500001)(41300700001)(478600001)(6666004)(7696005)(2616005)(107886003)(1076003)(356005)(7636003)(82740400003)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2023 12:25:45.9417 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad189cbb-5b19-46dc-1bba-08dbda0c822c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB51.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9238 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Itamar Gozlan Only allow rule updates for rules with their status value equal to MLX5DR_RULE_STATUS_CREATED. Otherwise, the rule may be in an unstable stage like deleting and this will result in a faulty unexpected scenario. Signed-off-by: Hamdan Igbaria Reviewed-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/drivers/net/mlx5/hws/mlx5dr_rule.c index 980a99b226..70d5c19e1f 100644 --- a/drivers/net/mlx5/hws/mlx5dr_rule.c +++ b/drivers/net/mlx5/hws/mlx5dr_rule.c @@ -756,6 +756,12 @@ int mlx5dr_rule_action_update(struct mlx5dr_rule *rule_handle, if (mlx5dr_rule_enqueue_precheck(matcher->tbl->ctx, attr)) return -rte_errno; + if (rule_handle->status != MLX5DR_RULE_STATUS_CREATED) { + DR_LOG(ERR, "Current rule status does not allow update"); + rte_errno = EBUSY; + return -rte_errno; + } + ret = mlx5dr_rule_create_hws(rule_handle, attr, 0,