From patchwork Wed Nov 1 02:19:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 133694 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32CD543258; Wed, 1 Nov 2023 03:20:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC9CD4113D; Wed, 1 Nov 2023 03:20:24 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2135.outbound.protection.outlook.com [40.107.237.135]) by mails.dpdk.org (Postfix) with ESMTP id B142B4113D; Wed, 1 Nov 2023 03:20:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G6DKS0G4rimbDGhWAD3vH7oM9uTRk6vHrp1YebuBrGzhRU0Z7oD3sGmWJtuRAGwgxzA8lV9HCQPWAdLtql77AxFbycf+vqt01VLEyz3XdfogA4RuwuS/w6FDCrOyfLE75ht6ru/f6U4pJxcjj/7734KApfmmOqIbDGC1lyywjJfEZE9K2RGmGQ0oVYFGrhxI6f8GxQG6V8lgsFitGo+jmlkk/Bs6OxLg4cIonN2rkK/CzKWEIZ9NFH3iSVOKDcSlV5Mx3qmqKyOCeQJqDwRLqzbpCFuXUI4dg+lgtFwVEZPiYK9tW92rG9mJppcBkYQTeehO+A2yOOi2LGuje44kUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LJ5515J6rP1GfuISMn3Ewwio+QbBXUJTp4UJFmMk5j8=; b=Lkj/jDw+PPOCol0gg/UO5W2/ZSZiU6LNa7pezmvVJgtijYrhHMH6FHc9etHrborj3W/15nKZmouspxQh17/snJJkscypaiAezisqVeuckqEecm7gAXzdUYid0WrSHwu2Rw61FoFSqtooFtPZMBwtM7hU6awS48t2PuMv2tj/JOBvqvthH7tjPjEgPmaeD+7z03vSZ0VD7+b7e8SicLrn9QOvK1RLt7rQSSK78Le3H7iNcJYtzy80R9ocaCXcCELj7Kfceq6BkQ3CtWRj3+36C15oRvIWeS50iy0PqGzjxAbIQB9k+ImpjDjiBdTgVs0nQtbF+8ADj1SSP239c6usow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LJ5515J6rP1GfuISMn3Ewwio+QbBXUJTp4UJFmMk5j8=; b=iQgsNeV5iqOR75wGVbsM3iFR5UrDFeVbnWeuIUJibKxwxPGwU2SQVyCgIoepsYhzCahGplSQQbmWQ6S1KJ2jPvoVAc+OY2qdhtWLzIm6puE7xSfBxfATJ3pihxgiu5RY3sGwM0SoxkRNn+RFkGaImjwXhmxMphHWW5yIk3xowPE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SA1PR13MB5515.namprd13.prod.outlook.com (2603:10b6:806:232::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Wed, 1 Nov 2023 02:20:21 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6933.027; Wed, 1 Nov 2023 02:20:20 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Long Wu , danielx.t.mrzyglod@intel.com, stable@dpdk.org, Chaoyong He , Peng Zhang Subject: [PATCH v2] net/bonding: fix illegal memory accesses Date: Wed, 1 Nov 2023 10:19:59 +0800 Message-Id: <20231101021959.2213518-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20231010062304.205933-3-chaoyong.he@corigine.com> References: <20231010062304.205933-3-chaoyong.he@corigine.com> X-ClientProxiedBy: SJ0PR13CA0013.namprd13.prod.outlook.com (2603:10b6:a03:2c0::18) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SA1PR13MB5515:EE_ X-MS-Office365-Filtering-Correlation-Id: 7571c202-21d6-4961-1bc0-08dbda8118a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N6A9D72xQd2P4hMHsUXCJt6MCVC8rp1BmEkfUbDnAUcU3db/Paw1GSHNY5WFkrBe7WUy7KtAbXz5TQYO4TYnkBgEaaVIb8WRGBKFFAFH0AzUaPOmFDxWVt0tG1emGqYK3f49wDYVgoYLKFVDKJsDH0YaYWy/QEkAKBmfgJJokncvOKAS8W3PPT1AMbklysF921tSpWfmVP8Sf7WuEsL7k6N9rU/nCbfPQT6wD+Sqa223xca5/HvBPbRZMtA46NEeqcsKXeEs60wakp9Vof7KrAGBBOVkE9SAtUyivKrRM6Wdq06KTbvCrCmCijUSvFADuUwPENrbkfKfUtBw2PCHdheBhQd9tHE0eIfgjBVbIbGkf6SoyJA0vwVuttY+QwyRlogWYjYB4saZ4jIo2mRjx73QMuzMvV6zcXbJyUYCPJa5/T/AGXvsmbt2Ziz0zLdudqBsqQqwmpJ3cf8AW8QxW6a8Jdy0dFDKjlrZX2RAi3RPkjercvtdryu3h/YV1OyHqxr0v8ni//MM4UVsC65ClsSVTVB4Z1kgPc/9+O1TaA0s3vOO2m0vlbgO7K1nKjDMX0N/8JaDGSmbIEbzqSO/xoALBDq33+RqudTvLfArnax3V/gLoe31kEYlAxTqVugCFenTg5sLyc3FKR9thrTQGmOwf7BH5cXr+mC1y9Zk3/A= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(396003)(136003)(366004)(376002)(39830400003)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(26005)(6512007)(2616005)(1076003)(107886003)(478600001)(6666004)(6506007)(5660300002)(83380400001)(2906002)(44832011)(41300700001)(6486002)(52116002)(8676002)(8936002)(54906003)(4326008)(6916009)(66476007)(66556008)(66946007)(316002)(38100700002)(38350700005)(86362001)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Mo32egMXt1HJJ9eSBr0jcNNtvjov6jSOlK+tPKmz6i3lGg3qqsSsZOFw6TUrCrCJp62S4KIGFv9r4gEzKWDkyANFqaVn/YKo9dH8/4YkODuqwazY2KLXDXzvl064fGjUNM/xP7VjIFlN9r5E3AR6Ad1EFWQuyod3/vXtFk433mC3DsffGnDJkApIYHhOB5NtcMooxQe6SlAJriA90wX+5KjRK208XBIuSnO1eGjAPyew/8wbfigNx3zjnGSvaJw18XIMkxXtY+R36kP7iqOHRpXCtPc7olzlbCSs4QybyX27nIj4v4xIXdMiuhq8+XAoEcvDQyxthP/bEE4TU1Deau4lrAygS+OGe7L3gX1YRqtM059lp0iuf38tFKgg2B2QHb+VGeUkFafLM4sLvLy4XXeZGNq1RbfFBijsmhvY7E1QFJH2h60JkHr+QLBQu29OFJWS58tVDv3ETJV6KZARFQCxWBMxcXmGAnSDYCCVC2r1X1YD1PdGA+RbvvblFJ80PRBwjo/aifWH9F3vwo+R4i7QNy3moXyL/KJuV6FD3n68kQIcQM1Sh18/5Uin1WTgXw1Q+vjAuiVFI9ITrCaLLAKeYnCcsL5qfnhO8XLOof6HLT2MD+4Ef2Pudie2kYUIZuYf69jUOQ5l/sKJtfZtKR6/mkz0nlqzSAiLCQl61KNoYX9FSTIWzTP9TDktLWO6/IkcDUqzipaL6fOXBpYZW6xqyICxsvhYECn8LiLmBF7iei1s1NfvpsZEzZItn+FpwtuyQJ1a3WShXvFq2XnJ6xORHvFEcv8dfSBCaJcQqd1Vs96A+gh6X9KYtW9keDTlYZy1jdpCcHpNsIBzac1CXJ2g3MVeXLWQ+0dPj0oA05fEr1OLy2R+t6p9t1+kuaDBuXifmcrs9a03tfneKoD1uDPMGV2hAhW6pW87fdY9yxOVAAKyRyAd3IKoEqsaDh71TXSCrr6sMCksuO7MYpVIlBFxKH94ZdQkTcRyZZWlP8YkrDeKoCFE9P/7XnvXCu9ZD0PlZJRWN2YDn6ryjQX5OXGEqZQc/UhOtxhBdZ8iClRXWDMAcTdY9jjb1dgAlTE/jnzXVDDRYRT+U5APH5ucPPFP05+I2SuViGD4CoMZU1E/Rg/y4LSHINR2RkU9VkzJ4QBas8aOGNq5l51+edu/CmcfuIETNIfd+ZAnm8F3OB0VfOcfahjCGb5y/u1fJ+tYcqgFgYH6nuri27RqpJB88xzKmPCuiz3RHqCuxFI8l8+DjHFyXetntHXa1lp4w8TVU8TM6B7sIQ50F2ejKE2aiJ4vJx+PJt+YW4lp+QGQpT8j8ukYBB7BcVDsePUpWa4UlSX62M882Pz1MSwlKap7DTqM+xNN84W+ne8LvHJulkEVTXO/R5rVZj1V2QyOJuKlxGGX3YtBlCLvw9X9NYU6XFRbgmPdEDy9zxztUv2XXEZjtId7+HtuG40PxVxpeVEg1m0RzH+XRD+9UA3XpLTYw7OKEeoTPuhNg3D18WuedYKxm8Ms0DR9+gygnkHkHNSiji+CfDicszz2QHwkKcvor2kGN9D7lva8LpJ4U/D+/Ew5X23tLgLDMujpHdQvk1SkdKOEulFTFH0yFDLvrDAg8A== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7571c202-21d6-4961-1bc0-08dbda8118a2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 02:20:20.5309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BO506lbF4vBe8Qn0Hcv3dk9sw9UXdes4icq6iQYxIa9MnLmRj3JbrgwG6nN4hqT82OVWE7CPXX/W1eAURI6NgxGcF2wwXze+TrM0R3hqEpE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5515 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Long Wu CI found that overrunning array of 32 2-byte elements at element index 65535 (byte offset 131071) by dereferencing pointer "members + agg_new_idx". Coverity issue: 403099 Fixes: 6d72657 ("net/bonding: add other aggregator modes") Cc: danielx.t.mrzyglod@intel.com Cc: stable@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang Acked-by: Ferruh Yigit --- v2: * Modify the logic of 'max_index()'. --- drivers/net/bonding/rte_eth_bond_8023ad.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index 677067870f..79f1b3f1a0 100644 --- a/drivers/net/bonding/rte_eth_bond_8023ad.c +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c @@ -654,12 +654,9 @@ tx_machine(struct bond_dev_private *internals, uint16_t member_id) } static uint16_t -max_index(uint64_t *a, int n) +max_index(uint64_t *a, uint16_t n) { - if (n <= 0) - return -1; - - int i, max_i = 0; + uint16_t i, max_i = 0; uint64_t max = a[0]; for (i = 1; i < n; ++i) {