From patchwork Wed Nov 1 04:44:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rongwei Liu X-Patchwork-Id: 133703 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C09CA43258; Wed, 1 Nov 2023 05:45:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C45142D78; Wed, 1 Nov 2023 05:45:07 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2051.outbound.protection.outlook.com [40.107.220.51]) by mails.dpdk.org (Postfix) with ESMTP id 7FCAD42D26 for ; Wed, 1 Nov 2023 05:45:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PKIt0nFGpgQYeGVCVgItNQvj9UBFSaOvXaKtr+37qcD8wsuZadVsPulIi3whQPw1vonWtzxG9/e27nSUJcvBDE1U6AiHhH9lc2Ky1MzReoxncgJmqlVm/2zOvQkC/1CTd2nqgcBtl2DbYXfFIJ98x5miRfEq6ioSIUBkJWDHCTXyE7F3CeZx+/uxik8g8mxp4/Xnx4b15JEAfbDFpMVrtGssnQNCce3XBVwK3l26GF/C59+WMLxml/fa3ECuQLu7RHolfd00GiYtI8e5Kgr5Iu27VLYMITHepunJ1nw97haNvJiTMrq9JhbBQ2tnKf/btF37lVeWHTmBHveE3Zg+qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BAAC2XrTMmImjbbFc1PFvXaBKAIWR8rGr4j3bm+76VU=; b=aQODG7CVZM3hrB9GwFPtI4gSkCjpnQ7thrBWTXoRd52C3x8veY6sEdwh3RQSp0L5I2rGExi3ApBjaNTyPdLynwqul4rZxdAv/X3EIRjYHs4/yxabfXdwapHbtg7tdL8lhfvixwKMroosa9oGaFX54nOAQeC9jqy04VE3FAIitXDMoiAJX/DUUWegjRoLaZnpf2FlEnRKfnYn1NUDrneerbeUbGIDSPWpY2Zz+EE4KxY7naSBvzp0rgB9FkbZRA27NrhE8g5auuRHufulqFttpacUrMYGdxPkhcxmJYmjjbOJojYqrSeTqOfmzDu7hMYkCo0cJ8Ntk2Tj7eOIUm1EJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BAAC2XrTMmImjbbFc1PFvXaBKAIWR8rGr4j3bm+76VU=; b=kK8CxTKRjhOGT5c8AM1+RYhprJnD6hMXuhKn15ppEPjEBE4fuIGviARluMvmjAj4A34YQ2eue6ZpTon3YnSOKbSPbQoRuBkK3sBQuflfWIbRuReBqYGINZsmqS3he7WiPaAUnSsYsmRUgY/J6Wb8cu7NpvarFYHb1uzZVHvyaUdtgPif3C/RejJSlk2gog5euIL5uaAqdygaUu9hFJ/gUz1uB6T+cgMqMtUUoVOLGY2NEPgqvX7t6A7FZ+rrRHErEBFo1gDH+B6zLZOV5bgF9wUrG+ksDFTofL24LaTngiBLlFmnqmMmyVUsRPm0SjM1gr0QVIj0JoUrYjcqmRhOEA== Received: from CY8PR19CA0014.namprd19.prod.outlook.com (2603:10b6:930:44::19) by SA1PR12MB7149.namprd12.prod.outlook.com (2603:10b6:806:29c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.26; Wed, 1 Nov 2023 04:45:02 +0000 Received: from CY4PEPF0000E9D3.namprd03.prod.outlook.com (2603:10b6:930:44:cafe::22) by CY8PR19CA0014.outlook.office365.com (2603:10b6:930:44::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19 via Frontend Transport; Wed, 1 Nov 2023 04:45:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000E9D3.mail.protection.outlook.com (10.167.241.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19 via Frontend Transport; Wed, 1 Nov 2023 04:45:02 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 31 Oct 2023 21:44:57 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 31 Oct 2023 21:44:54 -0700 From: Rongwei Liu To: , , , , , CC: , Alex Vesker Subject: [PATCH v4 08/13] net/mlx5/hws: fix potential wrong rte_errno value Date: Wed, 1 Nov 2023 06:44:14 +0200 Message-ID: <20231101044419.732726-9-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20231101044419.732726-1-rongweil@nvidia.com> References: <20231031105131.441078-1-rongweil@nvidia.com> <20231101044419.732726-1-rongweil@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D3:EE_|SA1PR12MB7149:EE_ X-MS-Office365-Filtering-Correlation-Id: 72555a41-1e6e-45bb-b767-08dbda954f7e X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YJbJmmu/VTSFTWU2vylNLutHsoAFmH9hlv+53Qul3++B7xcBfmLjvAfSRmC9y62gVrH5i+O6vBI8u6TNn/DyIB9WUfljcPDt66vyozm/a8ZZRPR+3U7CzshZfUvYZ+0a2zFkabESqj+ojXaOAPC97sgjrj5LG4prWr0risKdnV9+/+Qa2E9xpfxTbTMB09ynjBJKyV919YpOuEOcMz7T5MP7bTLirwOchOOuGIV1E9Cv1n6k1P10HU0k9kzxDat+NedMZ3ILzcVvEpNm5bzAeHJQns7lkKfnolnxMZa933sDvl73Q8RdekesidZpi36oEszJGx1C59kEt8qADmcCuyGZuv8YdCWmQ0kQJXXYgjuVtJEiTk1uUyQbo3i4L3+Jcudc81Y6cWSqLDkJydZGtI9p2gQ4oXDs2t94uR106QGGWnSJUs+shqMtm4DkEIMHJBrSJUisyKwTG36Vqpzqn+gWVrr/O+25NNVzpqU5a2HgZFi9K3h8mMuBStFPoLPAGo8U0FgkYx2ezwp7f+cafjJ0z1VZeUM6EZ3Tn/w9fQjAXy6VwrpUE7itiwAEsbW0vGKKBu8ok/+1RXjmarDG69gFoZItr7WEZfETcheIooWgETHzsfKro1u+2Y5iGS/DuRFuq543j7xBxoVkXDk/0GTtt1Mrh7Ptw9K+ZKrLGpNf9BzoAxDiUlHwXy/PKluMAB33KvkFx1EyEHOxtamAYFqFw1YPchCmLq8xU/7TYIEwDhlfOHv2AK6TIzktJp3s X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(346002)(39860400002)(396003)(136003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(82310400011)(46966006)(40470700004)(36840700001)(47076005)(54906003)(316002)(36860700001)(82740400003)(8676002)(41300700001)(8936002)(86362001)(478600001)(70586007)(2906002)(110136005)(4326008)(70206006)(55016003)(40480700001)(426003)(7636003)(336012)(356005)(5660300002)(36756003)(1076003)(40460700003)(26005)(6286002)(16526019)(83380400001)(2616005)(107886003)(6666004)(7696005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 04:45:02.0181 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72555a41-1e6e-45bb-b767-08dbda954f7e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D3.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7149 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org A valid rte_errno is desired when DR layer api returns error and it can't over-write the value set by under-layer. Fixes: 0a2657c4ff4d ("net/mlx5/hws: support insert header action") Cc: hamdani@nvidia.com Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Ori Kam --- drivers/net/mlx5/hws/mlx5dr_action.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c index 98bb556b7b..e66a8135dc 100644 --- a/drivers/net/mlx5/hws/mlx5dr_action.c +++ b/drivers/net/mlx5/hws/mlx5dr_action.c @@ -2015,6 +2015,7 @@ mlx5dr_action_create_insert_header(struct mlx5dr_context *ctx, if (!num_of_hdrs) { DR_LOG(ERR, "Reformat num_of_hdrs cannot be zero"); + rte_errno = EINVAL; return NULL; } @@ -2062,7 +2063,6 @@ mlx5dr_action_create_insert_header(struct mlx5dr_context *ctx, reformat_hdrs, log_bulk_size); if (ret) { DR_LOG(ERR, "Failed to create HWS reformat action"); - rte_errno = EINVAL; goto free_reformat_hdrs; }