From patchwork Tue Nov 7 09:59:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Duszynski X-Patchwork-Id: 133932 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41545432C5; Tue, 7 Nov 2023 11:00:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1277402BC; Tue, 7 Nov 2023 11:00:02 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 70F5B4003C for ; Tue, 7 Nov 2023 11:00:00 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A77phRW004085 for ; Tue, 7 Nov 2023 01:59:59 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=b4/+5JQnSnBKCcX/GKZjmqrqJwe/b5LTkerR+NazL0k=; b=jUuTJCtlfHt5AQMOS/WV0FAWHPeENI3z3IWSw3n9TQOYymRvdvrjCWV2+dlSFJInXhcy iaep4Qsk5uVmJiY14J4F0cB/qPvFOKQrEXr5nSIdTuyg3glnxL2rxHA32QP+fxYhPUve 6M9Wg1KblJtRmKUj0rq9oCzLF4dA2EwhvHs2rk1VlrL5AaU+SRfJB94DTSyXrewR+c9i 5SjP8Wf4mieaExCiEA2LYvfSpK3PghMSEE4dPXJ+LbQ98pwaT3AGvy91R7HhCJN+BQiO TzElHhj8Z6w/6OpwvoOqPJWweT+ZFSFI1r7DL+W8cDiprpCA9rBRp7raPV7g2l/2JNM/ Tg== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3u7h7crd6f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 07 Nov 2023 01:59:59 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 7 Nov 2023 01:59:57 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 7 Nov 2023 01:59:57 -0800 Received: from cavium-DT10.. (unknown [10.28.34.39]) by maili.marvell.com (Postfix) with ESMTP id BDF953F7099; Tue, 7 Nov 2023 01:59:55 -0800 (PST) From: Tomasz Duszynski To: , Jakub Palider , Tomasz Duszynski CC: Subject: [PATCH] raw/cnxk_gpio: fix resource leak Date: Tue, 7 Nov 2023 10:59:46 +0100 Message-ID: <20231107095946.3227242-1-tduszynski@marvell.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Proofpoint-GUID: DehHmpV8KGj9zw8k8ZeQxDPYWsG6NMPy X-Proofpoint-ORIG-GUID: DehHmpV8KGj9zw8k8ZeQxDPYWsG6NMPy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-06_15,2023-11-02_03,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix resource leak. Coverity issue: 405118 Fixes: ef2a3f3b4c9e ("raw/cnxk_gpio: support multi-process") Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index ebc914afcf..45e2ab5e00 100644 --- a/drivers/raw/cnxk_gpio/cnxk_gpio.c +++ b/drivers/raw/cnxk_gpio/cnxk_gpio.c @@ -171,8 +171,10 @@ cnxk_gpio_parse_store_args(struct cnxk_gpio_params **params, const char *args) len += strlen(allowlist) + 1; *params = cnxk_gpio_params_reserve(len); - if (!(*params)) - return -ENOMEM; + if (!(*params)) { + ret = -ENOMEM; + goto out; + } strlcpy((*params)->allowlist, allowlist, strlen(allowlist) + 1);