[v1,1/1] devtools: update sources in build tags script

Message ID 20231108044433.11176-1-syalavarthi@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v1,1/1] devtools: update sources in build tags script |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Srikanth Yalavarthi Nov. 8, 2023, 4:44 a.m. UTC
  As part of deprecating kmods meson option, 'kernel/linux'
directory is removed from the repository.

This patch removes non-existing 'kernel/linux' directory
from linux_sources of build tags script.

Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
 devtools/build-tags.sh | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Ferruh Yigit Nov. 8, 2023, 8:48 a.m. UTC | #1
On 11/8/2023 4:44 AM, Srikanth Yalavarthi wrote:
> As part of deprecating kmods meson option, 'kernel/linux'
> directory is removed from the repository.
> 
> This patch removes non-existing 'kernel/linux' directory
> from linux_sources of build tags script.
> 
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---
>  devtools/build-tags.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
> index bf3b13ebac..e07349a47f 100755
> --- a/devtools/build-tags.sh
> +++ b/devtools/build-tags.sh
> @@ -68,7 +68,6 @@ common_sources()
>  linux_sources()
>  {
>  	find_sources "lib/eal/linux" '*.[chS]'
> -	find_sources "kernel/linux" '*.[chS]'
>  }
>  
>  bsd_sources()

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>


Can you please add the fixes tag, it should be the commit that
deprecates kmods but missed to update this file?
  
Srikanth Yalavarthi Nov. 8, 2023, 9:29 a.m. UTC | #2
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: 08 November 2023 14:19
> To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarnara@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; thomas@monjalon.net
> Subject: [EXT] Re: [PATCH v1 1/1] devtools: update sources in build tags script
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 11/8/2023 4:44 AM, Srikanth Yalavarthi wrote:
> > As part of deprecating kmods meson option, 'kernel/linux'
> > directory is removed from the repository.
> >
> > This patch removes non-existing 'kernel/linux' directory from
> > linux_sources of build tags script.
> >
> > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> > ---
> >  devtools/build-tags.sh | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh index
> > bf3b13ebac..e07349a47f 100755
> > --- a/devtools/build-tags.sh
> > +++ b/devtools/build-tags.sh
> > @@ -68,7 +68,6 @@ common_sources()
> >  linux_sources()
> >  {
> >  	find_sources "lib/eal/linux" '*.[chS]'
> > -	find_sources "kernel/linux" '*.[chS]'
> >  }
> >
> >  bsd_sources()
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
> 
> 
> Can you please add the fixes tag, it should be the commit that deprecates
> kmods but missed to update this file?
Updated in v2.
  

Patch

diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
index bf3b13ebac..e07349a47f 100755
--- a/devtools/build-tags.sh
+++ b/devtools/build-tags.sh
@@ -68,7 +68,6 @@  common_sources()
 linux_sources()
 {
 	find_sources "lib/eal/linux" '*.[chS]'
-	find_sources "kernel/linux" '*.[chS]'
 }
 
 bsd_sources()