From patchwork Thu Nov 9 04:58:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kaiwen Deng X-Patchwork-Id: 134004 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B296432DE; Thu, 9 Nov 2023 06:39:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 685C5427E0; Thu, 9 Nov 2023 06:39:09 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id AD6874021F; Thu, 9 Nov 2023 06:39:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699508349; x=1731044349; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=wA9bhnGtan5KuR3YrtAaS9iT1SvZwPmMd6HnvyCVWVU=; b=jWS+xIjvV972Dmj1UtuxLBwWAjU+WhwjA0xy/9W6r2jDXpS3VcKZfTAj 6zMMCOa0dm+/P7XFb4tcH/MhsKpOHN7EzmMlq1H4CcXsB571tiKbN9HKq Xo1fFik3RKY3Pw//mcLSwNZz8MtJUrT5Fab2sH45c03Dh0vJf0WTyF/TL dwPu3WEynrGBU5pdEwO0vZtNBbMvGO5TglFNfnxyHOF+y1UXHINzKEsx6 bemT7lFZGzBytJ10++Da39ahOSYchi92LIQodNIm+qR3yNUKEg3gjmgMs SijXcRqGazKwxxO1jzAiIoUQHjnPxX3FZk882sJk7dCxusUCdm6zkJ4Ql w==; X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="369253822" X-IronPort-AV: E=Sophos;i="6.03,288,1694761200"; d="scan'208";a="369253822" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2023 21:39:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="756787872" X-IronPort-AV: E=Sophos;i="6.03,288,1694761200"; d="scan'208";a="756787872" Received: from shwdenpg561.ccr.corp.intel.com (HELO dpdk..) ([10.239.252.3]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2023 21:39:03 -0800 From: Kaiwen Deng To: dev@dpdk.org Cc: stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Kaiwen Deng , Jingjing Wu , Beilei Xing , Zhichao Zeng Subject: [PATCH v4] net/iavf: fix mbuf release API selection Date: Thu, 9 Nov 2023 12:58:36 +0800 Message-Id: <20231109045836.814164-1-kaiwenx.deng@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231102044316.541458-1-kaiwenx.deng@intel.com> References: <20231102044316.541458-1-kaiwenx.deng@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When AVX2 is forcibly selected and outer checksum offload is configured, the basic Tx path will be selected. Also, the txq mbuf release API is incorrectly set to iavf_tx_queue_release_mbufs_sse. This causes coredump. This commit selects release_txq_mbufs to releasing txq mbufs when selecting the basic Tx path. Fixes: 22f1e7608ebc ("net/iavf: fix AVX2 Tx selection") Cc: stable@dpdk.org Signed-off-by: Kaiwen Deng Acked-by: Qi Zhang --- drivers/net/iavf/iavf_rxtx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index 45f638c1d2..f19aa14646 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -4018,11 +4018,9 @@ iavf_set_tx_function(struct rte_eth_dev *dev) PMD_DRV_LOG(DEBUG, "Using AVX2 Vector Tx (port %d).", dev->data->port_id); } else if (check_ret == IAVF_VECTOR_CTX_OFFLOAD_PATH) { - dev->tx_pkt_burst = iavf_xmit_pkts; - dev->tx_pkt_prepare = iavf_prep_pkts; PMD_DRV_LOG(DEBUG, - "AVX2 does not support outer checksum offload, using Basic Tx (port %d).", - dev->data->port_id); + "AVX2 does not support outer checksum offload."); + goto normal; } else { dev->tx_pkt_burst = iavf_xmit_pkts_vec_avx2_offload; dev->tx_pkt_prepare = iavf_prep_pkts;