diff mbox series

[v2,10/16] app/pdump: verify strdup return value

Message ID	20231110100117.8350-11-fengchengwen@huawei.com (mailing list archive)
State	Accepted, archived
Delegated to:	Thomas Monjalon
Headers	From: Chengwen Feng <fengchengwen@huawei.com> To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Reshma Pattan <reshma.pattan@intel.com>, Stephen Hemminger <stephen@networkplumber.org>, <konstantin.ananyev@huawei.com> CC: <dev@dpdk.org> Subject: [PATCH v2 10/16] app/pdump: verify strdup return value Date: Fri, 10 Nov 2023 10:01:11 +0000 Message-ID: <20231110100117.8350-11-fengchengwen@huawei.com> In-Reply-To: <20231110100117.8350-1-fengchengwen@huawei.com> References: <20231110100117.8350-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	verify strdup return value \| [v2,00/16] verify strdup return value [v2,01/16] eal: verify strdup return value [v2,02/16] bus/dpaa: verify strdup return value [v2,03/16] bus/fslmc: verify strdup return value [v2,04/16] bus/vdev: verify strdup return value [v2,05/16] dma/idxd: verify strdup return value [v2,06/16] event/cnxk: verify strdup return value [v2,07/16] net/failsafe: fix memory leak when parse args [v2,08/16] net/nfp: verify strdup return value [v2,09/16] app/dumpcap: verify strdup return value [v2,10/16] app/pdump: verify strdup return value [v2,11/16] app/test: verify strdup return value [v2,12/16] app/test-crypto-perf: verify strdup return value [v2,13/16] app/test-dma-perf: verify strdup return value [v2,14/16] app/testpmd: verify strdup return value [v2,15/16] examples/qos_sched: fix memory leak when parse args [v2,16/16] examples/vhost: verify strdup return value

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

fengchengwen Nov. 10, 2023, 10:01 a.m. UTC

  Add verify strdup return value logic.

Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 app/pdump/main.c | 3 +++
 1 file changed, 3 insertions(+)

diff mbox series

Patch

diff --git a/app/pdump/main.c b/app/pdump/main.c
index 7a1c7bdf60..a9205e130b 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -171,6 +171,9 @@  parse_device_id(const char *key __rte_unused, const char *value,
 	struct pdump_tuples *pt = extra_args;
 
 	pt->device_id = strdup(value);
+	if (pt->device_id == NULL)
+		return -1;
+
 	pt->dump_by_type = DEVICE_ID;
 
 	return 0;