diff mbox series

[v2,14/16] app/testpmd: verify strdup return value

Message ID	20231110100117.8350-15-fengchengwen@huawei.com (mailing list archive)
State	Accepted, archived
Delegated to:	Thomas Monjalon
Headers	From: Chengwen Feng <fengchengwen@huawei.com> To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>, Wenxuan Wu <wenxuanx.wu@intel.com>, Yuan Wang <yuanx.wang@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Xuan Ding <xuan.ding@intel.com> CC: <dev@dpdk.org> Subject: [PATCH v2 14/16] app/testpmd: verify strdup return value Date: Fri, 10 Nov 2023 10:01:15 +0000 Message-ID: <20231110100117.8350-15-fengchengwen@huawei.com> In-Reply-To: <20231110100117.8350-1-fengchengwen@huawei.com> References: <20231110100117.8350-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	verify strdup return value \| [v2,00/16] verify strdup return value [v2,01/16] eal: verify strdup return value [v2,02/16] bus/dpaa: verify strdup return value [v2,03/16] bus/fslmc: verify strdup return value [v2,04/16] bus/vdev: verify strdup return value [v2,05/16] dma/idxd: verify strdup return value [v2,06/16] event/cnxk: verify strdup return value [v2,07/16] net/failsafe: fix memory leak when parse args [v2,08/16] net/nfp: verify strdup return value [v2,09/16] app/dumpcap: verify strdup return value [v2,10/16] app/pdump: verify strdup return value [v2,11/16] app/test: verify strdup return value [v2,12/16] app/test-crypto-perf: verify strdup return value [v2,13/16] app/test-dma-perf: verify strdup return value [v2,14/16] app/testpmd: verify strdup return value [v2,15/16] examples/qos_sched: fix memory leak when parse args [v2,16/16] examples/vhost: verify strdup return value

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

fengchengwen Nov. 10, 2023, 10:01 a.m. UTC

  Add verify strdup return value logic.

Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 app/test-pmd/cmdline.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ivan Malov Nov. 10, 2023, 11:44 a.m. UTC | #1

Hi,

On Fri, 10 Nov 2023, Chengwen Feng wrote:

> Add verify strdup return value logic.
>
> Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
> app/test-pmd/cmdline.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 912bf3355c..904c04d466 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -3528,6 +3528,8 @@ parse_hdrs_list(const char *str, const char *item_name, unsigned int max_items,
>
> 	nb_item = 0;
> 	char *str2 = strdup(str);
> +	if (str2 == NULL)
> +		return nb_item;
> 	cur = strtok_r(str2, ",", &tmp);
> 	while (cur != NULL) {
> 		parsed_items[nb_item] = get_ptype(cur);
> -- 
> 2.17.1
>
>

Acked-by: Ivan Malov <ivan.malov@arknetworks.am>

Thank you.

lihuisong (C) Nov. 21, 2023, 3:32 a.m. UTC | #2

Acked-by: Huisong Li <lihuisong@huawei.com>

在 2023/11/10 18:01, Chengwen Feng 写道:
> Add verify strdup return value logic.
>
> Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
>   app/test-pmd/cmdline.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 912bf3355c..904c04d466 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -3528,6 +3528,8 @@ parse_hdrs_list(const char *str, const char *item_name, unsigned int max_items,
>   
>   	nb_item = 0;
>   	char *str2 = strdup(str);
> +	if (str2 == NULL)
> +		return nb_item;
>   	cur = strtok_r(str2, ",", &tmp);
>   	while (cur != NULL) {
>   		parsed_items[nb_item] = get_ptype(cur);

diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 912bf3355c..904c04d466 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3528,6 +3528,8 @@  parse_hdrs_list(const char *str, const char *item_name, unsigned int max_items,
 
 	nb_item = 0;
 	char *str2 = strdup(str);
+	if (str2 == NULL)
+		return nb_item;
 	cur = strtok_r(str2, ",", &tmp);
 	while (cur != NULL) {
 		parsed_items[nb_item] = get_ptype(cur);