diff mbox series

[v2,04/16] bus/vdev: verify strdup return value

Message ID	20231110100117.8350-5-fengchengwen@huawei.com (mailing list archive)
State	Accepted, archived
Delegated to:	Thomas Monjalon
Headers	From: Chengwen Feng <fengchengwen@huawei.com> To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, Gaetan Rivet <grive@u256.net>, Xueming Li <xuemingl@nvidia.com>, Ray Kinsella <mdr@ashroe.eu> CC: <dev@dpdk.org> Subject: [PATCH v2 04/16] bus/vdev: verify strdup return value Date: Fri, 10 Nov 2023 10:01:05 +0000 Message-ID: <20231110100117.8350-5-fengchengwen@huawei.com> In-Reply-To: <20231110100117.8350-1-fengchengwen@huawei.com> References: <20231110100117.8350-1-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	verify strdup return value \| [v2,00/16] verify strdup return value [v2,01/16] eal: verify strdup return value [v2,02/16] bus/dpaa: verify strdup return value [v2,03/16] bus/fslmc: verify strdup return value [v2,04/16] bus/vdev: verify strdup return value [v2,05/16] dma/idxd: verify strdup return value [v2,06/16] event/cnxk: verify strdup return value [v2,07/16] net/failsafe: fix memory leak when parse args [v2,08/16] net/nfp: verify strdup return value [v2,09/16] app/dumpcap: verify strdup return value [v2,10/16] app/pdump: verify strdup return value [v2,11/16] app/test: verify strdup return value [v2,12/16] app/test-crypto-perf: verify strdup return value [v2,13/16] app/test-dma-perf: verify strdup return value [v2,14/16] app/testpmd: verify strdup return value [v2,15/16] examples/qos_sched: fix memory leak when parse args [v2,16/16] examples/vhost: verify strdup return value

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

fengchengwen Nov. 10, 2023, 10:01 a.m. UTC

  Add verify strdup return value logic.

Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 drivers/bus/vdev/vdev.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

lihuisong (C) Nov. 21, 2023, 3:36 a.m. UTC | #1

Acked-by: Huisong Li <lihuisong@huawei.com>

在 2023/11/10 18:01, Chengwen Feng 写道:
> Add verify strdup return value logic.
>
> Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
>   drivers/bus/vdev/vdev.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index 7974b27295..05582f1727 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -247,6 +247,10 @@ alloc_devargs(const char *name, const char *args)
>   		devargs->data = strdup(args);
>   	else
>   		devargs->data = strdup("");
> +	if (devargs->data == NULL) {
> +		free(devargs);
> +		return NULL;
> +	}
>   	devargs->args = devargs->data;
>   
>   	ret = strlcpy(devargs->name, name, sizeof(devargs->name));

diff mbox series

Patch

diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 7974b27295..05582f1727 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -247,6 +247,10 @@  alloc_devargs(const char *name, const char *args)
 		devargs->data = strdup(args);
 	else
 		devargs->data = strdup("");
+	if (devargs->data == NULL) {
+		free(devargs);
+		return NULL;
+	}
 	devargs->args = devargs->data;
 
 	ret = strlcpy(devargs->name, name, sizeof(devargs->name));