From patchwork Fri Nov 10 10:01:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: fengchengwen X-Patchwork-Id: 134091 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1D3C432F3; Fri, 10 Nov 2023 11:04:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 140A442DF3; Fri, 10 Nov 2023 11:04:09 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 758CA42DDF for ; Fri, 10 Nov 2023 11:04:03 +0100 (CET) Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SRZCk6nmrzWhJH; Fri, 10 Nov 2023 18:03:46 +0800 (CST) Received: from localhost.localdomain (10.50.165.33) by dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 10 Nov 2023 18:04:02 +0800 From: Chengwen Feng To: , , Chaoyong He , Shihong Wang , Chang Miao CC: Subject: [PATCH v2 08/16] net/nfp: verify strdup return value Date: Fri, 10 Nov 2023 10:01:09 +0000 Message-ID: <20231110100117.8350-9-fengchengwen@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231110100117.8350-1-fengchengwen@huawei.com> References: <20231110100117.8350-1-fengchengwen@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.50.165.33] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml100024.china.huawei.com (7.185.36.115) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add verify strdup return value logic. Fixes: 3d21da66c06b ("net/nfp: create security session") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Chaoyong He --- drivers/net/nfp/nfp_ipsec.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c index 452947380e..7ce9cca0b2 100644 --- a/drivers/net/nfp/nfp_ipsec.c +++ b/drivers/net/nfp/nfp_ipsec.c @@ -524,6 +524,11 @@ nfp_aesgcm_iv_update(struct ipsec_add_sa *cfg, uint8_t *cfg_iv; iv_str = strdup(iv_string); + if (iv_str == NULL) { + PMD_DRV_LOG(ERR, "Failed to strdup iv_string"); + return; + } + cfg_iv = (uint8_t *)cfg->aesgcm_fields.iv; for (i = 0; i < iv_len; i++) {