From patchwork Mon Nov 13 10:44:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mingjin Ye X-Patchwork-Id: 134154 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10B38430AB; Mon, 13 Nov 2023 11:59:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D21324026C; Mon, 13 Nov 2023 11:59:17 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 0220C4021F; Mon, 13 Nov 2023 11:59:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699873157; x=1731409157; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=M2d5k4P7asfkZgMcSriURu1Ge24JMI9HRzqhjXSRbYg=; b=J+ciapK4mqNAMKr3QNZo6KX5BMxuT5UbMOvj7picVHSUbAbnGixD0KYd feuOw7yDYoYNqL5DKNOF1ybgDVLubmEcuNoFnTk3eZUujkrOjd35XvH18 nkj7F6ATXezOSsayNyYL36X36nrhEEDOVLC0NAVvSdsRWlCSN7M0NxVgx oJawdVSHX8vhNroYiSDTvLvQCFc3zUlysK+IOWemICagyoJ2glg56P01m GCr6fUpU+hm7ORw6De4mwxToa1jl3bOrhrkX+p0NFK0oMKBCBitoCLUKi 5hkzJVsoiJ+gVhtYeXdv15Tw5th8pD4KgUFksFDw75MiomZmdxWLv1lhR w==; X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="9057780" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="9057780" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2023 02:59:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10892"; a="887898200" X-IronPort-AV: E=Sophos;i="6.03,299,1694761200"; d="scan'208";a="887898200" Received: from unknown (HELO localhost.localdomain) ([10.239.252.253]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2023 02:59:12 -0800 From: Mingjin Ye To: dev@dpdk.org Cc: qiming.yang@intel.com, Mingjin Ye , stable@dpdk.org, Jingjing Wu , Beilei Xing Subject: [PATCH] net/iavf: fix error devargs parsing Date: Mon, 13 Nov 2023 10:44:36 +0000 Message-Id: <20231113104436.86555-1-mingjinx.ye@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch fixes an unknown parsing result without devarg "no-poll-on-link-down". Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down") Cc: stable@dpdk.org Signed-off-by: Mingjin Ye --- drivers/net/iavf/iavf_ethdev.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 0c6ab4ac5a..d1edb0dd5c 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -2294,7 +2294,6 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev) struct rte_kvargs *kvlist; int ret; int watchdog_period = -1; - uint16_t no_poll_on_link_down; if (!devargs) return 0; @@ -2329,13 +2328,9 @@ static int iavf_parse_devargs(struct rte_eth_dev *dev) ad->devargs.watchdog_period = watchdog_period; ret = rte_kvargs_process(kvlist, IAVF_NO_POLL_ON_LINK_DOWN_ARG, - &parse_u16, &no_poll_on_link_down); + &parse_bool, &ad->devargs.no_poll_on_link_down); if (ret) goto bail; - if (no_poll_on_link_down == 0) - ad->devargs.no_poll_on_link_down = 0; - else - ad->devargs.no_poll_on_link_down = 1; if (ad->devargs.quanta_size != 0 && (ad->devargs.quanta_size < 256 || ad->devargs.quanta_size > 4096 ||