diff mbox series

[09/21] lib/dmadev: replace strtok with strtok_r

Message ID	20231113104550.2138654-10-haijie1@huawei.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Jie Hai <haijie1@huawei.com> To: <dev@dpdk.org>, Chengwen Feng <fengchengwen@huawei.com>, Kevin Laatz <kevin.laatz@intel.com>, Bruce Richardson <bruce.richardson@intel.com> CC: <haijie1@huawei.com>, <lihuisong@huawei.com> Subject: [PATCH 09/21] lib/dmadev: replace strtok with strtok_r Date: Mon, 13 Nov 2023 18:45:38 +0800 Message-ID: <20231113104550.2138654-10-haijie1@huawei.com> In-Reply-To: <20231113104550.2138654-1-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace strtok with strtok_r \| [00/21] replace strtok with strtok_r [01/21] app/graph: replace strtok with strtok_r [02/21] app/test-bbdev: replace strtok with strtok_r [03/21] app/test-compress-perf: replace strtok with strtok_r [04/21] app/test-crypto-perf: replace strtok with strtok_r [05/21] app/test-dma-perf: replace strtok with strtok_r [06/21] app/test-fib: replace strtok with strtok_r [07/21] app/dpdk-test-flow-perf: replace strtok with strtok_r [08/21] app/test-mldev: replace strtok with strtok_r [09/21] lib/dmadev: replace strtok with strtok_r [10/21] lib/eal: replace strtok with strtok_r [11/21] lib/ethdev: replace strtok with strtok_r [12/21] lib/eventdev: replace strtok with strtok_r [13/21] lib/telemetry: replace strtok with strtok_r [14/21] lib/telemetry: replace strtok with strtok_r [15/21] bus/fslmc: replace strtok with strtok_r [16/21] common/cnxk: replace strtok with strtok_r [17/21] event/cnxk: replace strtok with strtok_r [18/21] net/ark: replace strtok with strtok_r [19/21] raw/cnxk_gpio: replace strtok with strtok_r [20/21] examples/l2fwd-crypto: replace strtok with strtok_r [21/21] examples/vhost: replace strtok with strtok_r

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Jie Hai Nov. 13, 2023, 10:45 a.m. UTC

  Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

The strtok() is non-reentrant, it is better to replace it with a
reentrant function.

Signed-off-by: Jie Hai <haijie1@huawei.com>
---
 lib/dmadev/rte_dmadev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff mbox series

Patch

diff --git a/lib/dmadev/rte_dmadev.c b/lib/dmadev/rte_dmadev.c
index 4e5e420c82a5..f856cc7d0905 100644
--- a/lib/dmadev/rte_dmadev.c
+++ b/lib/dmadev/rte_dmadev.c
@@ -971,7 +971,7 @@  dmadev_handle_dev_stats(const char *cmd __rte_unused,
 	struct rte_dma_info dma_info;
 	struct rte_dma_stats dma_stats;
 	int dev_id, ret, vchan_id;
-	char *end_param;
+	char *end_param, *sp = NULL;
 	const char *vchan_param;
 
 	if (params == NULL || strlen(params) == 0 || !isdigit(*params))
@@ -990,7 +990,7 @@  dmadev_handle_dev_stats(const char *cmd __rte_unused,
 	if (dma_info.nb_vchans == 1 && *end_param == '\0')
 		vchan_id = 0;
 	else {
-		vchan_param = strtok(end_param, ",");
+		vchan_param = strtok_r(end_param, ",", &sp);
 		if (!vchan_param || strlen(vchan_param) == 0 || !isdigit(*vchan_param))
 			return -EINVAL;